Deprecate ParserOptions::setExternalLinkTarget()
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	cscott
	Sep 13 2022, 2:44 PM

Description

The $wgExternalLinkTarget configuration option is mostly site-static, except for a single use in the Installer:

https://codesearch.wmcloud.org/search/?q=setExternalLinkTarget&i=nope&files=&excludeFiles=&repos=

The installer uses an ad-hoc parser anyway (see T317644). It should just reset the site configuration as needed, rather than use a parser option here.

We can start by marking ParserOptions::setExternalLinkTarget() @internal, and deprecate and remove it once the Installer is rewritten to use Parsoid.

Details

	Subject	Repo	Branch	Lines +/-
	Mark ParserOptions::{get,set}ExternalLinkTarget() @internal	mediawiki/core	master	+8 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open		None	T317644 Port Installer to Parsoid
		Open		None	T317647 Deprecate ParserOptions::setExternalLinkTarget()

Event Timeline

cscott created this task.Sep 13 2022, 2:44 PM

Change 831904 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Mark ParserOptions::{get,set}ExternalLinkTarget() @internal

https://gerrit.wikimedia.org/r/831904

gerritbot added a project: Patch-For-Review.Sep 13 2022, 3:11 PM

cscott mentioned this in T318826: Deprecate ParserOptions::setMaxTemplateDepth().Sep 28 2022, 3:06 PM

Change 831904 merged by jenkins-bot:

[mediawiki/core@master] Mark ParserOptions::{get,set}ExternalLinkTarget() @internal

https://gerrit.wikimedia.org/r/831904

Maintenance_bot removed a project: Patch-For-Review.Sep 28 2022, 8:31 PM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.4; 2022-10-03).Sep 28 2022, 9:00 PM

Deprecate ParserOptions::setExternalLinkTarget()Open, Needs TriagePublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

Deprecate ParserOptions::setExternalLinkTarget()
Open, Needs TriagePublic
Actions

Related Objects
Search...