Maniphest T317914

Update CheckUser to use the PagerNavigationBuilder
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Dreamy_Jazz
	Sep 15 2022, 7:26 PM

Tags

Referenced Files

None

Subscribers

Description

Following the introduction of the PagerNavigationBuilder, the override of the IndexPager's makeLink method should be updated to instead override the PagerNavigationBuilder::makeLink method through a class that extends the builder. Places to address:

AbstractCheckUserPager::makeLink

Details

	Subject	Repo	Branch	Lines +/-
	Use PagerNavigationBuilder over overriding IndexPager::makeLink	mediawiki/extensions/CheckUser	master	+148 -57

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Feature	matmarex	T308364 HTML enhancement for some special pages' navigation links
		Open		None	T317913 Update overrides or uses of IndexPager::makeLink to instead override / use PagerNavigationBuilder::makeLink
		Resolved		Dreamy_Jazz	T317914 Update CheckUser to use the PagerNavigationBuilder

Event Timeline

Dreamy_Jazz created this task.Sep 15 2022, 7:26 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 15 2022, 7:26 PM

Dreamy_Jazz added a parent task: T317913: Update overrides or uses of IndexPager::makeLink to instead override / use PagerNavigationBuilder::makeLink.Sep 15 2022, 7:27 PM

Dreamy_Jazz updated the task description. (Show Details)Sep 15 2022, 7:41 PM

Dreamy_Jazz moved this task from General / Unsorted to CheckUser on the CheckUser board.Sep 15 2022, 7:54 PM

Change 834594 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Use PagerNavigationBuilder over overriding IndexPager::makeLink

https://gerrit.wikimedia.org/r/834594

gerritbot added a project: Patch-For-Review.Sep 23 2022, 4:02 PM

Dreamy_Jazz claimed this task.Sep 23 2022, 4:03 PM

Dreamy_Jazz triaged this task as Low priority.

Dreamy_Jazz moved this task from CheckUser to Patches for review on the CheckUser board.Sep 23 2022, 9:32 PM

Change 834594 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Use PagerNavigationBuilder over overriding IndexPager::makeLink

https://gerrit.wikimedia.org/r/834594

Maintenance_bot removed a project: Patch-For-Review.Oct 5 2022, 3:30 PM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.5; 2022-10-10).Oct 5 2022, 4:00 PM

Dreamy_Jazz updated the task description. (Show Details)Oct 5 2022, 5:14 PM

With thanks to @Zabe for the merge.

Dreamy_Jazz moved this task from Patches for review to General / Unsorted on the CheckUser board.Jan 29 2024, 9:24 PM

Dreamy_Jazz moved this task from General / Unsorted to CheckUser on the CheckUser board.Tue, May 28, 4:52 PM