Maniphest T317959

Function editor: Aliases field, repeated values should not be allowed
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	gengh
	Sep 16 2022, 11:28 AM

Tags

Referenced Files

	Restricted File
	Sep 16 2022, 11:28 AM

Subscribers

Description

Steps to reproduce

Go to create new function page
In the Alias field, enter a few identical aliases

Observed behavior

Identical aliases are converted into chips, and they are all saved in the final ZObject.

{F35522175}

Details

	Subject	Repo	Branch	Lines +/-
	FunctionDefinitionAliases: Do not allow users to enter duplicate aliases	mediawiki/extensions/WikiLambda	master	+33 -0

Customize query in gerrit

Event Timeline

gengh created this task.Sep 16 2022, 11:28 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 16 2022, 11:28 AM

gengh updated the task description. (Show Details)Sep 16 2022, 11:29 AM

• JKieserman claimed this task.Sep 16 2022, 1:11 PM

Change 832687 had a related patch set uploaded (by Jkieserman; author: Jkieserman):

[mediawiki/extensions/WikiLambda@master] do not allow users to enter duplicate aliases

https://gerrit.wikimedia.org/r/832687

gerritbot added a project: Patch-For-Review.Sep 16 2022, 4:18 PM

Change 832687 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] FunctionDefinitionAliases: Do not allow users to enter duplicate aliases

https://gerrit.wikimedia.org/r/832687

Maintenance_bot removed a project: Patch-For-Review.Sep 20 2022, 12:30 PM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.3; 2022-09-26).Sep 20 2022, 1:00 PM

• JKieserman moved this task from Ready: G4. Function view to QA / Ready to close on the Abstract Wikipedia team (Phase θ – Throttling) board.Sep 20 2022, 3:45 PM

gengh closed this task as Resolved.Oct 11 2022, 2:55 PM