Page MenuHomePhabricator
Create Task
Maniphest T318236

scripts/category.py: Enable "-always" option for other actions than clean
Open, MediumPublicFeature
Actions

Description

I'm running the category.py script without the -always argument, so the bot should show the diff and ask if it needs to be edited. But the bot doesn't this, always don't disable, bot making wrong edits.

There seems to be an error at line #1530:

elif option == 'always':
      options[option] = True

Here T291757#7378248 always has been set to always=True as default, so it is always True.

Perhaps this error remained in other scripts.

Related Objects

Event Timeline

Vladis13 created this task.Sep 21 2022, 2:03 PM
Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptSep 21 2022, 2:03 PM
Vladis13 edited projects, added Pywikibot-category.py; removed Pywikibot-Scripts.Sep 21 2022, 2:20 PM
Vladis13 mentioned this in T318239: scripts/category.py: Allow pagegenerators intersection with actions other than "add".
Xqt subscribed.Sep 21 2022, 2:40 PM

Be aware: -always option is defined for clean action only. What is the command line you have used?

Vladis13 added a comment.Sep 21 2022, 2:47 PM

I use the remove command, examples are given here T318239.

Vladis13 added a comment.Sep 21 2022, 2:51 PM

How to disable -always for other bulk edit commands?

Xqt renamed this task from scripts/category.py: Bug of "-always" argument to scripts/category.py: Enable "-always" option for other actions than clean.Sep 21 2022, 4:34 PM
Xqt triaged this task as Medium priority.
Xqt changed the subtype of this task from "Task" to "Feature Request".
Xqt added a comment.Sep 21 2022, 4:36 PM
In T318236#8250626, @Vladis13 wrote:

How to disable -always for other bulk edit commands?

Currently the only way is to simulate the run first using the global -simulate option. I think this your feature request is very important and should be implemented.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits