Page MenuHomePhabricator

blubber-pipeline-publish failure
Closed, ResolvedPublic

Description

...
[Pipeline] sh
+ git add -A
+ git config user.email tcipriani+pipelinebot@wikimedia.org
+ git config user.name PipelineBot
+ git commit -m 'blubberoid: pipeline bot promote' -m 'Promote blubberoid to version 2022-09-21-150715-production' -m 'Job: blubber-pipeline-publish Build: 66'
[uroa0bih 62fee86] blubberoid: pipeline bot promote
 1 file changed, 1 insertion(+), 1 deletion(-)
[Pipeline] withCredentials
Masking supported pattern matches of $GIT_USERNAME or $GIT_PASSWORD
[Pipeline] {
[Pipeline] sh
+ set +x
+ git push origin HEAD:refs/for/master%topic=pipeline-promote,r=24,r=8328
remote: 
remote: Processing changes: refs: 1
remote: Processing changes: refs: 1, done            
remote: ERROR: commit 62fee86: missing Change-Id in message footer        
remote: 
remote: Hint: to automatically insert a Change-Id, install the hook:        
remote:   gitdir=$(git rev-parse --git-dir); scp -p -P 29418 ****@gerrit.wikimedia.org:hooks/commit-msg ${gitdir}/hooks/        
remote: or, for http(s):        
remote:   f="$(git rev-parse --git-dir)/hooks/commit-msg"; curl -o "$f" https://gerrit.wikimedia.org/r/tools/hooks/commit-msg ; chmod +x "$f"        
remote: and then amend the commit:        
remote:   git commit --amend --no-edit        
remote: Finally, push your changes again        
remote: 
To https://gerrit.wikimedia.org/r/operations/deployment-charts.git
 ! [remote rejected] HEAD -> refs/for/master%topic=pipeline-promote,r=24,r=8328 (commit 62fee86: missing Change-Id in message footer)
error: failed to push some refs to 'https://gerrit.wikimedia.org/r/operations/deployment-charts.git'
[Pipeline] }
[Pipeline] // withCredentials
[Pipeline] sh
+ Error: hudson.AbortException: script returned exit code 1
/srv/jenkins-slave/workspace/blubber-pipeline-publish/deployment-charts@tmp/durable-82a98d4b/script.sh: line 1: Error:: command not found
...

The full transcript is in P34889 (originally from https://integration.wikimedia.org/ci/job/blubber-pipeline-publish/66/console)

Event Timeline

Curious core.hooksPath entry:

dduvall@contint1001:/srv/jenkins-slave/workspace/blubber-pipeline-publish/deployment-charts$ cat .git/config 
[core]
        repositoryformatversion = 0
        filemode = true
        bare = false
        logallrefupdates = true
        hooksPath = /dev/null
[remote "origin"]
        url = https://gerrit.wikimedia.org/r/operations/deployment-charts.git
        fetch = +refs/heads/*:refs/remotes/origin/*
[user]
        email = tcipriani+pipelinebot@wikimedia.org
        name = PipelineBot

Change 833840 had a related patch set uploaded (by Dduvall; author: Dduvall):

[integration/pipelinelib@master] Ensure git hooks are enabled for deployment-charts when committing

https://gerrit.wikimedia.org/r/833840

Change 833840 merged by jenkins-bot:

[integration/pipelinelib@master] Ensure git hooks are enabled for deployment-charts during promote

https://gerrit.wikimedia.org/r/833840

dduvall claimed this task.

Re-ran the failed job after the patch was merged and it successfully pushed the change to deployment-charts.

Looks like disabling hooks by default is new and intended behavior by the Git plugin:

https://github.com/jenkinsci/git-plugin/commit/8cdb1e0d839dee49b84dc71a4a3420199fe90f26

That is in the Git plugin 4.12.0 which I have upgraded on our Jenkins for T315897 (was 4.10.2 previously). I should probably have read the plugin release notes, sorry.