Page MenuHomePhabricator
Create Task
Maniphest T320331

Test failures on PHPUnit 9.5: "Error: Class 'PHPUnit\Framework\Constraint\ArraySubset' not found"
Closed, ResolvedPublic
Actions

Description

PHPUnit tests are failing on master in the WikimediaEvents extension: "Error: Class 'PHPUnit\Framework\Constraint\ArraySubset' not found"

As seen on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/840328: https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php74-noselenium-docker/59438/console

Caused by the PHPUnit 9.5 upgrade in MediaWiki core (T243600).

Details

SubjectRepoBranchLines +/-
tests: Avoid ArraySubset, removed in PHPUnit 9mediawiki/extensions/WikimediaEventsmaster+23 -18
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Oct 8 2022, 7:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 8 2022, 7:40 PM
matmarex triaged this task as Unbreak Now! priority.Oct 8 2022, 7:40 PM

This is blocking merges in WikimediaEvents, and extensions that depend on it.

matmarex added a project: ci-test-error (WMF-deployed Build Failure).Oct 8 2022, 7:45 PM
Daimona claimed this task.Oct 8 2022, 8:32 PM

So, we addressed this a while ago in T244095 because we knew it was coming... But it didn't account for people using the ArraySubset constraint directly...

gerritbot added a comment.Oct 8 2022, 8:51 PM

Change 840339 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/WikimediaEvents@master] tests: Avoid ArraySubset, removed in PHPUnit 9

https://gerrit.wikimedia.org/r/840339

gerritbot added a project: Patch-For-Review.Oct 8 2022, 8:51 PM
gerritbot added a comment.Oct 8 2022, 9:09 PM

Change 840339 merged by jenkins-bot:

[mediawiki/extensions/WikimediaEvents@master] tests: Avoid ArraySubset, removed in PHPUnit 9

https://gerrit.wikimedia.org/r/840339

Daimona closed this task as Resolved.Oct 8 2022, 9:12 PM
Daimona removed a project: Patch-For-Review.
matmarex added a comment.Oct 8 2022, 9:13 PM

Thanks for the quick fix!

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.5; 2022-10-10).Oct 8 2022, 10:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL