| ppelberg | |
| Oct 13 2022, 6:27 PM |
| F57750072: screen-capture.webm | |
| Nov 26 2024, 4:54 PM |
This is a parent task to capture issues related to navigating mobile talk pages.
| Issue | Description | Notes/Links | Task |
|---|---|---|---|
| 1. | It can be tiring to have to scroll to the top of a section you opened so that you can collapse it again and return to a view of the titles of all the discussions that are present on a particular talk page | @Tacsipacsi surfaced this in T319148#8280355 | |
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| [WIP] Make section headings sticky on mobile | mediawiki/extensions/DiscussionTools | master | +79 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T320754 Make it easier to navigate / move around on mobile talk pages | |||
| Resolved | PRODUCTION ERROR | Jdlrobson-WMF | T376048 MFE still have issues with Parsoid Read Views on talk pages (Discussion Tools) - Type Error: startMarker is null |
Change #1098081 had a related patch set uploaded (by Esanders; author: Esanders):
[mediawiki/extensions/DiscussionTools@master] [WIP] Make section headings sticky on mobile
Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
http://patchdemo.wmcloud.org/wikis/d626617dd0/w/
Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted:
Recording of sticky headers demo. Depends on new section wrappers which will be present in Parsoid read views.
Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
http://patchdemo.wmcloud.org/wikis/032f833d78/wiki/Talk:DiscussionTools?mobileaction=toggle_view_mobile&useparsoid=1
Thanks for the patch! Three comments:
Test wiki on Patch demo by ESanders (WMF) using patch(es) linked to this task was deleted:
Not with pure CSS. The "sticky" element has to be a child of the oversized container - in this case it is the header section which contains the title and metadata.
We'd need to use JS to detect when the header is floating and collapse the metadata.
A better solution might be to make the subscribe button icon-only and right-floated so the header bars aren't as tall.
- If I close the topic, my distance from the page top doesn’t change – since I was far from the top of the topic, I’m now far from the whole topic (as the top kept its position, while the bottom went all the way up), which is very annoying. Could it be made so that the topic header I’ve just collapsed remains in view?
Could be done in JS. If the user was looking at other headings they had scrolled to, then collapsing the open header might page those out of view, but you just have to pick one approach.
- Collapsed topic headers are also sticky, making them move down by a few pixels as I scroll down (tested in Firefox Nightly on Android), which is not a huge problem, but doesn’t look nice. Is there an easy way to disable stickiness in collapsed topics?
Yes - fixed
Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
https://eb2d782b4f.catalyst.wmcloud.org/wiki/DiscussionTools?useparsoid=1