Page MenuHomePhabricator
Create Task
Maniphest T320761

Make LoadBalancer::reportConnectionError() give better messages
Closed, ResolvedPublic
Actions

Description

Errors in Database::initConnection() are suppressed (to try other connections) but LoadBalancer::lastError isn't set properly, resulting in vague "unknown error" exceptions in LoadBalancer::reportConnectionError().

Details

SubjectRepoBranchLines +/-
rdbms: improve LoadBalancer/DatabaseMysqli connection exceptionsmediawiki/coremaster+58 -36
Customize query in gerrit

Event Timeline

aaron created this task.Oct 13 2022, 7:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 13 2022, 7:44 PM
gerritbot added a comment.Oct 13 2022, 11:58 PM

Change 842544 had a related patch set uploaded (by Aaron Schulz; author: Aaron Schulz):

[mediawiki/core@master] rdbms: improve LoadBalancer/DatabaseMysqli connection exceptions

https://gerrit.wikimedia.org/r/842544

gerritbot added a project: Patch-For-Review.Oct 13 2022, 11:58 PM
Krinkle moved this task from Untriaged to Rdbms library on the MediaWiki-libs-Rdbms board.Oct 15 2022, 7:28 PM
Krinkle added a project: Developer Productivity.Oct 17 2022, 6:49 PM
Krinkle moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.
gerritbot added a comment.Nov 2 2022, 12:56 AM

Change 842544 merged by jenkins-bot:

[mediawiki/core@master] rdbms: improve LoadBalancer/DatabaseMysqli connection exceptions

https://gerrit.wikimedia.org/r/842544

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.10; 2022-11-14).Nov 2 2022, 1:00 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 2 2022, 1:30 AM
Krinkle assigned this task to aaron.Nov 3 2022, 11:36 PM
Krinkle triaged this task as Medium priority.
Krinkle removed a project: MW-1.40-notes (1.40.0-wmf.10; 2022-11-14).
aaron closed this task as Resolved.Nov 4 2022, 12:15 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL