PHP Warning: Invalid argument supplied for foreach() in Special:ProtectedTitles page
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	jnuche
	Oct 25 2022, 11:21 AM

Description

Error

mwversion: 1.40.0-wmf.7
reqId: 98017ff4-1964-4d1f-a5bd-dd7b0cbcfa73
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   PHP Warning: Invalid argument supplied for foreach()

exception.trace

from /srv/mediawiki/php-1.40.0-wmf.7/includes/pager/AlphabeticPager.php(51)
#0 /srv/mediawiki/php-1.40.0-wmf.7/includes/pager/AlphabeticPager.php(51): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.40.0-wmf.7/includes/specials/SpecialProtectedtitles.php(84): AlphabeticPager->getNavigationBar()
#2 /srv/mediawiki/php-1.40.0-wmf.7/includes/specialpage/SpecialPage.php(701): SpecialProtectedtitles->execute(NULL)
#3 /srv/mediawiki/php-1.40.0-wmf.7/includes/specialpage/SpecialPageFactory.php(1451): SpecialPage->run(NULL)
#4 /srv/mediawiki/php-1.40.0-wmf.7/includes/MediaWiki.php(316): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#5 /srv/mediawiki/php-1.40.0-wmf.7/includes/MediaWiki.php(904): MediaWiki->performRequest()
#6 /srv/mediawiki/php-1.40.0-wmf.7/includes/MediaWiki.php(562): MediaWiki->main()
#7 /srv/mediawiki/php-1.40.0-wmf.7/index.php(50): MediaWiki->run()
#8 /srv/mediawiki/php-1.40.0-wmf.7/index.php(46): wfIndexMain()
#9 /srv/mediawiki/w/index.php(3): require(string)
#10 {main}

Notes

Observed on mediawikiwiki after deployment of 1.40.0-wmf.7 to group 0.

Reproduces consistently by hitting the Special:ProtectedTitles page: https://www.mediawiki.org/wiki/Special:ProtectedTitles

Main rendering of the page doesn't seem affected. Other special pages don't seem affected.

Details

Request URL: https://www.mediawiki.org/wiki/Special:ProtectedTitles

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
pager: Fix null used for foreach in Pager::getNavigationBar	mediawiki/core	master	+15 -14
pager: Remove unused AlphabeticPager::getOrderTypeMessages() support	mediawiki/core	REL1_39	+2 -36
pager: Fix null used for foreach in Pager::getNavigationBar	mediawiki/core	REL1_39	+15 -14
pager: Remove unused AlphabeticPager::getOrderTypeMessages() support	mediawiki/core	master	+2 -36

Customize query in gerrit

Related Objects

Mentioned In: T321679: PHP Notice: Array to string conversion in Special:NewFiles

Event Timeline

jnuche created this task.Oct 25 2022, 11:21 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 25 2022, 11:21 AM

jnuche renamed this task from PHP Warning: Invalid argument supplied for foreach() to PHP Warning: Invalid argument supplied for foreach() in Special:ProtectedTitles page.Oct 25 2022, 11:24 AM

The code path is only reached when Pager::getIndexField returns an array, which is true since https://gerrit.wikimedia.org/r/c/mediawiki/core/+/787832 for that special page (and some others) and the navigation bar is shown, which has happen after 50 entries. My test wiki does not have that many pages protected, but with a limit=1 I can see it as well.

Change 849132 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] pager: Fix null used for foreach in Pager::getNavigationBar

https://gerrit.wikimedia.org/r/849132

gerritbot added a project: Patch-For-Review.Oct 25 2022, 5:27 PM

jnuche mentioned this in T321679: PHP Notice: Array to string conversion in Special:NewFiles.Oct 26 2022, 12:03 PM

Change 850612 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] pager: Remove unused AlphabeticPager::getOrderTypeMessages() support

https://gerrit.wikimedia.org/r/850612

Krinkle moved this task from Untriaged to Oct 2022 on the Wikimedia-production-error board.Oct 29 2022, 12:32 AM

Change 849132 merged by jenkins-bot:

[mediawiki/core@master] pager: Fix null used for foreach in Pager::getNavigationBar

https://gerrit.wikimedia.org/r/849132

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.8; 2022-10-31).Oct 29 2022, 1:00 AM

The production error is fixed

Change 850612 merged by jenkins-bot:

[mediawiki/core@master] pager: Remove unused AlphabeticPager::getOrderTypeMessages() support

https://gerrit.wikimedia.org/r/850612

ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.10; 2022-11-14); removed MW-1.40-notes (1.40.0-wmf.8; 2022-10-31).Nov 2 2022, 7:00 PM

Change 853027 had a related patch set uploaded (by Bartosz Dziewoński; author: Umherirrender):

[mediawiki/core@REL1_39] pager: Fix null used for foreach in Pager::getNavigationBar

https://gerrit.wikimedia.org/r/853027

Change 853028 had a related patch set uploaded (by Bartosz Dziewoński; author: Krinkle):

[mediawiki/core@REL1_39] pager: Remove unused AlphabeticPager::getOrderTypeMessages() support

https://gerrit.wikimedia.org/r/853028

Change 853027 merged by jenkins-bot: