Page MenuHomePhabricator
Create Task
Maniphest T322172

Excessive Redis cache hits
Closed, ResolvedPublic4 Estimated Story Points
Actions

Description

Tracking Redis cache hits today they still seemed overly high - although the preview patch was still in place & the ones that were the focus of that change were not showing up - I will fill this out further with some thoughts

Details

SubjectRepoBranchLines +/-
Port caching fix for js_stringswikimedia/fundraising/crmmaster+1 -1
Further fixes on Redis output parsingwikimedia/fundraising/crmmaster+7 -1
Add code I used to analyse the Redis Montior outputwikimedia/fundraising/crmmaster+161 -0
Fix 745c4241a7 to really add fastArray cache to mixin cacheswikimedia/fundraising/crmmaster+2 -0
Backport Redis Cache fixwikimedia/fundraising/crmmaster+4 -0
Remove some queue hitswikimedia/fundraising/crmmaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

Eileenmcnaughton created this task.Nov 1 2022, 11:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 1 2022, 11:57 PM
XenoRyet moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.Nov 7 2022, 8:48 PM
greg moved this task from Sprint +1 to Current Sprint on the Fundraising-Backlog board.Nov 9 2022, 9:28 PM
greg added a project: Fundraising Sprint Undefined.
Dwisehaupt set the point value for this task to 4.Nov 14 2022, 9:44 PM
gerritbot added a comment.Nov 14 2022, 10:46 PM

Change 856695 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove some queue hits

https://gerrit.wikimedia.org/r/856695

gerritbot added a project: Patch-For-Review.Nov 14 2022, 10:46 PM
gerritbot added a comment.Nov 14 2022, 11:04 PM

Change 856695 merged by Eileen:

[wikimedia/fundraising/crm@master] Remove some queue hits

https://gerrit.wikimedia.org/r/856695

Maintenance_bot removed a project: Patch-For-Review.Nov 14 2022, 11:30 PM
Eileenmcnaughton mentioned this in T322791: Review our queue speed - is it OK?.Nov 15 2022, 12:18 AM
gerritbot added a comment.Nov 15 2022, 2:54 AM

Change 856720 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Backport Redis Cache fix

https://gerrit.wikimedia.org/r/856720

gerritbot added a project: Patch-For-Review.Nov 15 2022, 2:54 AM
Eileenmcnaughton added a comment.Nov 15 2022, 3:40 AM

Not sure this got linked in https://gerrit.wikimedia.org/r/c/wikimedia/fundraising/crm/+/856703

gerritbot added a comment.Nov 15 2022, 4:35 PM

Change 856720 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Backport Redis Cache fix

https://gerrit.wikimedia.org/r/856720

Maintenance_bot removed a project: Patch-For-Review.Nov 15 2022, 5:30 PM
Eileenmcnaughton claimed this task.Nov 15 2022, 8:33 PM
Eileenmcnaughton moved this task from Backlog to Doing on the Fundraising Sprint Undefined board.
gerritbot added a comment.Nov 16 2022, 1:20 AM

Change 857124 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Fix 745c4241a7 to really add fastArray cache to mixin caches

https://gerrit.wikimedia.org/r/857124

gerritbot added a project: Patch-For-Review.Nov 16 2022, 1:20 AM
gerritbot added a comment.Nov 16 2022, 1:41 AM

Change 857138 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Add code I used to analyse the Redis Montior output

https://gerrit.wikimedia.org/r/857138

gerritbot added a comment.Nov 16 2022, 1:49 AM

Change 857124 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Fix 745c4241a7 to really add fastArray cache to mixin caches

https://gerrit.wikimedia.org/r/857124

gerritbot added a comment.Nov 16 2022, 2:14 AM

Change 857138 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Add code I used to analyse the Redis Montior output

https://gerrit.wikimedia.org/r/857138

Maintenance_bot removed a project: Patch-For-Review.Nov 16 2022, 2:30 AM
Eileenmcnaughton added a comment.Nov 16 2022, 4:04 AM

I just updated docs https://wikitech.wikimedia.org/wiki/Fundraising/Internal-facing/CiviCRM#Redis_monitoring

gerritbot added a comment.Nov 17 2022, 2:49 AM

Change 857901 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Further fixes on Redis output parsing

https://gerrit.wikimedia.org/r/857901

gerritbot added a project: Patch-For-Review.Nov 17 2022, 2:49 AM
gerritbot added a comment.Nov 22 2022, 3:07 AM

Change 857901 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Further fixes on Redis output parsing

https://gerrit.wikimedia.org/r/857901

Maintenance_bot removed a project: Patch-For-Review.Nov 22 2022, 3:30 AM
Eileenmcnaughton moved this task from Doing to Ready for Review on the Fundraising Sprint Undefined board.Nov 22 2022, 5:30 AM
gerritbot added a comment.Nov 22 2022, 5:30 AM

Change 859166 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Port caching fix for js_strings

https://gerrit.wikimedia.org/r/859166

gerritbot added a project: Patch-For-Review.Nov 22 2022, 5:31 AM
Eileenmcnaughton added a comment.Nov 22 2022, 5:33 AM

I've just put in one more port https://github.com/civicrm/civicrm-core/pull/24989

I just pulled down another couple of minutes to monitor - but it was pretty heavy with user searches & only that jumped out at me - I think this might be as long as a piece of string so gonna time-box to this sprint

In terms of monitoring - I updated the docs on wikitech

gerritbot added a comment.Nov 22 2022, 5:59 PM

Change 859166 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Port caching fix for js_strings

https://gerrit.wikimedia.org/r/859166

Eileenmcnaughton moved this task from Ready for Review to Pending Deployment on the Fundraising Sprint Undefined board.Nov 22 2022, 8:55 PM
XenoRyet added a project: Fundraising Sprint Vwl Cnsrvtn.Nov 22 2022, 8:58 PM
Eileenmcnaughton moved this task from Backlog to Done on the Fundraising Sprint Vwl Cnsrvtn board.Nov 22 2022, 10:25 PM
XenoRyet closed this task as Resolved.Dec 6 2022, 8:05 PM
XenoRyet set Final Story Points to 4.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits