Page MenuHomePhabricator
Create Task
Maniphest T322335

API: 'rvdiffto' parameter handling is broken on PHP 8.0
Closed, ResolvedPublicBUG REPORT
Actions

Description

The pre-MCR 'rvdiffto' API parameter allows to supply a revision ID, or the special strings cur, prev or next to revision-related API modules; this will be then resolved to a revision and other returned revisions will be diffed against it.

On PHP >= 8.0, this parameter is no longer working as expected because cur, prev, and next are no longer special-cased - they are treated instead as if the user passed an invalid revision ID.

Details

SubjectRepoBranchLines +/-
ApiQueryRevisionsBase: Fix 'rvdiffto' parameter handling on PHP 8.0mediawiki/coreREL1_39+63 -5
ApiQueryRevisionsBase: Fix 'rvdiffto' parameter handling on PHP 8.0mediawiki/coremaster+63 -5
Customize query in gerrit

Event Timeline

TK-999 created this task.Nov 3 2022, 2:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 3 2022, 2:48 PM
gerritbot added a comment.Nov 3 2022, 2:49 PM

Change 852904 had a related patch set uploaded (by TK-999; author: TK-999):

[mediawiki/core@master] ApiQueryRevisionsBase: Fix 'rvdiffto' parameter handling on PHP 8.0

https://gerrit.wikimedia.org/r/852904

gerritbot added a project: Patch-For-Review.Nov 3 2022, 2:49 PM
gerritbot added a comment.Nov 4 2022, 10:52 AM

Change 852904 merged by jenkins-bot:

[mediawiki/core@master] ApiQueryRevisionsBase: Fix 'rvdiffto' parameter handling on PHP 8.0

https://gerrit.wikimedia.org/r/852904

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.10; 2022-11-14).Nov 4 2022, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 4 2022, 11:30 AM
gerritbot added a comment.Nov 4 2022, 9:42 PM

Change 853364 had a related patch set uploaded (by Reedy; author: TK-999):

[mediawiki/core@REL1_39] ApiQueryRevisionsBase: Fix 'rvdiffto' parameter handling on PHP 8.0

https://gerrit.wikimedia.org/r/853364

gerritbot added a project: Patch-For-Review.Nov 4 2022, 9:42 PM
Reedy moved this task from Backlog to MediaWiki core on the PHP 8.0 support board.Nov 4 2022, 9:43 PM
gerritbot added a comment.Nov 4 2022, 10:01 PM

Change 853364 merged by jenkins-bot:

[mediawiki/core@REL1_39] ApiQueryRevisionsBase: Fix 'rvdiffto' parameter handling on PHP 8.0

https://gerrit.wikimedia.org/r/853364

ReleaseTaggerBot added a project: MW-1.39-notes.Nov 4 2022, 11:00 PM
Reedy removed a project: Patch-For-Review.Nov 10 2022, 12:40 AM
TK-999 closed this task as Resolved.Nov 18 2022, 1:51 PM
TK-999 claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL