When the fields svg, icon and wordmark are defined in $wgLogos, Timeless outputs invalid srcset descriptors
Open, Needs TriagePublicBUG REPORT
Actions

Assigned To

None

Authored By

	Mainframe98
	Nov 5 2022, 6:22 PM

Description

The cause is https://phabricator.wikimedia.org/source/Timeless/browse/master/includes/TimelessTemplate.php$1237, where only the keys 1x, width and height are unset. width and height aren't properties of $wgLogos either. The code should probably just fetch all it needs instead of unsetting things it doesn't need.

Mentioned Here: T277110: Deprecate Timeless' File logo parsing; obsoleted by correct use of $wgLogos['icon']

Duplicate of T277110?

Not exactly; Timeless shouldn't output invalid srcset descriptors in either case, but it should fix this bug regardless.