Chem formula is used (using PHP8.0)
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Dsavuljesku
	Nov 8 2022, 1:55 PM

Description

Following exception occurs when you try to save the page containing a math formula:

[a5e4963e2b67c0bb27dfbbaf] [no req]   TypeError from line 69 of /data/codebase/w/extensions/Math/src/MathMathMLCli.php: array_key_exists(): Argument #2 ($array) must be of type array, stdClass given</p><p>Backtrace:</p><p>#0 /data/codebase/w/extensions/Math/src/MathMathMLCli.php(36): MathMathMLCli-&gt;initializeFromCliResponse()<br />
#1 /data/codebase/w/extensions/Math/src/MathHooks.php(354): MathMathMLCli::batchEvaluate()<br />
#2 /data/codebase/w/includes/HookContainer/HookContainer.php(329): MathHooks::onParserAfterTidy()<br />
#3 /data/codebase/w/includes/HookContainer/HookContainer.php(132): MediaWiki\HookContainer\HookContainer-&gt;callLegacyHook()<br />
#4 /data/codebase/w/includes/HookContainer/HookRunner.php(2895): MediaWiki\HookContainer\HookContainer-&gt;run()<br />
#5 /data/codebase/w/includes/parser/Parser.php(1693): MediaWiki\HookContainer\HookRunner-&gt;onParserAfterTidy()<br />
#6 /data/codebase/w/includes/parser/Parser.php(654): Parser-&gt;internalParseHalfParsed()<br />
#7 /data/codebase/w/includes/cache/MessageCache.php(1318): Parser-&gt;parse()<br />

Traced it to https://github.com/wikimedia/mediawiki-extensions-Math/blob/master/src/MathMathMLCli.php#L73, where stdClass is passed instead of array.
Since this is not a new change, i can only assume that it threw a warning in <PHP8, but in 8.0 it fatals.

Reproduced on 1.35.8 (ab62807), but bug exists in all branches

Details

Subject	Repo	Branch	Lines +/-
Fix calling array function on stdClass	mediawiki/extensions/Math	REL1_35	+1 -1
Fix calling array function on stdClass	mediawiki/extensions/Math	REL1_39	+1 -1
Fix calling array function on stdClass	mediawiki/extensions/Math	REL1_37	+1 -1
Fix calling array function on stdClass	mediawiki/extensions/Math	REL1_38	+1 -1
Fix calling array function on stdClass	mediawiki/extensions/Math	master	+1 -1

Customize query in gerrit

Event Timeline

Dsavuljesku created this task.Nov 8 2022, 1:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 8 2022, 1:55 PM

Change 854519 had a related patch set uploaded (by ItSpiderman; author: ItSpiderman):

[mediawiki/extensions/Math@master] Fix calling array function on stdClass

https://gerrit.wikimedia.org/r/854519

gerritbot added a project: Patch-For-Review.Nov 8 2022, 1:59 PM

Yes, I did not test with PHP8. Probably, I was under the assumption that json_decode would use JSON_OBJECT_AS_ARRAY as default which is apparently not the case.

Change 854519 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Fix calling array function on stdClass

https://gerrit.wikimedia.org/r/854519

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.10; 2022-11-14).Nov 8 2022, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Nov 8 2022, 5:30 PM

Change 854084 had a related patch set uploaded (by Reedy; author: ItSpiderman):

[mediawiki/extensions/Math@REL1_39] Fix calling array function on stdClass

https://gerrit.wikimedia.org/r/854084

Change 854085 had a related patch set uploaded (by Reedy; author: ItSpiderman):

[mediawiki/extensions/Math@REL1_38] Fix calling array function on stdClass

https://gerrit.wikimedia.org/r/854085

Change 854586 had a related patch set uploaded (by Reedy; author: ItSpiderman):