language fallback indicators for language variants should not be shown in example on Special:NewLexeme
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

Problem:
When using an interface language that is a variant of another language like de-at then the language fallback indicators should not be shown. We are already hiding them in other places in the exact same situation.

Example:
https://www.wikidata.org/wiki/Special:NewLexeme?uselang=de-at

Screenshots/mockups:

Acceptance criteria:

language fallback indicators are hidden for language variants if the fallback is to the main language

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	NewLexeme: Hide language variant fallback indicators	mediawiki/extensions/WikibaseLexeme	master	+4 -1

Customize query in gerrit

Related Objects

Mentioned In: T345883: Remove HTML markup for language fallback indicators for fallback variants
T325084: Sitelink badges invisible on mobile Wikidata
Mentioned Here: T267502: Language fallback indicators sometimes still shown for variant fallbacks

Event Timeline

Lydia_Pintscher created this task.Nov 8 2022, 7:54 PM

Lydia_Pintscher moved this task from Incoming to Product Backlog on the [Archived]Wikidata Dev Team board.Nov 8 2022, 7:56 PM

Lydia_Pintscher triaged this task as Medium priority.Nov 8 2022, 7:59 PM

Lydia_Pintscher moved this task from incoming to features/bugs for next release (Special:NewLexeme) on the Wikidata Lexicographical data board.

Lydia_Pintscher moved this task from Backlog to Feedback from testing after release on the Special:NewLexeme revival board.Nov 8 2022, 8:01 PM

karapayneWMDE moved this task from Product Backlog to SEND TO OMEGA BOARD. Will land in the 'incoming' column and need to be moved to the correct location (former Unified DOT Backlog) on the [Archived]Wikidata Dev Team board.Nov 9 2022, 10:36 AM

See T267502 for a similar issue; the fix is hopefully as simple as pulling in the wikibase.common styles.

Lydia_Pintscher set the point value for this task to 3.Nov 15 2022, 10:21 AM

Lydia_Pintscher moved this task from SEND TO OMEGA BOARD. Will land in the 'incoming' column and need to be moved to the correct location (former Unified DOT Backlog) to Sprint-∞ on the [Archived]Wikidata Dev Team board.

Lydia_Pintscher edited projects, added [Archived]Wikidata Dev Team (Sprint-∞); removed [Archived]Wikidata Dev Team.

Lucas_Werkmeister_WMDE claimed this task.Nov 15 2022, 12:34 PM

Lucas_Werkmeister_WMDE moved this task from Parents/Waiting to Doing on the [Archived]Wikidata Dev Team (Sprint-∞) board.

Change 856961 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] NewLexeme: Hide language variant fallback indicators

https://gerrit.wikimedia.org/r/856961

gerritbot added a project: Patch-For-Review.Nov 15 2022, 12:49 PM

Lucas_Werkmeister_WMDE moved this task from Doing to Peer Review on the [Archived]Wikidata Dev Team (Sprint-∞) board.Nov 15 2022, 1:14 PM

Change 856961 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] NewLexeme: Hide language variant fallback indicators

https://gerrit.wikimedia.org/r/856961

Maintenance_bot removed a project: Patch-For-Review.Nov 15 2022, 3:30 PM

There’s no train next week (thanksgiving), so this will have to wait for quite a bit, I’m afraid. (Unless we think it’s worth backporting? Shouldn’t be hard, at least.)

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Nov 15 2022, 3:33 PM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.12; 2022-11-28).Nov 15 2022, 4:00 PM

Yeah. Let's not backport it and have it roll out with the next train.