Page MenuHomePhabricator

CI with new flake8 6.0.0 fails
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

flake8 --version
or
flake8 --bug-report

What happens?:

D:\>flake8 --bug-report
Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "C:\Python311\Scripts\flake8.exe\__main__.py", line 7, in <module>
  File "C:\Python311\Lib\site-packages\flake8\main\cli.py", line 23, in main
    app.run(argv)
  File "C:\Python311\Lib\site-packages\flake8\main\application.py", line 198, in run
    self._run(argv)
  File "C:\Python311\Lib\site-packages\flake8\main\application.py", line 186, in _run
    self.initialize(argv)
  File "C:\Python311\Lib\site-packages\flake8\main\application.py", line 165, in initialize
    self.plugins, self.options = parse_args(argv)
                                 ^^^^^^^^^^^^^^^^
  File "C:\Python311\Lib\site-packages\flake8\options\parse_args.py", line 51, in parse_args
    option_manager.register_plugins(plugins)
  File "C:\Python311\Lib\site-packages\flake8\options\manager.py", line 259, in register_plugins
    add_options(self)
  File "C:\Python311\Lib\site-packages\flake8_quotes\__init__.py", line 109, in add_options
    cls._register_opt(parser, '--quotes', action='store',
  File "C:\Python311\Lib\site-packages\flake8_quotes\__init__.py", line 99, in _register_opt
    parser.add_option(*args, **kwargs)
  File "C:\Python311\Lib\site-packages\flake8\options\manager.py", line 281, in add_option
    self._current_group.add_argument(*option_args, **option_kwargs)
  File "C:\Python311\Lib\argparse.py", line 1448, in add_argument
    raise ValueError('%r is not callable' % (type_func,))
ValueError: 'choice' is not callable

https://integration.wikimedia.org/ci/job/pywikibot-core-tox-docker/21373/console

Software version:

  • flake8 6.0.0
  • flake8-quotes 3.3.1

Other information:

Event Timeline

Xqt triaged this task as High priority.Nov 24 2022, 8:18 AM

Change 860479 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [tests] Use flake8-quotes with Python < 2.8.1 only

https://gerrit.wikimedia.org/r/860479

Xqt changed the task status from Open to In Progress.Nov 25 2022, 9:00 AM
Xqt claimed this task.

Change 860479 merged by jenkins-bot:

[pywikibot/core@master] [tests] Update flake tests on jenkins CI

https://gerrit.wikimedia.org/r/860479

Change 860845 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@tests] [tests] Update flake tests on jenkins CI

https://gerrit.wikimedia.org/r/860845

Change 860845 merged by jenkins-bot:

[pywikibot/core@tests] [tests] Update flake tests on jenkins CI

https://gerrit.wikimedia.org/r/860845

Change 877111 had a related patch set uploaded (by Xqt; author: Xqt):

[pywikibot/core@master] [flake8] Use flake8 > 3.3.2

https://gerrit.wikimedia.org/r/877111

Change 877111 merged by jenkins-bot:

[pywikibot/core@master] [flake8] Use flake8 > 3.3.2

https://gerrit.wikimedia.org/r/877111