Page MenuHomePhabricator

Fix some ES Lint warnings and turned off rules
Closed, ResolvedPublic

Description

Rules:

	"rules": {
		"max-len": "off",
		"no-jquery/no-global-selector": "off",
		"no-jquery/no-class-state": "off",
		"no-jquery/no-sizzle": "off",
		"no-jquery/variable-pattern": "off",
		"no-shadow": "warn",
		"no-unreachable-loop": "warn",
		"mediawiki/msg-doc": "warn",
		"no-var": "warn"
	}

All warnings except no-var:

13:30:03 /src/jsduck.external.js
13:30:03   13:0  warning  The type 'jqXHR' is undefined                jsdoc/no-undefined-types
13:30:03   32:0  warning  Invalid JSDoc tag name "mixins"              jsdoc/check-tag-names
13:30:03   39:0  warning  Invalid JSDoc tag name "alternateClassName"  jsdoc/check-tag-names
13:30:03 
13:30:03 /src/modules/ext.pageTriage.util/models/ext.pageTriage.article.js
13:30:03    78:18  warning  All possible message keys should be documented. See https://w.wiki/PRw for details  mediawiki/msg-doc
13:30:03   329:0   warning  Invalid JSDoc tag name "TODO"                                                       jsdoc/check-tag-names
13:30:03 
13:30:03 /src/modules/ext.pageTriage.views.list/ext.pageTriage.listView.js
13:30:03   155:24  warning  'stats' is already declared in the upper scope on line 13 column 3  no-shadow
13:30:03 
13:30:03 /src/modules/ext.pageTriage.views.toolbar/ToolView.js
13:30:03   174:30  warning  All possible message keys should be documented. See https://w.wiki/PRw for details  mediawiki/msg-doc
13:30:03 
13:30:03 /src/modules/ext.pageTriage.views.toolbar/articleInfo.js
13:30:03   126:24  warning  All possible message keys should be documented. See https://w.wiki/PRw for details  mediawiki/msg-doc
13:30:03   191:4   warning  All possible message keys should be documented. See https://w.wiki/PRw for details  mediawiki/msg-doc
13:30:03   193:4   warning  All possible message keys should be documented. See https://w.wiki/PRw for details  mediawiki/msg-doc
13:30:03 
13:30:03 /src/modules/ext.pageTriage.views.toolbar/delete.js
13:30:03     8:24  warning  'DateWrapper' is already declared in the upper scope on line 3 column 5             no-shadow
13:30:03   252:3   warning  Invalid loop. Its body allows only one iteration                                    no-unreachable-loop
13:30:03   462:4   warning  All possible message keys should be documented. See https://w.wiki/PRw for details  mediawiki/msg-doc
13:30:03   556:14  warning  'param' is already declared in the upper scope on line 510 column 13                no-shadow
13:30:03   786:2   warning  Missing JSDoc @return declaration                                                   jsdoc/require-returns
13:30:03   791:3   warning  Invalid loop. Its body allows only one iteration                                    no-unreachable-loop
13:30:03 
13:30:03 /src/modules/ext.pageTriage.views.toolbar/mark.js
13:30:03    31:30  warning  All possible message keys should be documented. See https://w.wiki/PRw for details  mediawiki/msg-doc
13:30:03   208:10  warning  All possible message keys should be documented. See https://w.wiki/PRw for details  mediawiki/msg-doc
13:30:03   242:48  warning  All possible message keys should be documented. See https://w.wiki/PRw for details  mediawiki/msg-doc
13:30:03   266:60  warning  All possible message keys should be documented. See https://w.wiki/PRw for details  mediawiki/msg-doc
13:30:03 
13:30:03 /src/modules/ext.pageTriage.views.toolbar/tags.js
13:30:03   334:4   warning  All possible message keys should be documented. See https://w.wiki/PRw for details  mediawiki/msg-doc
13:30:03   413:14  warning  'param' is already declared in the upper scope on line 367 column 13                no-shadow
13:30:03 
13:30:03 /src/tests/selenium/LocalSettingsSetup.cjs
13:30:03   45:1  warning  This line has a length of 102. Maximum allowed is 100  max-len
13:30:03 
13:30:03 ✖ 23 problems (0 errors, 23 warnings)

no-var warnings. maybe just mass change these to let, then check CI to see what broke, then refactor, then manually test.

08:35:56 /src/modules/ext.PageTriage.enqueue/ext.PageTriage.enqueue.js
08:35:56   2:2  error  Unexpected var, use let or const instead  no-var
08:35:56 
08:35:56 /src/modules/ext.pageTriage.defaultTagsOptions/ext.pageTriage.defaultDeletionTagsOptions.js
08:35:56   4:2  error  Unexpected var, use let or const instead  no-var
08:35:56 
08:35:56 /src/modules/ext.pageTriage.defaultTagsOptions/ext.pageTriage.defaultTagsOptions.js
08:35:56   4:2  error  Unexpected var, use let or const instead  no-var
08:35:56 
08:35:56 /src/modules/ext.pageTriage.toolbarStartup/ext.pageTriage.actionQueue.js
08:35:56    43:2  error  Unexpected var, use let or const instead  no-var
08:35:56    58:4  error  Unexpected var, use let or const instead  no-var
08:35:56    93:4  error  Unexpected var, use let or const instead  no-var
08:35:56   114:4  error  Unexpected var, use let or const instead  no-var
08:35:56 
08:35:56 /src/modules/ext.pageTriage.toolbarStartup/ext.pageTriage.toolbarStartup.js
08:35:56   2:2  error  Unexpected var, use let or const instead  no-var
08:35:56 
08:35:56 /src/modules/ext.pageTriage.util/ext.pageTriage.messageUtil.js
08:35:56   16:3  error  Unexpected var, use let or const instead  no-var
08:35:56 
08:35:56 /src/modules/ext.pageTriage.util/models/ext.pageTriage.article.js
08:35:56    24:4  error    Unexpected var, use let or const instead  no-var
08:35:56    42:4  error    Unexpected var, use let or const instead  no-var
08:35:56    56:5  error    Unexpected var, use let or const instead  no-var
08:35:56    70:5  error    Unexpected var, use let or const instead  no-var
08:35:56    81:5  error    Unexpected var, use let or const instead  no-var
08:35:56   115:5  error    Unexpected var, use let or const instead  no-var
08:35:56   118:5  error    Unexpected var, use let or const instead  no-var
08:35:56   196:4  error    Unexpected var, use let or const instead  no-var
08:35:56   204:4  error    Unexpected var, use let or const instead  no-var
08:35:56   215:4  error    Unexpected var, use let or const instead  no-var
08:35:56   291:4  error    Unexpected var, use let or const instead  no-var
08:35:56   295:4  error    Unexpected var, use let or const instead  no-var
08:35:56   330:0  warning  Invalid JSDoc tag name "TODO"             jsdoc/check-tag-names
08:35:56   335:4  error    Unexpected var, use let or const instead  no-var
08:35:56   358:4  error    Unexpected var, use let or const instead  no-var
08:35:56   367:4  error    Unexpected var, use let or const instead  no-var
08:35:56   421:4  error    Unexpected var, use let or const instead  no-var
08:35:56 
08:35:56 /src/modules/ext.pageTriage.util/models/ext.pageTriage.stats.js
08:35:56   32:4  error  Unexpected var, use let or const instead  no-var
08:35:56   42:4  error  Unexpected var, use let or const instead  no-var
08:35:56   44:4  error  Unexpected var, use let or const instead  no-var
08:35:56   57:4  error  Unexpected var, use let or const instead  no-var
08:35:56 
08:35:56 /src/modules/ext.pageTriage.views.list/ext.pageTriage.listControlNav.js
08:35:56    12:4  error  Unexpected var, use let or const instead  no-var
08:35:56    53:4  error  Unexpected var, use let or const instead  no-var
08:35:56    64:5  error  Unexpected var, use let or const instead  no-var
08:35:56    72:4  error  Unexpected var, use let or const instead  no-var
08:35:56    88:5  error  Unexpected var, use let or const instead  no-var
08:35:56   143:5  error  Unexpected var, use let or const instead  no-var
08:35:56   209:4  error  Unexpected var, use let or const instead  no-var
08:35:56   230:4  error  Unexpected var, use let or const instead  no-var
08:35:56   253:4  error  Unexpected var, use let or const instead  no-var
08:35:56   294:4  error  Unexpected var, use let or const instead  no-var
08:35:56   297:4  error  Unexpected var, use let or const instead  no-var
08:35:56   313:4  error  Unexpected var, use let or const instead  no-var
08:35:56   346:4  error  Unexpected var, use let or const instead  no-var
08:35:56   387:4  error  Unexpected var, use let or const instead  no-var
08:35:56   464:4  error  Unexpected var, use let or const instead  no-var
08:35:56   480:4  error  Unexpected var, use let or const instead  no-var
08:35:56   481:4  error  Unexpected var, use let or const instead  no-var
08:35:56   485:5  error  Unexpected var, use let or const instead  no-var
08:35:56   494:5  error  Unexpected var, use let or const instead  no-var
08:35:56   534:4  error  Unexpected var, use let or const instead  no-var
08:35:56   547:4  error  Unexpected var, use let or const instead  no-var
08:35:56   575:6  error  Unexpected var, use let or const instead  no-var
08:35:56   600:4  error  Unexpected var, use let or const instead  no-var
08:35:56   632:4  error  Unexpected var, use let or const instead  no-var
08:35:56   645:4  error  Unexpected var, use let or const instead  no-var
08:35:56   681:4  error  Unexpected var, use let or const instead  no-var
08:35:56   683:4  error  Unexpected var, use let or const instead  no-var
08:35:56   686:5  error  Unexpected var, use let or const instead  no-var
08:35:56   693:4  error  Unexpected var, use let or const instead  no-var
08:35:56   696:5  error  Unexpected var, use let or const instead  no-var
08:35:56   736:4  error  Unexpected var, use let or const instead  no-var
08:35:56   752:4  error  Unexpected var, use let or const instead  no-var
08:35:56   759:4  error  Unexpected var, use let or const instead  no-var
08:35:56 
08:35:56 /src/modules/ext.pageTriage.views.list/ext.pageTriage.listItem.js
08:35:56   16:4  error  Unexpected var, use let or const instead  no-var
08:35:56 
08:35:56 /src/modules/ext.pageTriage.views.list/ext.pageTriage.listStatsNav.js
08:35:56    9:4  error  Unexpected var, use let or const instead  no-var
08:35:56   28:4  error  Unexpected var, use let or const instead  no-var
08:35:56   53:4  error  Unexpected var, use let or const instead  no-var
08:35:56   78:4  error  Unexpected var, use let or const instead  no-var
08:35:56   96:4  error  Unexpected var, use let or const instead  no-var
08:35:56 
08:35:56 /src/modules/ext.pageTriage.views.list/ext.pageTriage.listView.js
08:35:56     5:2   error    Unexpected var, use let or const instead                            no-var
08:35:56    39:5   error    Unexpected var, use let or const instead                            no-var
08:35:56    48:4   error    Unexpected var, use let or const instead                            no-var
08:35:56    69:4   error    Unexpected var, use let or const instead                            no-var
08:35:56    79:4   error    Unexpected var, use let or const instead                            no-var
08:35:56    88:4   error    Unexpected var, use let or const instead                            no-var
08:35:56   112:4   error    Unexpected var, use let or const instead                            no-var
08:35:56   128:4   error    Unexpected var, use let or const instead                            no-var
08:35:56   137:4   error    Unexpected var, use let or const instead                            no-var
08:35:56   155:24  warning  'stats' is already declared in the upper scope on line 13 column 3  no-shadow
08:35:56   156:4   error    Unexpected var, use let or const instead                            no-var
08:35:56   176:4   error    Unexpected var, use let or const instead                            no-var
08:35:56   177:4   error    Unexpected var, use let or const instead                            no-var
08:35:56 
08:35:56 /src/modules/ext.pageTriage.views.toolbar/ToolView.js
08:35:56    81:3  error  Unexpected var, use let or const instead  no-var
08:35:56   123:3  error  Unexpected var, use let or const instead  no-var
08:35:56   141:3  error  Unexpected var, use let or const instead  no-var
08:35:56   158:3  error  Unexpected var, use let or const instead  no-var
08:35:56   226:3  error  Unexpected var, use let or const instead  no-var
08:35:56   239:3  error  Unexpected var, use let or const instead  no-var
08:35:56   260:3  error  Unexpected var, use let or const instead  no-var
08:35:56 
08:35:56 /src/modules/ext.pageTriage.views.toolbar/ToolbarView.js
08:35:56     3:1  error  Unexpected var, use let or const instead  no-var
08:35:56    29:3  error  Unexpected var, use let or const instead  no-var
08:35:56    33:3  error  Unexpected var, use let or const instead  no-var
08:35:56    38:4  error  Unexpected var, use let or const instead  no-var
08:35:56    44:4  error  Unexpected var, use let or const instead  no-var
08:35:56    50:4  error  Unexpected var, use let or const instead  no-var
08:35:56    56:4  error  Unexpected var, use let or const instead  no-var
08:35:56    62:4  error  Unexpected var, use let or const instead  no-var
08:35:56    67:3  error  Unexpected var, use let or const instead  no-var
08:35:56    78:3  error  Unexpected var, use let or const instead  no-var
08:35:56   108:3  error  Unexpected var, use let or const instead  no-var
08:35:56   128:5  error  Unexpected var, use let or const instead  no-var
08:35:56   182:3  error  Unexpected var, use let or const instead  no-var
08:35:56   213:3  error  Unexpected var, use let or const instead  no-var
08:35:56   248:3  error  Unexpected var, use let or const instead  no-var
08:35:56 
08:35:56 /src/modules/ext.pageTriage.views.toolbar/articleInfo.js
08:35:56     3:1  error  Unexpected var, use let or const instead  no-var
08:35:56    12:3  error  Unexpected var, use let or const instead  no-var
08:35:56    81:3  error  Unexpected var, use let or const instead  no-var
08:35:56    83:4  error  Unexpected var, use let or const instead  no-var
08:35:56    90:4  error  Unexpected var, use let or const instead  no-var
08:35:56   101:3  error  Unexpected var, use let or const instead  no-var
08:35:56   117:4  error  Unexpected var, use let or const instead  no-var
08:35:56   124:4  error  Unexpected var, use let or const instead  no-var
08:35:56   129:4  error  Unexpected var, use let or const instead  no-var
08:35:56   157:3  error  Unexpected var, use let or const instead  no-var
08:35:56   165:3  error  Unexpected var, use let or const instead  no-var
08:35:56   173:3  error  Unexpected var, use let or const instead  no-var
08:35:56   224:3  error  Unexpected var, use let or const instead  no-var
08:35:56 
08:35:56 /src/modules/ext.pageTriage.views.toolbar/delete.js
08:35:56      3:1   error    Unexpected var, use let or const instead                                 no-var
08:35:56      8:24  warning  'DateWrapper' is already declared in the upper scope on line 3 column 5  no-shadow
08:35:56     47:4   error    Unexpected var, use let or const instead                                 no-var
08:35:56     58:4   error    Unexpected var, use let or const instead                                 no-var
08:35:56     77:4   error    Unexpected var, use let or const instead                                 no-var
08:35:56    100:4   error    Unexpected var, use let or const instead                                 no-var
08:35:56    119:4   error    Unexpected var, use let or const instead                                 no-var
08:35:56    197:4   error    Unexpected var, use let or const instead                                 no-var
08:35:56    214:3   error    Unexpected var, use let or const instead                                 no-var
08:35:56    231:4   error    Unexpected var, use let or const instead                                 no-var
08:35:56    252:3   warning  Invalid loop. Its body allows only one iteration                         no-unreachable-loop
08:35:56    259:3   error    Unexpected var, use let or const instead                                 no-var
08:35:56    261:9   error    Unexpected var, use let or const instead                                 no-var
08:35:56    280:3   error    Unexpected var, use let or const instead                                 no-var
08:35:56    310:3   error    Unexpected var, use let or const instead                                 no-var
08:35:56    322:4   error    Unexpected var, use let or const instead                                 no-var
08:35:56    354:5   error    Unexpected var, use let or const instead                                 no-var
08:35:56    430:3   error    Unexpected var, use let or const instead                                 no-var
08:35:56    437:3   error    Unexpected var, use let or const instead                                 no-var
08:35:56    440:9   error    Unexpected var, use let or const instead                                 no-var
08:35:56    454:3   error    Unexpected var, use let or const instead                                 no-var
08:35:56    467:3   error    Unexpected var, use let or const instead                                 no-var
08:35:56    488:9   error    Unexpected var, use let or const instead                                 no-var
08:35:56    501:3   error    Unexpected var, use let or const instead                                 no-var
08:35:56    511:9   error    Unexpected var, use let or const instead                                 no-var
08:35:56    512:4   error    Unexpected var, use let or const instead                                 no-var
08:35:56    557:10  error    Unexpected var, use let or const instead                                 no-var
08:35:56    557:14  warning  'param' is already declared in the upper scope on line 511 column 13     no-shadow
08:35:56    599:3   error    Unexpected var, use let or const instead                                 no-var
08:35:56    600:9   error    Unexpected var, use let or const instead                                 no-var
08:35:56    618:3   error    Unexpected var, use let or const instead                                 no-var
08:35:56    619:9   error    Unexpected var, use let or const instead                                 no-var
08:35:56    655:3   error    Unexpected var, use let or const instead                                 no-var
08:35:56    661:10  error    Unexpected var, use let or const instead                                 no-var
08:35:56    686:3   error    Unexpected var, use let or const instead                                 no-var
08:35:56    712:5   error    Unexpected var, use let or const instead                                 no-var
08:35:56    716:5   error    Unexpected var, use let or const instead                                 no-var
08:35:56    718:12  error    Unexpected var, use let or const instead                                 no-var
08:35:56    719:7   error    Unexpected var, use let or const instead                                 no-var
08:35:56    765:3   error    Unexpected var, use let or const instead                                 no-var
08:35:56    766:3   error    Unexpected var, use let or const instead                                 no-var
08:35:56    767:3   error    Unexpected var, use let or const instead                                 no-var
08:35:56    774:3   error    Unexpected var, use let or const instead                                 no-var
08:35:56    776:3   error    Unexpected var, use let or const instead                                 no-var
08:35:56    794:3   error    Unexpected var, use let or const instead                                 no-var
08:35:56    795:3   warning  Invalid loop. Its body allows only one iteration                         no-unreachable-loop
08:35:56    802:4   error    Unexpected var, use let or const instead                                 no-var
08:35:56    803:4   error    Unexpected var, use let or const instead                                 no-var
08:35:56    804:4   error    Unexpected var, use let or const instead                                 no-var
08:35:56    805:4   error    Unexpected var, use let or const instead                                 no-var
08:35:56    830:3   error    Unexpected var, use let or const instead                                 no-var
08:35:56    845:4   error    Unexpected var, use let or const instead                                 no-var
08:35:56    846:4   error    Unexpected var, use let or const instead                                 no-var
08:35:56    847:4   error    Unexpected var, use let or const instead                                 no-var
08:35:56    922:3   error    Unexpected var, use let or const instead                                 no-var
08:35:56    929:3   error    Unexpected var, use let or const instead                                 no-var
08:35:56    942:3   error    Unexpected var, use let or const instead                                 no-var
08:35:56    943:3   error    Unexpected var, use let or const instead                                 no-var
08:35:56    945:3   error    Unexpected var, use let or const instead                                 no-var
08:35:56    947:3   error    Unexpected var, use let or const instead                                 no-var
08:35:56    950:4   error    Unexpected var, use let or const instead                                 no-var
08:35:56    977:3   error    Unexpected var, use let or const instead                                 no-var
08:35:56    987:12  error    Unexpected var, use let or const instead                                 no-var
08:35:56   1020:3   error    Unexpected var, use let or const instead                                 no-var
08:35:56   1065:3   error    Unexpected var, use let or const instead                                 no-var
08:35:56   1096:3   error    Unexpected var, use let or const instead                                 no-var
08:35:56   1144:3   error    Unexpected var, use let or const instead                                 no-var
08:35:56   1160:5   error    Unexpected var, use let or const instead                                 no-var
08:35:56 
08:35:56 /src/modules/ext.pageTriage.views.toolbar/mark.js
08:35:56     3:1  error  Unexpected var, use let or const instead  no-var
08:35:56    50:3  error  Unexpected var, use let or const instead  no-var
08:35:56    61:5  error  Unexpected var, use let or const instead  no-var
08:35:56    86:3  error  Unexpected var, use let or const instead  no-var
08:35:56   102:3  error  Unexpected var, use let or const instead  no-var
08:35:56   150:3  error  Unexpected var, use let or const instead  no-var
08:35:56   163:4  error  Unexpected var, use let or const instead  no-var
08:35:56   183:3  error  Unexpected var, use let or const instead  no-var
08:35:56   218:3  error  Unexpected var, use let or const instead  no-var
08:35:56   253:5  error  Unexpected var, use let or const instead  no-var
08:35:56 
08:35:56 /src/modules/ext.pageTriage.views.toolbar/minimize.js
08:35:56   3:1  error  Unexpected var, use let or const instead  no-var
08:35:56 
08:35:56 /src/modules/ext.pageTriage.views.toolbar/next.js
08:35:56    3:1  error  Unexpected var, use let or const instead  no-var
08:35:56   31:3  error  Unexpected var, use let or const instead  no-var
08:35:56   42:5  error  Unexpected var, use let or const instead  no-var
08:35:56 
08:35:56 /src/modules/ext.pageTriage.views.toolbar/tags.js
08:35:56     3:1   error    Unexpected var, use let or const instead                              no-var
08:35:56    34:3   error    Unexpected var, use let or const instead                              no-var
08:35:56    36:9   error    Unexpected var, use let or const instead                              no-var
08:35:56    40:10  error    Unexpected var, use let or const instead                              no-var
08:35:56    41:5   error    Unexpected var, use let or const instead                              no-var
08:35:56    62:3   error    Unexpected var, use let or const instead                              no-var
08:35:56    63:9   error    Unexpected var, use let or const instead                              no-var
08:35:56    64:4   error    Unexpected var, use let or const instead                              no-var
08:35:56    74:9   error    Unexpected var, use let or const instead                              no-var
08:35:56    83:3   error    Unexpected var, use let or const instead                              no-var
08:35:56   118:4   error    Unexpected var, use let or const instead                              no-var
08:35:56   152:3   error    Unexpected var, use let or const instead                              no-var
08:35:56   162:3   error    Unexpected var, use let or const instead                              no-var
08:35:56   164:9   error    Unexpected var, use let or const instead                              no-var
08:35:56   166:4   error    Unexpected var, use let or const instead                              no-var
08:35:56   174:4   error    Unexpected var, use let or const instead                              no-var
08:35:56   184:4   error    Unexpected var, use let or const instead                              no-var
08:35:56   205:5   error    Unexpected var, use let or const instead                              no-var
08:35:56   273:3   error    Unexpected var, use let or const instead                              no-var
08:35:56   305:3   error    Unexpected var, use let or const instead                              no-var
08:35:56   311:3   error    Unexpected var, use let or const instead                              no-var
08:35:56   314:9   error    Unexpected var, use let or const instead                              no-var
08:35:56   329:3   error    Unexpected var, use let or const instead                              no-var
08:35:56   339:3   error    Unexpected var, use let or const instead                              no-var
08:35:56   363:3   error    Unexpected var, use let or const instead                              no-var
08:35:56   368:9   error    Unexpected var, use let or const instead                              no-var
08:35:56   369:4   error    Unexpected var, use let or const instead                              no-var
08:35:56   373:3   error    Unexpected var, use let or const instead                              no-var
08:35:56   391:3   error    Unexpected var, use let or const instead                              no-var
08:35:56   406:4   error    Unexpected var, use let or const instead                              no-var
08:35:56   414:10  error    Unexpected var, use let or const instead                              no-var
08:35:56   414:14  warning  'param' is already declared in the upper scope on line 368 column 13  no-shadow
08:35:56   448:3   error    Unexpected var, use let or const instead                              no-var
08:35:56   449:9   error    Unexpected var, use let or const instead                              no-var
08:35:56   479:3   error    Unexpected var, use let or const instead                              no-var
08:35:56   480:9   error    Unexpected var, use let or const instead                              no-var
08:35:56   501:3   error    Unexpected var, use let or const instead                              no-var
08:35:56   513:9   error    Unexpected var, use let or const instead                              no-var
08:35:56   518:5   error    Unexpected var, use let or const instead                              no-var
08:35:56   521:11  error    Unexpected var, use let or const instead                              no-var
08:35:56   632:3   error    Unexpected var, use let or const instead                              no-var
08:35:56   633:3   error    Unexpected var, use let or const instead                              no-var
08:35:56   634:3   error    Unexpected var, use let or const instead                              no-var
08:35:56   635:3   error    Unexpected var, use let or const instead                              no-var
08:35:56   642:3   error    Unexpected var, use let or const instead                              no-var
08:35:56   645:3   error    Unexpected var, use let or const instead                              no-var
08:35:56   657:3   error    Unexpected var, use let or const instead                              no-var
08:35:56   687:3   error    Unexpected var, use let or const instead                              no-var
08:35:56   691:3   error    Unexpected var, use let or const instead                              no-var
08:35:56   692:3   error    Unexpected var, use let or const instead                              no-var
08:35:56   702:3   error    Unexpected var, use let or const instead                              no-var
08:35:56   721:3   error    Unexpected var, use let or const instead                              no-var
08:35:56   759:11  error    Unexpected var, use let or const instead                              no-var
08:35:56 
08:35:56 /src/modules/ext.pageTriage.views.toolbar/wikilove.js
08:35:56     3:1  error  Unexpected var, use let or const instead  no-var
08:35:56    12:3  error  Unexpected var, use let or const instead  no-var
08:35:56    13:9  error  Unexpected var, use let or const instead  no-var
08:35:56    20:3  error  Unexpected var, use let or const instead  no-var
08:35:56    28:3  error  Unexpected var, use let or const instead  no-var
08:35:56    31:3  error  Unexpected var, use let or const instead  no-var
08:35:56    37:3  error  Unexpected var, use let or const instead  no-var
08:35:56    38:9  error  Unexpected var, use let or const instead  no-var
08:35:56    39:4  error  Unexpected var, use let or const instead  no-var
08:35:56    44:3  error  Unexpected var, use let or const instead  no-var
08:35:56    46:3  error  Unexpected var, use let or const instead  no-var
08:35:56    67:3  error  Unexpected var, use let or const instead  no-var
08:35:56    73:6  error  Unexpected var, use let or const instead  no-var
08:35:56    74:6  error  Unexpected var, use let or const instead  no-var
08:35:56   105:3  error  Unexpected var, use let or const instead  no-var
08:35:56   110:5  error  Unexpected var, use let or const instead  no-var
08:35:56 
08:35:56 /src/modules/jquery.tipoff/jquery.tipoff.js
08:35:56   8:3  error  Unexpected var, use let or const instead  no-var
08:35:56 
08:35:56 /src/tests/qunit/test_ext.pageTriage.actionQueue.js
08:35:56     5:3  error  Unexpected var, use let or const instead  no-var
08:35:56    27:4  error  Unexpected var, use let or const instead  no-var
08:35:56    37:4  error  Unexpected var, use let or const instead  no-var
08:35:56    89:3  error  Unexpected var, use let or const instead  no-var
08:35:56   111:4  error  Unexpected var, use let or const instead  no-var
08:35:56   131:4  error  Unexpected var, use let or const instead  no-var
08:35:56   166:3  error  Unexpected var, use let or const instead  no-var
08:35:56   188:4  error  Unexpected var, use let or const instead  no-var
08:35:56   208:4  error  Unexpected var, use let or const instead  no-var
08:35:56 
08:35:56 ✖ 278 problems (271 errors, 7 warnings)
08:35:56   271 errors and 0 warnings potentially fixable with the `--fix` option.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 863256 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/PageTriage@master] eslint: Fail on warnings

https://gerrit.wikimedia.org/r/863256

Change 865596 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/PageTriage@master] cleanup: Apply eslint --fix to modules for ES6

https://gerrit.wikimedia.org/r/865596

Change 865597 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/PageTriage@master] cleanup: Move jquery.tipoff to external directory

https://gerrit.wikimedia.org/r/865597

Change 865599 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/PageTriage@master] [WIP] Fix ESLint errors/warnings from ES6 conversion

https://gerrit.wikimedia.org/r/865599

Change 865599 abandoned by Kosta Harlan:

[mediawiki/extensions/PageTriage@master] [WIP] Fix ESLint errors/warnings from ES6 conversion

Reason:

squashed

https://gerrit.wikimedia.org/r/865599

Change 865597 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] cleanup: Move jquery.tipoff to external directory

https://gerrit.wikimedia.org/r/865597

Change 865596 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] cleanup: Fix ES6 warnings/errors

https://gerrit.wikimedia.org/r/865596

Change 863256 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] eslint: Fail on warnings

https://gerrit.wikimedia.org/r/863256

Novem_Linguae assigned this task to kostajh.
Novem_Linguae moved this task from Priority technical debt to Done on the PageTriage board.