Page MenuHomePhabricator
Create Task
Maniphest T325532

Require trailing commas in multiline arrays in Wikibase codebases
Open, Needs TriagePublic
Actions

Description

mediawiki-codesniffer now supports enforcing trailing commas in arrays (T222042); according to an internal poll (Mattermost link), we want to enable this in Wikibase PHP code (which I take to mean not only Wikibase.git, but also WikibaseLexeme etc.).

Details

SubjectRepoBranchLines +/-
Enforce trailing commas in multi-line arraysmediawiki/extensions/WikibaseQualityConstraintsmaster+426 -419
Enable MediaWiki.Arrays.TrailingComma sniffmediawiki/extensions/WikibaseLexememaster+790 -783
Update mediawiki/mediawiki-codesniffer to 41.0mediawiki/extensions/WikibaseLexememaster+7 -7
Enable MediaWiki.Arrays.TrailingComma sniffmediawiki/extensions/Wikibasemaster+4 K -4 K
Update mediawiki/mediawiki-codesniffer to 40.0mediawiki/extensions/Wikibasemaster+3 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Dec 19 2022, 10:38 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 19 2022, 10:39 AM
Lucas_Werkmeister_WMDE added a subtask: T222042: Add sniff to require trailing commas in multiline arrays.Dec 19 2022, 10:39 AM
Lucas_Werkmeister_WMDE mentioned this in T222042: Add sniff to require trailing commas in multiline arrays.
gerritbot added a comment.Dec 19 2022, 10:43 AM

Change 869184 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Update mediawiki/mediawiki-codesniffer to 40.0

https://gerrit.wikimedia.org/r/869184

gerritbot added a project: Patch-For-Review.Dec 19 2022, 10:43 AM

Change 869185 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Enable MediaWiki.Arrays.TrailingComma sniff

https://gerrit.wikimedia.org/r/869185

gerritbot added a comment.Dec 19 2022, 8:17 PM

Change 869184 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Update mediawiki/mediawiki-codesniffer to 40.0

https://gerrit.wikimedia.org/r/869184

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Dec 19 2022, 9:01 PM
gerritbot added a comment.Jan 13 2023, 6:11 PM

Change 869185 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Enable MediaWiki.Arrays.TrailingComma sniff

https://gerrit.wikimedia.org/r/869185

Maintenance_bot removed a project: Patch-For-Review.Jan 13 2023, 6:30 PM
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.19; 2023-01-16); removed MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Jan 13 2023, 7:00 PM
gerritbot added a comment.Mar 3 2023, 11:37 AM

Change 894020 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Update mediawiki/mediawiki-codesniffer to 41.0

https://gerrit.wikimedia.org/r/894020

gerritbot added a project: Patch-For-Review.Mar 3 2023, 11:37 AM

Change 894021 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Enable MediaWiki.Arrays.TrailingComma sniff

https://gerrit.wikimedia.org/r/894021

gerritbot added a comment.Mar 21 2023, 9:39 AM

Change 894020 abandoned by Lucas Werkmeister (WMDE):

[mediawiki/extensions/WikibaseLexeme@master] Update mediawiki/mediawiki-codesniffer to 41.0

Reason:

done in I8abb0d8f79

https://gerrit.wikimedia.org/r/894020

gerritbot added a comment.Apr 19 2023, 3:03 PM

Change 894021 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Enable MediaWiki.Arrays.TrailingComma sniff

https://gerrit.wikimedia.org/r/894021

Maintenance_bot removed a project: Patch-For-Review.Apr 19 2023, 3:11 PM
gerritbot added a comment.Apr 19 2023, 3:22 PM

Change 910031 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseQualityConstraints@master] Enforce trailing commas in multi-line arrays

https://gerrit.wikimedia.org/r/910031

gerritbot added a project: Patch-For-Review.Apr 19 2023, 3:22 PM
gerritbot added a comment.Apr 19 2023, 3:42 PM

Change 910031 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Enforce trailing commas in multi-line arrays

https://gerrit.wikimedia.org/r/910031

Maintenance_bot removed a project: Patch-For-Review.Apr 19 2023, 4:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL