Page MenuHomePhabricator
Create Task
Maniphest T325680

Hard-deprecate User::getGroupPermissions/getGroupsWithPermission/groupHasPermission and PermissionManager::getGroupPermissions/getGroupsWithPermission/groupHasPermission function (and remove in 1.41)
Closed, ResolvedPublic
Actions

Description

Functions

  • User::getGroupPermissions
  • User::getGroupsWithPermission
  • User::groupHasPermission
  • PermissionManager::getGroupPermissions
  • PermissionManager::getGroupsWithPermission
  • PermissionManager::groupHasPermission

are deprecated and should be hard-deprecated and removed.

CodeSearch - https://codesearch.wmcloud.org/search/?q=%5Cb(getGroupPermissions%7CgetGroupsWithPermission%7CgroupHasPermission)%5Cb&i=nope&files=&excludeFiles=&repos=

Details

SubjectRepoBranchLines +/-
Drop User and PermissionManager's group permission methods, deprecated since 1.34/1.36mediawiki/coremaster+6 -236
Hard-deprecate User/PermissionManager group permissions lookup functionsmediawiki/coremaster+27 -10
Replace deprecated PermissionManager::getGroupPermissions/WithPermissionmediawiki/coremaster+3 -3
Customize query in gerrit

Related Objects

Event Timeline

Umherirrender created this task.Dec 20 2022, 8:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 20 2022, 8:42 PM
Umherirrender mentioned this in T277511: Drop hard-deprecated User methods once they've been hard-deprecated in at least once release.Dec 20 2022, 8:48 PM
Umherirrender moved this task from Untriaged to 2021 | MW 1.36 / 1.37 on the Technical-Debt (Deprecation process) board.
gerritbot added a comment.Dec 20 2022, 8:55 PM

Change 869851 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Replace deprecated PermissionManager::getGroupPermissions/WithPermission

https://gerrit.wikimedia.org/r/869851

gerritbot added a project: Patch-For-Review.Dec 20 2022, 8:55 PM
Umherirrender moved this task from Backlog to Other on the MediaWiki-User-management board.Dec 20 2022, 9:45 PM
gerritbot added a comment.Dec 21 2022, 6:08 AM

Change 869851 merged by jenkins-bot:

[mediawiki/core@master] Replace deprecated PermissionManager::getGroupPermissions/WithPermission

https://gerrit.wikimedia.org/r/869851

Maintenance_bot removed a project: Patch-For-Review.Dec 21 2022, 6:30 AM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.17; 2023-01-02).Dec 21 2022, 7:01 AM
gerritbot added a comment.Dec 21 2022, 5:44 PM

Change 870662 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Hard-deprecate User/PermissionManager group permissions lookup functions

https://gerrit.wikimedia.org/r/870662

gerritbot added a project: Patch-For-Review.Dec 21 2022, 5:44 PM
gerritbot added a comment.Dec 23 2022, 1:55 AM

Change 870662 merged by jenkins-bot:

[mediawiki/core@master] Hard-deprecate User/PermissionManager group permissions lookup functions

https://gerrit.wikimedia.org/r/870662

Maintenance_bot removed a project: Patch-For-Review.Dec 23 2022, 2:30 AM
Umherirrender renamed this task from Hard-deprecate User::getGroupPermissions/getGroupsWithPermission/groupHasPermission and PermissionManager::getGroupPermissions/getGroupsWithPermission/groupHasPermission function (and remove a release later) to Hard-deprecate User::getGroupPermissions/getGroupsWithPermission/groupHasPermission and PermissionManager::getGroupPermissions/getGroupsWithPermission/groupHasPermission function (and remove in 1.41).Dec 23 2022, 2:21 PM
Umherirrender changed the task status from Open to Stalled.
Umherirrender changed the task status from Stalled to Open.Mar 14 2023, 9:35 PM
Jdforrester-WMF added a project: MW-1.41-release.Sep 21 2023, 6:53 PM
Jdforrester-WMF moved this task from Blocker to To deprecate or remove on the MW-1.41-release board.
gerritbot added a comment.Sep 21 2023, 7:02 PM

Change 959844 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Drop User and PermissionManager's group permission methods, deprecated since 1.34/1.36

https://gerrit.wikimedia.org/r/959844

gerritbot added a project: Patch-For-Review.Sep 21 2023, 7:02 PM
gerritbot added a comment.Sep 22 2023, 6:32 PM

Change 959844 merged by jenkins-bot:

[mediawiki/core@master] Drop User and PermissionManager's group permission methods, deprecated since 1.34/1.36

https://gerrit.wikimedia.org/r/959844

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.28; 2023-09-26).Sep 22 2023, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 22 2023, 7:10 PM
Jdforrester-WMF closed this task as Resolved.Sep 25 2023, 5:23 PM
Jdforrester-WMF claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL