Maniphest T325684

Hard-deprecate User::newFromName/newFromId/newFromActorId/newFromIdentity/newFromAnyId/newFromConfirmationCode (and remove a release later)
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Umherirrender
	Dec 20 2022, 9:23 PM

Tags

Referenced Files

None

Subscribers

Description

The following functions are deprecated and should be replaced

User::newFromName
User::newFromId
User::newFromActorId
User::newFromIdentity
User::newFromAnyId
User::newFromConfirmationCode

After that the function should be hard-deprecated and removed

Sometimes it could be better to just replace with MediaWiki\User\UserIdentity when a fully User object is not needed (via UserIdentityLookup)

CodeSearch: https://codesearch.wmcloud.org/deployed/?q=%5CbUser%5Cs*%3A%3A%5Cs*(newFromName%7CnewFromId%7CnewFromActorId%7CnewFromIdentity%7CnewFromAnyId%7CnewFromConfirmationCode)%5Cb&i=nope&files=&excludeFiles=&repos=

Related Objects

Mentioned In: T326646: PHP Deprecated: Use of WikiPage::newFromID was deprecated in MediaWiki 1.36. [Called from Article::getOldIDFromRequest]
T277511: Drop hard-deprecated User methods once they've been hard-deprecated in at least once release

Event Timeline

Umherirrender created this task.Dec 20 2022, 9:23 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 20 2022, 9:23 PM

Umherirrender moved this task from Untriaged to 2021 | MW 1.36 / 1.37 on the Technical-Debt (Deprecation process) board.Dec 20 2022, 9:25 PM

Umherirrender mentioned this in T277511: Drop hard-deprecated User methods once they've been hard-deprecated in at least once release.Dec 20 2022, 9:35 PM

Umherirrender moved this task from Backlog to Other on the MediaWiki-User-management board.Dec 20 2022, 9:45 PM

Umherirrender mentioned this in T326646: PHP Deprecated: Use of WikiPage::newFromID was deprecated in MediaWiki 1.36. [Called from Article::getOldIDFromRequest].Jan 10 2023, 4:51 PM