Page MenuHomePhabricator
Create Task
Maniphest T325684

Hard-deprecate User::newFromName/newFromId/newFromActorId/newFromIdentity/newFromAnyId/newFromConfirmationCode (and remove a release later)
Open, Needs TriagePublic
Actions

Description

The following functions are deprecated and should be replaced

  • User::newFromName
  • User::newFromId
  • User::newFromActorId
  • User::newFromIdentity
  • User::newFromAnyId
  • User::newFromConfirmationCode

After that the function should be hard-deprecated and removed

Sometimes it could be better to just replace with MediaWiki\User\UserIdentity when a fully User object is not needed (via UserIdentityLookup)

CodeSearch: https://codesearch.wmcloud.org/deployed/?q=%5CbUser%5Cs*%3A%3A%5Cs*(newFromName%7CnewFromId%7CnewFromActorId%7CnewFromIdentity%7CnewFromAnyId%7CnewFromConfirmationCode)%5Cb&i=nope&files=&excludeFiles=&repos=

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Remove Deprecated User Methods with UserFactory MethodsWandji collinsmediawiki/extensions/Flowmaster+99 -72
Remove Deprecated User Methods and use UserFactory.Wandji collinsmediawiki/extensions/CentralAuthmaster+141 -56
Change from Deprecated User method to UserFactoryWandji collinsmediawiki/extensions/Wikibasemaster+55 -51
Avoid using deprecated User methodsWandji collinsmediawiki/extensions/Echomaster+146 -75
UserLocator: Cast user id to int in locateFromEventExtraKosta Harlanmediawiki/extensions/Echomaster+11 -1
Change from Deprecated User method to UserFactoryWandji collinsmediawiki/coremaster+223 -195
Customize query in gerrit

Related Objects

Event Timeline

Umherirrender created this task.Dec 20 2022, 9:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 20 2022, 9:23 PM
Umherirrender moved this task from Untriaged to 2021 | MW 1.36 / 1.37 on the Technical-Debt (Deprecation process) board.Dec 20 2022, 9:25 PM
Umherirrender mentioned this in T277511: Drop hard-deprecated User methods once they've been hard-deprecated in at least once release.Dec 20 2022, 9:35 PM
Umherirrender moved this task from Backlog to Other on the MediaWiki-User-management board.Dec 20 2022, 9:45 PM
Umherirrender mentioned this in T326646: PHP Deprecated: Use of WikiPage::newFromID was deprecated in MediaWiki 1.36. [Called from Article::getOldIDFromRequest].Jan 10 2023, 4:51 PM
Collins subscribed.May 8 2024, 11:13 AM
gerritbot added a comment.Jun 11 2024, 1:35 AM

Change #1041284 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/Flow@master] Remove Deprecated User Methods with UserFactory Methods

https://gerrit.wikimedia.org/r/1041284

gerritbot added a project: Patch-For-Review.Jun 11 2024, 1:35 AM
Collins claimed this task.Jul 10 2024, 11:36 AM
gerritbot added a comment.Jul 15 2024, 8:43 PM

Change #1054396 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/Wikibase@master] Change from Deprecated User method to UserFactory

https://gerrit.wikimedia.org/r/1054396

Umherirrender unsubscribed.Jul 19 2024, 10:46 PM
gerritbot added a comment.Jul 21 2024, 2:43 AM

Change #1055556 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/core@master] Change from Deprecated User method to UserFactory

https://gerrit.wikimedia.org/r/1055556

gerritbot added a comment.Sep 23 2024, 10:46 AM

Change #1074970 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/Echo@master] Fix:Aviod using deprecated User methods

https://gerrit.wikimedia.org/r/1074970

gerritbot added a comment.Mar 19 2026, 8:50 PM

Change #1055556 abandoned by Wandji collins:

[mediawiki/core@master] Change from Deprecated User method to UserFactory

https://gerrit.wikimedia.org/r/1055556

gerritbot added a comment.May 26 2026, 7:17 PM

Change #1074970 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Avoid using deprecated User methods

https://gerrit.wikimedia.org/r/1074970

gerritbot added a comment.Jun 1 2026, 2:17 PM

Change #1295931 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/Echo@master] UserLocator: Cast user id to int in locateFromEventExtra

https://gerrit.wikimedia.org/r/1295931

gerritbot added a comment.Jun 1 2026, 6:44 PM

Change #1295931 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] UserLocator: Cast user id to int in locateFromEventExtra

https://gerrit.wikimedia.org/r/1295931

gerritbot added a comment.Jul 9 2026, 3:56 PM

Change #1054396 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Change from Deprecated User method to UserFactory

https://gerrit.wikimedia.org/r/1054396

ReleaseTaggerBot added a project: MW-1.47-notes (1.47.0-wmf.11; 2026-07-14).Jul 9 2026, 4:00 PM
gerritbot added a comment.Jul 11 2026, 2:52 PM

Change #1309776 had a related patch set uploaded (by Wandji collins; author: Wandji collins):

[mediawiki/extensions/CentralAuth@master] Remove Deprecated User Methods and use UserFactory.

https://gerrit.wikimedia.org/r/1309776

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits