Wrong email confirmation link from secure server
Closed, ResolvedPublic

Description

The secure server currently sends out email confirmation links starting with http://en.wikipedia.org/wikipedia/en/wiki/Special:ConfirmEmail
This looks like a hodgepodge of a normal and secure link, and it gives a 404 error. It should be either
http://en.wikipedia.org/wiki/Special:ConfirmEmail
or
https://secure.wikimedia.org/wikipedia/en/wiki/Special:ConfirmEmail

Example of error:
"To confirm that this account really does belong to you and reactivate
e-mail features on Wikipedia, open this link in your browser:

http://en.wikipedia.org/wikipedia/en/wiki/Special:ConfirmEmail/264d4561c7ee43c80291dcb054d92c94"

The problem is only in mails from the secure server.
The confirmation code works when it is added to a valid url.
I found the bug while examining
http://en.wikipedia.org/wiki/Wikipedia:Help_desk#Generated_confirm_email_link_appears_to_be_broken_.28404_-_File_Not_Found.29


Version: unspecified
Severity: normal

bzimport added a project: HTTPS.Via ConduitNov 21 2014, 11:50 PM
bzimport added a subscriber: wikibugs-l.
bzimport set Reference to bz30647.
PrimeHunter created this task.Via LegacyAug 31 2011, 12:57 AM
brion added a comment.Via ConduitAug 31 2011, 5:44 PM

This is probably a regression related to introduction of $wgCanonicalServer...

r95505 on 1.17wmf1, looks like r95002 on trunk.

The new code concats $wgCanonicalServer with $wgArticlePath, which fails on the secure.wikimedia.org setup where $wgArticlePath has been modified to work with the modified $wgServer.

MZMcBride added a comment.Via ConduitAug 31 2011, 7:15 PM

Likely fixed by Roan in r95894.

Catrope added a comment.Via ConduitSep 1 2011, 7:32 AM

Deployed fix to production, confirmed fix.

Add Comment