Page MenuHomePhabricator

Wrong email confirmation link from secure server
Closed, ResolvedPublic


The secure server currently sends out email confirmation links starting with
This looks like a hodgepodge of a normal and secure link, and it gives a 404 error. It should be either

Example of error:
"To confirm that this account really does belong to you and reactivate
e-mail features on Wikipedia, open this link in your browser:"

The problem is only in mails from the secure server.
The confirmation code works when it is added to a valid url.
I found the bug while examining

Version: unspecified
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:50 PM
bzimport added a project: HTTPS.
bzimport set Reference to bz30647.
bzimport added a subscriber: Unknown Object (MLST).

This is probably a regression related to introduction of $wgCanonicalServer...

r95505 on 1.17wmf1, looks like r95002 on trunk.

The new code concats $wgCanonicalServer with $wgArticlePath, which fails on the setup where $wgArticlePath has been modified to work with the modified $wgServer.

Deployed fix to production, confirmed fix.