Page MenuHomePhabricator
Create Task
Maniphest T326621

Wikibase\Lexeme\Tests\MediaWiki\Specials\HTMLForm\LemmaLanguageFieldTest::testValidateWithValidLanguageCodeReturnsTrue HTMLFormField::__construct: Constructing an HTMLFormField without a 'parent' parameter
Closed, ResolvedPublic
Actions

Description

Blocking patch verification and merges on GrowthExperiments.

11:22:58 There was 1 error:
11:22:58 
11:22:58 1) Wikibase\Lexeme\Tests\MediaWiki\Specials\HTMLForm\LemmaLanguageFieldTest::testValidateWithValidLanguageCodeReturnsTrue
11:22:58 HTMLFormField::__construct: Constructing an HTMLFormField without a 'parent' parameter [Called from HTMLTextField::__construct in /workspace/src/includes/htmlform/fields/HTMLTextField.php at line 37]
11:22:58 
11:22:58 /workspace/src/includes/debug/MWDebug.php:381
11:22:58 /workspace/src/includes/debug/MWDebug.php:352
11:22:58 /workspace/src/includes/GlobalFunctions.php:795
11:22:58 /workspace/src/includes/htmlform/HTMLFormField.php:513
11:22:58 /workspace/src/includes/htmlform/fields/HTMLTextField.php:37
11:22:58 /workspace/src/extensions/WikibaseLexeme/src/MediaWiki/Specials/HTMLForm/LemmaLanguageField.php:40
11:22:58 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/mediawiki/Specials/HTMLForm/LemmaLanguageFieldTest.php:71
11:22:58 /workspace/src/extensions/WikibaseLexeme/tests/phpunit/mediawiki/Specials/HTMLForm/LemmaLanguageFieldTest.php:36

Details

SubjectRepoBranchLines +/-
Fix test constructing HTMLFormField without parentmediawiki/extensions/WikibaseLexemewmf/1.40.0-wmf.18+15 -3
Fix test constructing HTMLFormField without parentmediawiki/extensions/WikibaseLexememaster+15 -3
Customize query in gerrit

Event Timeline

kostajh triaged this task as Unbreak Now! priority.Jan 10 2023, 10:40 AM
kostajh created this task.
Restricted Application added a project: Growth-Team. · View Herald TranscriptJan 10 2023, 10:40 AM
Maintenance_bot added a project: Wikidata.Jan 10 2023, 10:45 AM
gerritbot added a comment.Jan 10 2023, 10:54 AM

Change 877991 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/WikibaseLexeme@master] Fix test constructing HTMLFormField without parent

https://gerrit.wikimedia.org/r/877991

gerritbot added a project: Patch-For-Review.Jan 10 2023, 10:54 AM
Jakob_WMDE subscribed.Jan 10 2023, 10:55 AM
gerritbot added a comment.Jan 10 2023, 11:26 AM

Change 877991 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Fix test constructing HTMLFormField without parent

https://gerrit.wikimedia.org/r/877991

kostajh closed this task as Resolved.Jan 10 2023, 11:27 AM
kostajh claimed this task.

Thank you!

Maintenance_bot removed a project: Patch-For-Review.Jan 10 2023, 11:30 AM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.19; 2023-01-16).Jan 10 2023, 12:00 PM
gerritbot added a comment.Jan 10 2023, 4:43 PM

Change 877983 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Jakob):

[mediawiki/extensions/WikibaseLexeme@wmf/1.40.0-wmf.18] Fix test constructing HTMLFormField without parent

https://gerrit.wikimedia.org/r/877983

gerritbot added a project: Patch-For-Review.Jan 10 2023, 4:43 PM
gerritbot added a comment.Jan 11 2023, 2:19 PM

Change 877983 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@wmf/1.40.0-wmf.18] Fix test constructing HTMLFormField without parent

https://gerrit.wikimedia.org/r/877983

Stashbot added a comment.Jan 11 2023, 2:19 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-11T14:19:41Z] <lucaswerkmeister-wmde@deploy1002> Started scap: Backport for [[gerrit:877983|Fix test constructing HTMLFormField without parent (T326621)]]

Stashbot added a comment.Jan 11 2023, 2:21 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-11T14:21:28Z] <lucaswerkmeister-wmde@deploy1002> lucaswerkmeister-wmde and lucaswerkmeister-wmde: Backport for [[gerrit:877983|Fix test constructing HTMLFormField without parent (T326621)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet

Stashbot added a comment.Jan 11 2023, 2:28 PM

Mentioned in SAL (#wikimedia-operations) [2023-01-11T14:28:20Z] <lucaswerkmeister-wmde@deploy1002> Finished scap: Backport for [[gerrit:877983|Fix test constructing HTMLFormField without parent (T326621)]] (duration: 08m 38s)

Maintenance_bot removed a project: Patch-For-Review.Jan 11 2023, 2:30 PM
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.18; 2023-01-09); removed MW-1.40-notes (1.40.0-wmf.19; 2023-01-16).Jan 11 2023, 3:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits