"index.php?diff=anyNonInteger" shows an unexpected diff, should instead give proper error message
Open, In Progress, Needs TriagePublicBUG REPORT
Actions

Assigned To

Authored By

	Novem_Linguae
	Jan 11 2023, 10:52 PM

Description

Steps to replicate the issue (include links if applicable):

Visit https://test.wikipedia.org/w/index.php?diff=undefined, which was generated by one of my user scripts accidentally

What happens?:

Unexpected main page diff is shown

What should have happened instead?:

User friendly error should be shown, such as "invalid page ID" or "invalid revision ID" or similar

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

	Subject	Repo	Branch	Lines +/-
	Add tests for includes/MediaWiki.php	mediawiki/core	master	+66 -9
	Invalid ?diff= now displays an error	mediawiki/core	master	+34 -2

Customize query in gerrit

Related Objects

Mentioned Here: T258878: Diff parameter without a value will take you to latest diff of main page instead of showing a warning

Event Timeline

Novem_Linguae created this task.Jan 11 2023, 10:52 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 11 2023, 10:52 PM

This diff is not random; it is the latest change of main page. Also this will happer if diff is other non-number (such as https://www.wikidata.org/w/index.php?diff=abc)

Novem_Linguae renamed this task from "index.php?diff=undefined" shows a random diff, should instead give proper error message to "index.php?diff=anyNonInteger" shows an unexpected diff, should instead give proper error message.Jan 12 2023, 2:06 AM

Novem_Linguae updated the task description. (Show Details)

Only a revision id, prev and next are allowed. Other letters are casted to integer 0 and that loads the latest version. Also happen when using directly diff=0. Without any title information that is the main page (but it would show the latest diff of other pages, when title= is given)

Using oldid=abc provides no error as well (when not numeric it is treated as non-existing)

https://www.wikidata.org/w/index.php?oldid=abc

See also T258878 (which is about an empty diff=, also casted to 0 and showing the diff of the latest), could be treated as duplicate bug, but could be a extra special page as well.

Umherirrender unsubscribed.Nov 29 2023, 10:38 PM

Change 982437 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/core@master] Invalid ?diff= now displays an error

https://gerrit.wikimedia.org/r/982437

gerritbot added a project: Patch-For-Review.Dec 12 2023, 5:02 PM

Novem_Linguae changed the task status from Open to In Progress.Dec 13 2023, 6:11 AM

Novem_Linguae claimed this task.

Change 982437 abandoned by Novem Linguae:

[mediawiki/core@master] Invalid ?diff= now displays an error

Reason:

not an easy fix. will add some unit tests instead, to make it easier for next person who works on this

https://gerrit.wikimedia.org/r/982437

Maintenance_bot removed a project: Patch-For-Review.Dec 22 2023, 7:30 AM

Change 985107 had a related patch set uploaded (by Novem Linguae; author: Novem Linguae):

[mediawiki/core@master] Add tests for includes/MediaWiki.php

https://gerrit.wikimedia.org/r/985107

gerritbot added a project: Patch-For-Review.Dec 22 2023, 8:56 AM

Change 985107 merged by jenkins-bot: