NearbyPages no longer works for articles with non-ASCII letters
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Nik.xyz.in

Authored By

	JohanahoJ
	Jan 13 2023, 8:12 AM

Description

NearbyPages no longer works for articles with letters other than [a-z].

Steps to replicate the issue:

Follow one of these links for locations with non-English letters:

What happens?:

You get an error message: "Wikipedia Nearby is having some issues."

What should have happened instead?:

You should get a list with articles that are geotagged nearest to the location.
See e.g.: https://en.wikipedia.org/wiki/Special:Nearby#/page/London

Other information (browser name/version, screenshots, etc.):

I use Safari with iPadOS 16

Details

	Subject	Repo	Branch	Lines +/-
	Show Result for Non Ascii characters	mediawiki/extensions/NearbyPages	master	+1 -1
	Show result for non-ASCII letters in URL	mediawiki/extensions/NearbyPages	master	+1 -0

Customize query in gerrit

Event Timeline

JohanahoJ created this task.Jan 13 2023, 8:12 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 13 2023, 8:12 AM

Aklapper renamed this task from NearbyPages no longer works for articles with non-English letters to NearbyPages no longer works for articles with non-ASCII letters.Jan 14 2023, 3:31 AM

Looks like our API request (ggpage and codistancefrompage parameter) is not encoded correctly
https://en.wikipedia.org/w/api.php?action=query&format=json&origin=*&formatversion=2&prop=coordinates%7Cpageprops%7Cpageimages%7Cdescription%7Cinfo%7Cpageterms&inprop=url&colimit=max&generator=geosearch&ggsradius=10000&ggsnamespace=0&ggslimit=50&redirects=no&uselang=en&ppprop=displaytitle&piprop=thumbnail&pithumbsize=150&pilimit=50&codistancefrompage=L%25C3%25BCbeck&ggspage=L%25C3%25BCbeck

I wamt to work on this issue? how do i get started?

@AymanMakroo: Hi and welcome! Please see https://www.mediawiki.org/wiki/New_Developers - thanks!

Hey @AymanMakroo in particular you'll need to setup MediaWiki and https://m.mediawiki.org/wiki/Extension:NearbyPages following the instructions on the page. Let me know when you've managed that!

Jdlrobson moved this task from Incoming to Not ready to estimate on the Web-Team-Backlog board.Jan 26 2023, 8:12 PM

I have setup the environment and able to reproduce the issue locally
I would like to work on it

@Jdlrobson

Go for it! Looking forward to your patch!

I have started working on it

@Nik.xyz.in: Hi and welcome. Please see https://www.mediawiki.org/wiki/New_Developers#Communication_tips - thanks a lot!

Inside extensions/NearbyPages/resources/ext.nearby.scripts/App.vue there is a router object which has a key called oldHash
Now when the URL is for example : /wiki/Special:Nearby#/page/London then oldHash is /page/London
But when the URL is /wiki/Special:Nearby#/page/Lübeck then oldHash is /page/L%C3%BCbeck
the issue has been resolved by decoding the URL by using js inbuilt function decodeURI(EncodedURL)
Have Tested it against words like Nordstraße_station , Düsseldorf , Lübeck, Curaçao , Tera_Corá

Do not know how to submit the patch and have asked question about the same in mediawiki channel on librechat

Nik.xyz.in added a comment.Jan 30 2023, 12:02 PM

This comment was removed by Nik.xyz.in.

In T326905#8569028, @Nik.xyz.in wrote:

Do not know how to submit the patch

See https://www.mediawiki.org/wiki/New_Developers - via Gerrit.

I have push the changes to gerrit
This is link
@Jdlrobson

@Nik.xyz.in: Congratulations! For future reference, please see also https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines - thanks!

Change 884533 had a related patch set uploaded (by Aklapper; author: Nik.xyz.in):

[mediawiki/extensions/NearbyPages@master] Show result for non-ASCII letters in URL

https://gerrit.wikimedia.org/r/884533

gerritbot added a project: Patch-For-Review.Jan 30 2023, 2:30 PM

Nik.xyz.in claimed this task.Jan 30 2023, 5:03 PM

Nik.xyz.in added a comment.Jan 31 2023, 10:31 AM

This comment was removed by Nik.xyz.in.

Change 885015 had a related patch set uploaded (by Nik.xyz.in; author: Nik.xyz.in):

[mediawiki/extensions/NearbyPages@master] Show Result for Non Ascii characters

https://gerrit.wikimedia.org/r/885015

Change 884533 abandoned by Jdlrobson:

[mediawiki/extensions/NearbyPages@master] Show result for non-ASCII letters in URL

Reason:

Superseded by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/NearbyPages/+/885015

For future reference, you can git commit --amend your patch and use `git review` - as long as the change id is the same you'll keep the code review conversation in one place.

https://gerrit.wikimedia.org/r/884533

Change 885015 merged by jenkins-bot:

[mediawiki/extensions/NearbyPages@master] Show Result for Non Ascii characters

https://gerrit.wikimedia.org/r/885015

Maintenance_bot removed a project: Patch-For-Review.Feb 1 2023, 5:30 PM

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.22; 2023-02-06).Feb 1 2023, 6:00 PM

Nik.xyz.in closed this task as Resolved.Feb 4 2023, 8:48 AM

Nik.xyz.in removed a project: patch-welcome.

Jdlrobson added a project: Verified.Feb 10 2023, 11:25 PM