Page MenuHomePhabricator

Add revision links to [[mw:Special:Code]] from various places in ViewVC
Closed, ResolvedPublic

Description

I suggest to modify the header template for the ViewVC interface to the SVN, so that each header comes with a single-click solution (precomputed) link to our Code Review.

Example:

When you view

http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/resources/jquery/jquery.highlightText.js?view=markup&pathrev=94702

I wish to have a direct link to the corresponding code review

http://www.mediawiki.org/wiki/Special:Code/MediaWiki/94702


Version: unspecified
Severity: enhancement

Details

Reference
bz30720

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 21 2014, 11:54 PM
bzimport set Reference to bz30720.

We actually had links back to mediawiki.org code review at some point. Presumably they got lost when the svn server was re-installed or when ViewVC was upgraded.

Tickets like bug 23177 confirm this.

Presumably they got lost when the svn server was re-installed or when ViewVC
was upgraded...

--> if this was present in former ViewVC and MediaWiki SVN revision, than it is not "enhancement" bug but "normal". (setting to "normal")

Probable WONTFIX with Git and Gerrit in place now.

Done in gerrit change 32465. Just needs merging.

(In reply to comment #4)

Done in Gerrit change #32465. Just needs merging.

Merged on the 27th of November by Pyoungmeister.