Page MenuHomePhabricator
Create Task
Maniphest T327289

Make images in nearby popup link to article
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

In user testing we got the feedback, that users would expect images in nearby popups to behave as a link. We decided to use the same approach as PagePreviews and link the image to the article.

  • Add link to article to thumbnail in nearby popup

Details

SubjectRepoBranchLines +/-
Nearby: Fix link image in popup to target articlemediawiki/extensions/Kartographermaster+5 -1
Nearby: Link image in popup to target article as wellmediawiki/extensions/Kartographermaster+6 -1
Customize query in gerrit

Event Timeline

lilients_WMDE created this task.Jan 18 2023, 2:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 18 2023, 2:42 PM
gerritbot added a comment.Jan 19 2023, 1:23 PM

Change 875357 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Nearby: Link image in popup to target article as well

https://gerrit.wikimedia.org/r/875357

gerritbot added a project: Patch-For-Review.Jan 19 2023, 1:23 PM
thiemowmde claimed this task.Jan 19 2023, 1:24 PM
thiemowmde moved this task from Ready for pickup to In sprint on the WMDE-GeoInfo-FocusArea board.
thiemowmde set the point value for this task to 1.
thiemowmde added a project: WMDE-TechWish-Sprint-2023-01-18.
thiemowmde moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2023-01-18 board.
lilients_WMDE moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2023-01-18 board.Jan 23 2023, 2:52 PM
gerritbot added a comment.Jan 23 2023, 2:55 PM

Change 875357 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Nearby: Link image in popup to target article as well

https://gerrit.wikimedia.org/r/875357

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.20; 2023-01-23).Jan 23 2023, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 23 2023, 3:30 PM
WMDE-Fisch claimed this task.Feb 13 2023, 8:17 AM
WMDE-Fisch moved this task from Demo to Doing on the WMDE-TechWish-Sprint-2023-01-18 board.
WMDE-Fisch added subscribers: thiemowmde, WMDE-Fisch.

Seems that this got lost during some rebase...

gerritbot added a comment.Feb 13 2023, 8:21 AM

Change 888630 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Kartographer@master] Nearby: Fix link image in popup to target article

https://gerrit.wikimedia.org/r/888630

gerritbot added a project: Patch-For-Review.Feb 13 2023, 8:21 AM
WMDE-Fisch removed WMDE-Fisch as the assignee of this task.Feb 13 2023, 8:22 AM
WMDE-Fisch moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2023-01-18 board.
gerritbot added a comment.Feb 13 2023, 10:13 AM

Change 888630 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Nearby: Fix link image in popup to target article

https://gerrit.wikimedia.org/r/888630

Maintenance_bot removed a project: Patch-For-Review.Feb 13 2023, 10:30 AM
WMDE-Fisch moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2023-01-18 board.Feb 13 2023, 10:53 AM
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.23; 2023-02-13); removed MW-1.40-notes (1.40.0-wmf.20; 2023-01-23).Feb 13 2023, 11:00 AM
WMDE-Fisch closed this task as Resolved.Feb 13 2023, 11:28 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits