Page MenuHomePhabricator

PHP 8.2: Creation of dynamic property CargoICalendarFormat::$mParser is deprecated
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):
Run Cargo's PHPUnit test suite on PHP 8.2.

What happens?:
CargoICalendarFormatTest emits deprecation warnings, e.g.:

Creation of dynamic property CargoICalendarFormat::$mParser is deprecated

mediawiki/extensions/Cargo/includes/formats/CargoDisplayFormat.php:14
mediawiki/extensions/Cargo/tests/phpunit/integration/formats/CargoICalendarFormatTest.php:91
Wikia/mediawiki/tests/phpunit/MediaWikiIntegrationTestCase.php:519

Software version : MW 1.40

Event Timeline

Change 881484 had a related patch set uploaded (by TK-999; author: TK-999):

[mediawiki/extensions/Cargo@master] Fix some PHP 8.0/8.2 deprecations

https://gerrit.wikimedia.org/r/881484

Change 881484 merged by jenkins-bot:

[mediawiki/extensions/Cargo@master] Fix some PHP 8.0/8.2 deprecations

https://gerrit.wikimedia.org/r/881484

Yaron_Koren claimed this task.
Yaron_Koren subscribed.

Thank you for this fix! I assume this bug is resolved now.

Yeah, should be good now! Sorry, I've been meaning to close the task after the changeset was merged but I forgot about it.