Page MenuHomePhabricator

Talk Page Archives - PR Feedback
Open, MediumPublic

Description

This task is to address items that came up (but didn't block merging) during PR feedback. Most of this feedback is more meta - to solidify the new header hiding approach before we expand it to other screens.

https://github.com/wikimedia/wikipedia-ios/pull/4441#discussion_r1069613357

  1. Talk Page Archives Voice Over support

https://github.com/wikimedia/wikipedia-ios/pull/4441#pullrequestreview-1248672880

  1. Header tap/scroll fallthrough support. Not really needed for archives, since it's just a tiny navigation bar, but definitely needed when we need to use a full header view.
  2. Snapping support. Also not needed for archives, since we aren't hiding the header upon scroll. Definitely needed when we need to use a full header view.
  3. Remove needless shiftOrder param.
  4. Potentially rename away from "ShiftingTop" prefix.