wikiadmin2023@10.64.16.187(labswiki)> show create table oathauth_users\G
*************************** 1. row ***************************
       Table: oathauth_users
Create Table: CREATE TABLE `oathauth_users` (
  `id` int(11) NOT NULL,
  `module` varbinary(255) NOT NULL,
  `data` blob DEFAULT NULL,
  PRIMARY KEY (`id`)
) ENGINE=InnoDB DEFAULT CHARSET=binary
1 row in set (0.000 sec)

mysql:root@localhost [labtestwiki]> show create table oathauth_users\G
*************************** 1. row ***************************
       Table: oathauth_users
Create Table: CREATE TABLE `oathauth_users` (
  `id` int(11) NOT NULL,
  `secret_reset` varbinary(255) DEFAULT NULL,
  `scratch_tokens_reset` varbinary(512) NOT NULL,
  `is_validated` tinyint(1) NOT NULL,
  `module` varbinary(255) NOT NULL,
  `data` blob DEFAULT NULL,
  PRIMARY KEY (`id`)
) ENGINE=InnoDB DEFAULT CHARSET=binary
1 row in set (0.000 sec)

CREATE TABLE /*_*/oathauth_users (
  id INT NOT NULL,
  module VARCHAR(255) NOT NULL,
  data BLOB DEFAULT NULL,
  PRIMARY KEY(id)
) /*$wgDBTableOptions*/;

So there's some schema drift.. looks like T226826 and some other task removing is_validated that I can't find were never applied to labtestwiki.

Thanks for digging, @taavi. I think this might be of interest to Amir because I /did/ run update.php but that doesn't seem to have upgraded that schema. (Or it might be of no interest because maybe I don't know how to do a proper schema upgrade these days)

In T328131#8564579, @Andrew wrote:

Thanks for digging, @taavi. I think this might be of interest to Amir because I /did/ run update.php but that doesn't seem to have upgraded that schema. (Or it might be of no interest because maybe I don't know how to do a proper schema upgrade these days)

update.php is not perfect:

• It is buggy, people have forgotten to wire up changes, people removed things by mistake, the check might be wrong in old versions etc.
• It doesn't take into account drifts caused by other tools. Someone alters the table in production for whatever reason and the software doesn't incorporate for that. The update.php updates are for intentional schema changes
• It might have been removed as we don't support upgrades from really old versions of MediaWiki (e.g. we are using the new software but we didn't run update.php for long enough time that it got removed)

Anyway, we can take a look next week if it's not urgent.

next week is fine!

yup, the original drop of those columns happened in 2016: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/OATHAuth/+/804665 and it's the refactor before the refactor you mentioned. The fact that this wiki works at all is baffling to me.

Running this should fix the issues: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/OATHAuth/+/134050/22/sql/mysql/patch-remove_reset.sql Take a backup first because it might be that we need to run some maint scripts or such.

Mentioned in SAL (#wikimedia-cloud) [2023-02-04T13:44:13Z] <taavi> drop old columns from oathauth_users table on labtestwiki T328131