Not a solid line at the bottom of the table?
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Fix table bottom line | mediawiki/extensions/SecurePoll | master | +1 -0 |
Event Timeline
Comment Actions
Yes, this is a known issue from several years now. Should just be
.securepoll-ballot-table tr:last-child { border-bottom: thin #999 solid; }
Comment Actions
.securepoll-ballot-table { border-collapse: collapse; } .securepoll-ballot-table th { font-weight: bold; text-align: center; border: thin #999 solid; padding: 0 1.5em; } .securepoll-ballot-table td { text-align: center; border-left: thin #999 solid; border-right: thin #999 solid; border-bottom: thin #bbb dotted; padding: 0 1.5em; } .securepoll-ballot-table td.securepoll-ballot-optlabel { /* High specificity */ text-align: left; }
The border-bottom: thin #bbb dotted; on the .securepoll-ballot-table td makes it look intentional
Comment Actions
Yes, intentional for separating rows. Most questions using SecurePoll probably have more than one response e.g. ArbCom elections.
I don't think it's intentional for the table's borders, hence the suggested CSS there. I'd submit a patch but it looks like there's some other border declarations a bit further south that I am not aware of having seen so I didn't want to make something wrong somewhere else.
Comment Actions
<table class="securepoll-ballot-table"><thead><tr><th></th><th>No</th><th>—</th><th>Yes</th></tr></thead><tbody><tr class="securepoll-ballot-row"><td class="securepoll-ballot-optlabel">Do you support the enforcement of the Universal Code of Conduct based on the revised guidelines?</td><td><span class="oo-ui-widget oo-ui-widget-enabled oo-ui-inputWidget oo-ui-radioInputWidget"><input type="radio" tabindex="0" title="No" name="securepoll_q1415_opt1416" value="-1" class="oo-ui-inputWidget-input"><span></span></span></td><td><span class="oo-ui-widget oo-ui-widget-enabled oo-ui-inputWidget oo-ui-radioInputWidget"><input type="radio" tabindex="0" title="—" name="securepoll_q1415_opt1416" value="0" checked="checked" class="oo-ui-inputWidget-input"><span></span></span></td><td><span class="oo-ui-widget oo-ui-widget-enabled oo-ui-inputWidget oo-ui-radioInputWidget"><input type="radio" tabindex="0" title="Yes" name="securepoll_q1415_opt1416" value="1" class="oo-ui-inputWidget-input"><span></span></span></td></tr></tbody></table>
It definitely has the desired effect, just the question whether there's any side effects..
Comment Actions
Hi,
I'm Roshaan. I am new to Phabricator. I want to solve this task,
Can you guide me a little more about what can I do to fix it?
Comment Actions
@Roshaan: Hi and welcome! Please read https://www.mediawiki.org/wiki/New_Developers#Communication_tips - thanks a lot! :)
Comment Actions
@Trakshan_Mishra: Hi and welcome! Please read https://www.mediawiki.org/wiki/New_Developers#Communication_tips - thanks! :)
Comment Actions
Change 841118 had a related patch set uploaded (by Aklapper; author: Stang):
[mediawiki/extensions/SecurePoll@master] Fix table bottom line
Comment Actions
Change 841118 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Fix table bottom line
