Page MenuHomePhabricator

Removal of columns causes 1.39 postgres updates to fail
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Run postgres CI

What happens?:
Fails with the error:

ERROR: expected column cu_changes.cuc_user_text to exist

This happens because the updates that fail use a method in the PostgresUpdater that requires the fields exist. This means that when the field is later removed the update fails. To fix this the field being present on the DB should be detected first. If the field does not exist then the update does not need to occur.

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
ResolvedZabe
ResolvedBUG REPORTDreamy_Jazz

Event Timeline

Change 886462 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Don't run postgres updates on specific columns unless the field exists

https://gerrit.wikimedia.org/r/886462

Dreamy_Jazz triaged this task as Medium priority.
Dreamy_Jazz moved this task from General / Unsorted to Patches for review on the CheckUser board.

Change 886462 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Don't run postgres updates on specific columns unless the field exists

https://gerrit.wikimedia.org/r/886462