Page MenuHomePhabricator
Create Task
Maniphest T329064

mediawiki.page-undelete stream is empty
Closed, ResolvedPublic
Actions

Description

In https://gerrit.wikimedia.org/r/c/mediawiki/extensions/EventBus/+/821776, the PageUndelete hook was modified, and the EventBusHooks::onPageUndelete hook was accidentally unregistered.

The mediawiki.page-undelete stream has been empty since this was deployed.

This should be fixed asap.

Details

SubjectRepoBranchLines +/-
Restore mediawiki.page-undelete hookmediawiki/extensions/EventBusmaster+1 -1
Restore mediawiki.page-undelete hookmediawiki/extensions/EventBuswmf/1.40.0-wmf.21+1 -1
Restore mediawiki.page-undelete hookmediawiki/extensions/EventBuswmf/1.40.0-wmf.22+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ottomata created this task.Feb 7 2023, 3:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 7 2023, 3:34 PM
Ottomata triaged this task as Unbreak Now! priority.Feb 7 2023, 3:35 PM
gerritbot added a comment.Feb 7 2023, 3:35 PM

Change 887332 had a related patch set uploaded (by Ottomata; author: Ottomata):

[mediawiki/extensions/EventBus@master] Restore mediawiki.page-undelete hook

https://gerrit.wikimedia.org/r/887332

gerritbot added a project: Patch-For-Review.Feb 7 2023, 3:35 PM
gerritbot added a comment.Feb 7 2023, 3:41 PM

Change 886985 had a related patch set uploaded (by Urbanecm; author: Ottomata):

[mediawiki/extensions/EventBus@wmf/1.40.0-wmf.22] Restore mediawiki.page-undelete hook

https://gerrit.wikimedia.org/r/886985

gerritbot added a comment.Feb 7 2023, 3:41 PM

Change 887346 had a related patch set uploaded (by Urbanecm; author: Ottomata):

[mediawiki/extensions/EventBus@wmf/1.40.0-wmf.21] Restore mediawiki.page-undelete hook

https://gerrit.wikimedia.org/r/887346

BTullis subscribed.Feb 7 2023, 3:46 PM
gerritbot added a comment.Feb 7 2023, 3:59 PM

Change 886985 merged by jenkins-bot:

[mediawiki/extensions/EventBus@wmf/1.40.0-wmf.22] Restore mediawiki.page-undelete hook

https://gerrit.wikimedia.org/r/886985

gerritbot added a comment.Feb 7 2023, 3:59 PM

Change 887346 merged by jenkins-bot:

[mediawiki/extensions/EventBus@wmf/1.40.0-wmf.21] Restore mediawiki.page-undelete hook

https://gerrit.wikimedia.org/r/887346

Stashbot added a comment.Feb 7 2023, 4:00 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-07T16:00:22Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:886985|Restore mediawiki.page-undelete hook (T329064)]], [[gerrit:887346|Restore mediawiki.page-undelete hook (T329064)]]

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.21; 2023-01-30).Feb 7 2023, 4:00 PM
gerritbot added a comment.Feb 7 2023, 4:01 PM

Change 887332 merged by jenkins-bot:

[mediawiki/extensions/EventBus@master] Restore mediawiki.page-undelete hook

https://gerrit.wikimedia.org/r/887332

Stashbot added a comment.Feb 7 2023, 4:02 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-07T16:02:13Z] <urbanecm@deploy1002> urbanecm: Backport for [[gerrit:886985|Restore mediawiki.page-undelete hook (T329064)]], [[gerrit:887346|Restore mediawiki.page-undelete hook (T329064)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet

Ottomata mentioned this in T329070: Automated event stream throughput alerting for important state change streams.Feb 7 2023, 4:05 PM

Incident report drafting here

Stashbot added a comment.Feb 7 2023, 4:18 PM

Mentioned in SAL (#wikimedia-operations) [2023-02-07T16:18:07Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:886985|Restore mediawiki.page-undelete hook (T329064)]], [[gerrit:887346|Restore mediawiki.page-undelete hook (T329064)]] (duration: 17m 44s)

Maintenance_bot removed a project: Patch-For-Review.Feb 7 2023, 4:30 PM
dcausse mentioned this in T329089: The rdf-streaming-updater does not reconcile missed page-undelete events.Feb 7 2023, 4:54 PM
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.23; 2023-02-13); removed MW-1.40-notes (1.40.0-wmf.21; 2023-01-30).Feb 7 2023, 5:01 PM
JArguello-WMF moved this task from Backlog to Sprint 08 on the Event-Platform board.Feb 8 2023, 3:58 PM
JArguello-WMF edited projects, added Event-Platform (Sprint 08); removed Event-Platform.
JArguello-WMF moved this task from Next Up to In Progress on the Event-Platform (Sprint 08) board.
• EChetty edited projects, added Data-Engineering-Planning; removed Data-Engineering.Feb 10 2023, 12:38 PM
Ottomata moved this task from In Progress to Done on the Event-Platform (Sprint 08) board.Feb 13 2023, 6:03 PM

Published incident report:
https://wikitech.wikimedia.org/wiki/Incidents/2023-02-07_mediawiki.page-undelete_event_stream

lbowmaker closed this task as Resolved.Feb 17 2023, 2:50 PM
Bovlb mentioned this in T341905: Undeleted Wikidata items do not reappear in WDQS.Jul 14 2023, 8:23 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL