Page MenuHomePhabricator
Create Task
Maniphest T329214

Address badfile fixmes
Closed, ResolvedPublic
Actions

Description

https://github.com/wikimedia/mediawiki/blob/master/includes/gallery/TraditionalImageGallery.php#L128
https://github.com/wikimedia/mediawiki-services-parsoid/blob/master/tests/parser/media.txt#L199-L253

Details

SubjectRepoBranchLines +/-
Pass whether current rev of file exists to Linker::makeBrokenImageLinkObjmediawiki/coreREL1_40+23 -14
Pass whether current rev of file exists to Linker::makeBrokenImageLinkObjmediawiki/coreREL1_39+24 -11
Pass whether current rev of file exists to Linker::makeBrokenImageLinkObjmediawiki/coremaster+23 -13
Customize query in gerrit

Related Objects

Event Timeline

Arlolra created this task.Feb 8 2023, 6:12 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 8 2023, 6:12 PM
ssastry moved this task from Needs Triage to Tech Debt / Big changes on the Parsoid board.Feb 16 2023, 3:12 PM
Arlolra triaged this task as Medium priority.Apr 25 2023, 9:24 PM
Arlolra moved this task from Backlog to Needs decision on the Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure) board.
gerritbot added a comment.Apr 28 2023, 9:15 PM

Change 913269 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@master] Pass whether current rev of file exists to Linker::makeBrokenImageLinkObj

https://gerrit.wikimedia.org/r/913269

gerritbot added a project: Patch-For-Review.Apr 28 2023, 9:15 PM
Arlolra claimed this task.Apr 28 2023, 9:19 PM
Arlolra added a project: Content-Transform-Team-WIP.
Arlolra moved this task from Backlog to Code Review on the Content-Transform-Team-WIP board.
Arlolra moved this task from Needs decision to Code Review on the Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure) board.
gerritbot added a comment.May 3 2023, 8:07 AM

Change 913269 merged by jenkins-bot:

[mediawiki/core@master] Pass whether current rev of file exists to Linker::makeBrokenImageLinkObj

https://gerrit.wikimedia.org/r/913269

Maintenance_bot removed a project: Patch-For-Review.May 3 2023, 8:10 AM
Arlolra mentioned this in T335612: CVE-2023-36674: Manualthumb bypasses badFile lookup.May 8 2023, 2:57 PM
Arlolra moved this task from Code Review to To Deploy on the Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure) board.May 10 2023, 12:04 AM
Arlolra moved this task from Code Review to To Deploy on the Content-Transform-Team-WIP board.
Arlolra closed this task as Resolved.May 15 2023, 11:33 PM
Arlolra moved this task from To Deploy to To Verify on the Content-Transform-Team-WIP board.

Verified in T335612#8852689

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.10; 2023-05-23).May 16 2023, 7:02 AM
gerritbot added a comment.Jun 29 2023, 8:58 AM

Change 934262 had a related patch set uploaded (by Reedy; author: Arlolra):

[mediawiki/core@REL1_39] Pass whether current rev of file exists to Linker::makeBrokenImageLinkObj

https://gerrit.wikimedia.org/r/934262

gerritbot added a project: Patch-For-Review.Jun 29 2023, 8:58 AM
gerritbot added a comment.Jun 29 2023, 10:23 AM

Change 934262 merged by jenkins-bot:

[mediawiki/core@REL1_39] Pass whether current rev of file exists to Linker::makeBrokenImageLinkObj

https://gerrit.wikimedia.org/r/934262

Maintenance_bot removed a project: Patch-For-Review.Jun 29 2023, 10:30 AM
ReleaseTaggerBot added a project: MW-1.39-notes.Jun 29 2023, 11:00 AM
gerritbot added a comment.Jun 29 2023, 5:54 PM

Change 934393 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@REL1_40] Pass whether current rev of file exists to Linker::makeBrokenImageLinkObj

https://gerrit.wikimedia.org/r/934393

gerritbot added a project: Patch-For-Review.Jun 29 2023, 5:54 PM
gerritbot added a comment.Jun 29 2023, 7:28 PM

Change 934393 merged by jenkins-bot:

[mediawiki/core@REL1_40] Pass whether current rev of file exists to Linker::makeBrokenImageLinkObj

https://gerrit.wikimedia.org/r/934393

Maintenance_bot removed a project: Patch-For-Review.Jun 29 2023, 7:30 PM
ReleaseTaggerBot added a project: MW-1.40-notes.Jun 29 2023, 8:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL