Page MenuHomePhabricator
Create Task
Maniphest T329254

Consider moving getZid and getImplementationZids out of ApiPerformTest.php
Closed, ResolvedPublic
Actions

Description

Description

As suggested by comments in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/881751:
getZid could be in a utils file; getImplementationZids in ZFunction.php.

Before moving, ensure that they are sufficiently general-purpose for those proposed locations.

Completion checklist

  • getZid
  • getImplementationZids

Details

SubjectRepoBranchLines +/-
APIs: Move executeFunctionCall up from ApiPerformTest to traitmediawiki/extensions/WikiLambdamaster+66 -46
APIs: Consolidate Orchestrator set-up codemediawiki/extensions/WikiLambdamaster+25 -41
ApiPerformTest: Move getZid to ZObjectUtilsmediawiki/extensions/WikiLambdamaster+27 -16
ApiPerformTest: Refactor ::getTester/ImplementationZids to ZFunctionmediawiki/extensions/WikiLambdamaster+87 -78
Customize query in gerrit

Event Timeline

DMartin-WMF created this task.Feb 9 2023, 7:18 AM
Jdforrester-WMF added a project: Abstract Wikipedia Fix-It tasks.Feb 9 2023, 1:29 PM
• RWambua-WMF moved this task from To triage to To triage: Nice-to-haves on the Abstract Wikipedia team board.Feb 14 2023, 7:36 PM
gerritbot added a comment.Mar 13 2023, 8:26 PM

Change 897980 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] ApiPerformTest: Refactor ::getTester/ImplementationZids to ZFunction

https://gerrit.wikimedia.org/r/897980

gerritbot added a project: Patch-For-Review.Mar 13 2023, 8:26 PM
gerritbot added a comment.Mar 16 2023, 7:17 PM

Change 897980 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] ApiPerformTest: Refactor ::getTester/ImplementationZids to ZFunction

https://gerrit.wikimedia.org/r/897980

Maintenance_bot removed a project: Patch-For-Review.Mar 16 2023, 7:30 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.1; 2023-03-20).Mar 16 2023, 8:00 PM
Jdforrester-WMF claimed this task.Mar 20 2023, 1:05 PM
Jdforrester-WMF updated the task description. (Show Details)
gerritbot added a comment.Mar 20 2023, 1:20 PM

Change 901205 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] ApiPerformTest: Move getZid to ZObjectUtils

https://gerrit.wikimedia.org/r/901205

gerritbot added a project: Patch-For-Review.Mar 20 2023, 1:20 PM
gerritbot added a comment.Mar 20 2023, 2:06 PM

Change 901212 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] APIs: Consolidate Orchestrator set-up code

https://gerrit.wikimedia.org/r/901212

gerritbot added a comment.Mar 20 2023, 2:06 PM

Change 901213 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] APIs: Move executeFunctionCall up from ApiPerformTest to trait

https://gerrit.wikimedia.org/r/901213

gerritbot added a comment.Mar 20 2023, 2:06 PM

Change 901214 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] ApiHealthCheck: Use trait's executeFunctionCall() not our own

https://gerrit.wikimedia.org/r/901214

gerritbot added a comment.Mar 20 2023, 2:06 PM

Change 901215 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] ApiFunctionCall: Use trait's executeFunctionCall() not our own

https://gerrit.wikimedia.org/r/901215

gerritbot added a comment.Mar 20 2023, 3:20 PM

Change 901205 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] ApiPerformTest: Move getZid to ZObjectUtils

https://gerrit.wikimedia.org/r/901205

gerritbot added a comment.Mar 20 2023, 3:36 PM

Change 901212 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] APIs: Consolidate Orchestrator set-up code

https://gerrit.wikimedia.org/r/901212

Jdforrester-WMF closed this task as Resolved.Mar 20 2023, 4:00 PM
Jdforrester-WMF updated the task description. (Show Details)
gerritbot added a comment.Mar 20 2023, 11:46 PM

Change 901213 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] APIs: Move executeFunctionCall up from ApiPerformTest to trait

https://gerrit.wikimedia.org/r/901213

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits