Page MenuHomePhabricator
Create Task
Maniphest T329413

Magnify links don't point to the file description page when |link= media option is used
Closed, ResolvedPublic
Actions

Description

Similar to T329364, again when $wgParserEnableLegacyMediaDOM set to false

The css based magnify links should be limited to the .mw-file-description case where they're redundant. For the more uncommon case where the |link= media option is used, we'll need to consider to adding a tags to the html, probably in the figcaption similar to the legacy output.

Also, if the link is suppressed |link=| or timed media is used, so that the inner wrapping element is a <span>, the magnify isn't present at all.

Details

SubjectRepoBranchLines +/-
Bump parsoid to 0.18.0-a25mediawiki/vendormaster+68 -97
Add magnify links on thumbs when not linking to file desc pagemediawiki/services/parsoidmaster+8 -0
Copy upstream changes for magnify linksmediawiki/skins/Timelessmaster+4 -2
Add resource for thumb magnify linksmediawiki/extensions/ImageMapmaster+10 -3
Add resource for thumb magnify linksmediawiki/extensions/TimedMediaHandlermaster+14 -4
Add magnify links on thumbs when not linking to file desc pagemediawiki/coremaster+64 -19
Disable test to break circular dependencymediawiki/extensions/TimedMediaHandlermaster+1 -1
Only add css based magnify links when pointing to file desc pagemediawiki/skins/Timelessmaster+1 -1
Only add css based magnify links when pointing to file desc pagemediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

Arlolra created this task.Feb 11 2023, 6:12 AM
Restricted Application added a project: Parsoid. · View Herald TranscriptFeb 11 2023, 6:12 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Feb 14 2023, 12:38 AM

Change 888818 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@master] Only add css based magnify links when pointing to file desc page

https://gerrit.wikimedia.org/r/888818

gerritbot added a project: Patch-For-Review.Feb 14 2023, 12:38 AM
Arlolra claimed this task.Feb 14 2023, 12:38 AM
Arlolra triaged this task as Medium priority.
Arlolra added a project: Content-Transform-Team-WIP.
Arlolra moved this task from Needs Triage to Media Structure on the Parsoid board.
Arlolra moved this task from Backlog to In Progress on the Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure) board.
Arlolra moved this task from Backlog to In Progress on the Content-Transform-Team-WIP board.
Arlolra updated the task description. (Show Details)Feb 14 2023, 10:59 PM
gerritbot added a comment.Feb 14 2023, 11:19 PM

Change 888818 merged by jenkins-bot:

[mediawiki/core@master] Only add css based magnify links when pointing to file desc page

https://gerrit.wikimedia.org/r/888818

Maintenance_bot removed a project: Patch-For-Review.Feb 14 2023, 11:30 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.24; 2023-02-20).Feb 15 2023, 12:00 AM
gerritbot added a comment.Feb 15 2023, 12:07 AM

Change 889260 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/skins/Timeless@master] Only add css based magnify links when pointing to file desc page

https://gerrit.wikimedia.org/r/889260

gerritbot added a project: Patch-For-Review.Feb 15 2023, 12:07 AM
gerritbot added a comment.Feb 15 2023, 12:10 AM

Change 889260 merged by jenkins-bot:

[mediawiki/skins/Timeless@master] Only add css based magnify links when pointing to file desc page

https://gerrit.wikimedia.org/r/889260

Maintenance_bot removed a project: Patch-For-Review.Feb 15 2023, 12:30 AM
Arlolra moved this task from In Progress to Backlog on the Content-Transform-Team-WIP board.Apr 24 2023, 3:06 PM
Arlolra moved this task from Backlog to In Progress on the Content-Transform-Team-WIP board.Apr 26 2023, 1:39 AM
gerritbot added a comment.May 12 2023, 2:24 AM

Change 919254 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@master] [WIP] Add magnify links to when not linking file desc page

https://gerrit.wikimedia.org/r/919254

gerritbot added a project: Patch-For-Review.May 12 2023, 2:24 AM
gerritbot added a comment.May 16 2023, 11:27 PM

Change 920391 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/TimedMediaHandler@master] Disable test to break circular dependency

https://gerrit.wikimedia.org/r/920391

gerritbot added a comment.May 17 2023, 10:23 PM

Change 920799 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/TimedMediaHandler@master] [WIP] Add resource for thumb magnify links

https://gerrit.wikimedia.org/r/920799

Arlolra moved this task from In Progress to Code Review on the Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure) board.May 17 2023, 11:40 PM
Arlolra moved this task from In Progress to Code Review on the Content-Transform-Team-WIP board.
gerritbot added a comment.May 18 2023, 12:25 AM

Change 920802 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/ImageMap@master] [WIP] Add resource for thumb magnify links

https://gerrit.wikimedia.org/r/920802

gerritbot added a comment.May 25 2023, 10:47 AM

Change 920391 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Disable test to break circular dependency

https://gerrit.wikimedia.org/r/920391

gerritbot added a comment.May 25 2023, 10:49 AM

Change 919254 merged by jenkins-bot:

[mediawiki/core@master] Add magnify links on thumbs when not linking to file desc page

https://gerrit.wikimedia.org/r/919254

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.11; 2023-05-30).May 25 2023, 11:00 AM
Arlolra moved this task from Code Review to To Deploy on the Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure) board.May 25 2023, 3:32 PM
Arlolra moved this task from Code Review to To Deploy on the Content-Transform-Team-WIP board.
gerritbot added a comment.May 25 2023, 4:13 PM

Change 920799 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Add resource for thumb magnify links

https://gerrit.wikimedia.org/r/920799

gerritbot added a comment.May 25 2023, 4:29 PM

Change 920802 merged by jenkins-bot:

[mediawiki/extensions/ImageMap@master] Add resource for thumb magnify links

https://gerrit.wikimedia.org/r/920802

Maintenance_bot removed a project: Patch-For-Review.May 25 2023, 4:30 PM
gerritbot added a comment.May 26 2023, 12:02 AM

Change 923438 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/skins/Timeless@master] Copy upstream changes for magnify links

https://gerrit.wikimedia.org/r/923438

gerritbot added a project: Patch-For-Review.May 26 2023, 12:02 AM
gerritbot added a comment.May 26 2023, 6:26 AM

Change 923438 merged by jenkins-bot:

[mediawiki/skins/Timeless@master] Copy upstream changes for magnify links

https://gerrit.wikimedia.org/r/923438

Maintenance_bot removed a project: Patch-For-Review.May 26 2023, 6:30 AM
Arlolra moved this task from To Deploy to To Verify on the Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure) board.May 31 2023, 12:17 AM
Arlolra moved this task from To Deploy to To Verify on the Content-Transform-Team-WIP board.
Arlolra closed this task as Resolved.May 31 2023, 7:18 PM

Looks ok now, https://www.mediawiki.org/w/index.php?title=User:Arlolra/sandbox&oldid=5954888

gerritbot added a comment.Sep 19 2023, 6:18 PM

Change 959028 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Add magnify links on thumbs when not linking to file desc page

https://gerrit.wikimedia.org/r/959028

gerritbot added a project: Patch-For-Review.Sep 19 2023, 6:18 PM
gerritbot added a comment.Sep 19 2023, 7:56 PM

Change 959028 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Add magnify links on thumbs when not linking to file desc page

https://gerrit.wikimedia.org/r/959028

Maintenance_bot removed a project: Patch-For-Review.Sep 19 2023, 8:14 PM
gerritbot added a comment.Sep 25 2023, 3:44 PM

Change 960644 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/vendor@master] Bump parsoid to 0.18.0-a25

https://gerrit.wikimedia.org/r/960644

gerritbot added a project: Patch-For-Review.Sep 25 2023, 3:44 PM
gerritbot added a comment.Sep 25 2023, 4:14 PM

Change 960644 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.18.0-a25

https://gerrit.wikimedia.org/r/960644

Maintenance_bot removed a project: Patch-For-Review.Sep 25 2023, 4:32 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits