Maniphest T329364

Description link no longer displayed when $wgParserEnableLegacyMediaDOM set to false
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

Set $wgParserEnableLegacyMediaDOM = false
Visit a page containing an <imagemap> without desc none, for example, https://www.mediawiki.org/wiki/Extension:ImageMap

What happens?:

The image tagged with the imagemap doesn't display the blue "info" icon in the bottom right corner of the image.

What should have happened instead?:

A blue "info" icon in the bottom right corner of the image should appear, as described.

Software version

WMF wikis after T314318: Disable wgParserEnableLegacyMediaDOM on all wikis

Details

Subject	Repo	Branch	Lines +/-
Bump parsoid to 0.18.0-a13	mediawiki/vendor	master	+143 -46
Fix description link icon positioning	mediawiki/extensions/ImageMap	wmf/1.41.0-wmf.11	+1 -1
Fix description link icon positioning	mediawiki/extensions/ImageMap	master	+1 -1
Port changes to add description links	mediawiki/services/parsoid	master	+74 -13
Add back description links when !$wgParserEnableLegacyMediaDOM	mediawiki/extensions/ImageMap	master	+148 -51

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Arlolra	T51097 Use figure and figcaption HTML5 elements when possible
		Resolved	BUG REPORT	Arlolra	T329364 Description link no longer displayed when $wgParserEnableLegacyMediaDOM set to false

Event Timeline

Ciencia_Al_Poder created this task.Feb 10 2023, 12:11 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 10 2023, 12:11 PM

Ciencia_Al_Poder added a parent task: T51097: Use figure and figcaption HTML5 elements when possible.Feb 10 2023, 12:11 PM

Arlolra added a project: Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure).Feb 11 2023, 3:40 AM

Restricted Application added a project: Parsoid. · View Herald TranscriptFeb 11 2023, 3:40 AM

Arlolra mentioned this in T329413: Magnify links don't point to the file description page when |link= media option is used.Feb 11 2023, 6:12 AM

• ssastry moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.Feb 16 2023, 3:10 PM

Arlolra claimed this task.Apr 25 2023, 9:23 PM

Arlolra triaged this task as Medium priority.

Arlolra moved this task from Backlog to In Progress on the Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure) board.

Change 911957 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/ImageMap@master] [WIP] Add back description links when !$wgParserEnableLegacyMediaDOM

https://gerrit.wikimedia.org/r/911957

gerritbot added a project: Patch-For-Review.Apr 26 2023, 1:36 AM

Arlolra added a project: Content-Transform-Team-WIP.Apr 26 2023, 1:36 AM

Arlolra moved this task from Backlog to In Progress on the Content-Transform-Team-WIP board.Apr 26 2023, 1:38 AM

Arlolra moved this task from In Progress to Code Review on the Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure) board.Apr 27 2023, 9:47 PM

Arlolra moved this task from In Progress to Code Review on the Content-Transform-Team-WIP board.

Change 911957 merged by jenkins-bot:

[mediawiki/extensions/ImageMap@master] Add back description links when !$wgParserEnableLegacyMediaDOM

https://gerrit.wikimedia.org/r/911957

Maintenance_bot removed a project: Patch-For-Review.May 25 2023, 4:30 PM

Arlolra moved this task from Code Review to To Deploy on the Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure) board.May 25 2023, 4:59 PM

Arlolra moved this task from Code Review to To Deploy on the Content-Transform-Team-WIP board.

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.11; 2023-05-30).May 25 2023, 5:00 PM

Change 923698 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Port changes to add description links

https://gerrit.wikimedia.org/r/923698

gerritbot added a project: Patch-For-Review.May 26 2023, 8:37 PM

Change 923698 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Port changes to add description links

https://gerrit.wikimedia.org/r/923698

Maintenance_bot removed a project: Patch-For-Review.May 27 2023, 4:11 AM

Arlolra moved this task from To Deploy to To Verify on the Parsoid-Read-Views (Phase 0 - Parsoid-Media-Structure) board.May 31 2023, 12:17 AM

Arlolra moved this task from To Deploy to To Verify on the Content-Transform-Team-WIP board.

Change 925005 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/ImageMap@master] Fix description link icon positioning

https://gerrit.wikimedia.org/r/925005

gerritbot added a project: Patch-For-Review.May 31 2023, 7:12 PM

Change 925007 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/ImageMap@wmf/1.41.0-wmf.11] Fix description link icon positioning

https://gerrit.wikimedia.org/r/925007

Change 925005 merged by jenkins-bot:

[mediawiki/extensions/ImageMap@master] Fix description link icon positioning

https://gerrit.wikimedia.org/r/925005

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.12; 2023-06-06); removed MW-1.41-notes (1.41.0-wmf.11; 2023-05-30).May 31 2023, 8:00 PM

Change 925007 merged by jenkins-bot:

[mediawiki/extensions/ImageMap@wmf/1.41.0-wmf.11] Fix description link icon positioning

https://gerrit.wikimedia.org/r/925007

Mentioned in SAL (#wikimedia-operations) [2023-05-31T20:27:12Z] <urbanecm@deploy1002> Started scap: Backport for [[gerrit:925007|Fix description link icon positioning (T329364)]]

Mentioned in SAL (#wikimedia-operations) [2023-05-31T20:28:56Z] <urbanecm@deploy1002> arlolra and urbanecm: Backport for [[gerrit:925007|Fix description link icon positioning (T329364)]] synced to the testservers: mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet

Maintenance_bot removed a project: Patch-For-Review.May 31 2023, 8:30 PM

Mentioned in SAL (#wikimedia-operations) [2023-05-31T20:40:04Z] <urbanecm@deploy1002> Finished scap: Backport for [[gerrit:925007|Fix description link icon positioning (T329364)]] (duration: 12m 51s)