Maniphest T329466

Add Phan to Cargo
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	TK-999
	Feb 12 2023, 9:32 PM

Tags

Referenced Files

None

Subscribers

Description

rECRG3d876fcf74275d0230b8af4cb5c43bc27658a880 caused an unfortunate regression due to an out-of-scope attempt to access a protected property. Phan has been used as a static analysis tool for MediaWiki and many of its extensions for a few years now, and it's fairly capable of catching such trivial problems as well as some more complex issues.

Let's integrate Phan with Cargo to try and take advantage of that.

Details

	Subject	Repo	Branch	Lines +/-
	Enable and fix PhanNonClassMethodCall check	mediawiki/extensions/Cargo	master	+6 -4
	Enable and fix PhanDeprecatedPartiallySupportedCallable check	mediawiki/extensions/Cargo	master	+3 -12
	Enable and fix PhanUndeclaredMethod check	mediawiki/extensions/Cargo	master	+102 -19
	Enable and fix PhanUndeclaredProperty check	mediawiki/extensions/Cargo	master	+15 -6
	Add Phan configuration	mediawiki/extensions/Cargo	master	+60 -2

Customize query in gerrit

Related Objects

Mentioned Here: rECRG3d876fcf7427: Fix some PHP 8.0/8.2 deprecations

Event Timeline

TK-999 created this task.Feb 12 2023, 9:32 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 12 2023, 9:32 PM

Change 888346 had a related patch set uploaded (by TK-999; author: TK-999):

[mediawiki/extensions/Cargo@master] Add Phan configuration

https://gerrit.wikimedia.org/r/888346

gerritbot added a project: Patch-For-Review.Feb 12 2023, 9:33 PM

Change 888346 merged by jenkins-bot:

[mediawiki/extensions/Cargo@master] Add Phan configuration

https://gerrit.wikimedia.org/r/888346

Maintenance_bot removed a project: Patch-For-Review.Feb 13 2023, 8:10 PM

Change 890017 had a related patch set uploaded (by TK-999; author: TK-999):

[mediawiki/extensions/Cargo@master] Enable and fix PhanUndeclaredProperty check

https://gerrit.wikimedia.org/r/890017

gerritbot added a project: Patch-For-Review.Feb 17 2023, 8:15 PM

Change 890017 merged by jenkins-bot:

[mediawiki/extensions/Cargo@master] Enable and fix PhanUndeclaredProperty check

https://gerrit.wikimedia.org/r/890017

Maintenance_bot removed a project: Patch-For-Review.Feb 17 2023, 9:10 PM

Change 890155 had a related patch set uploaded (by TK-999; author: TK-999):

[mediawiki/extensions/Cargo@master] Enable and fix PhanUndeclaredMethod check

https://gerrit.wikimedia.org/r/890155

gerritbot added a project: Patch-For-Review.Feb 18 2023, 12:41 PM

Change 890157 had a related patch set uploaded (by TK-999; author: TK-999):

[mediawiki/extensions/Cargo@master] Enable and fix PhanDeprecatedPartiallySupportedCallable check

https://gerrit.wikimedia.org/r/890157

Change 890159 had a related patch set uploaded (by TK-999; author: TK-999):

[mediawiki/extensions/Cargo@master] Enable and fix PhanNonClassMethodCall check

https://gerrit.wikimedia.org/r/890159

Change 890157 merged by jenkins-bot:

[mediawiki/extensions/Cargo@master] Enable and fix PhanDeprecatedPartiallySupportedCallable check

https://gerrit.wikimedia.org/r/890157

Change 890159 merged by jenkins-bot:

[mediawiki/extensions/Cargo@master] Enable and fix PhanNonClassMethodCall check

https://gerrit.wikimedia.org/r/890159

I would say this is done now! @TK-999 - thank you for all your work on adding Phan support.