Page MenuHomePhabricator
Create Task
Maniphest T330503

Regression: "New user message" notification is never shown on MonoBook, CologneBlue
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Edit any user's talk page on a wiki without Echo
  • Or edit an anonymous user's talk page on a wiki with MonoBook as the default skin

What happens?:
There is no "New user message" notification shown to the user.

What should have happened instead?:
The "New user message" notification should be displayed.

Software version (skip for WMF-hosted wikis like Wikipedia): Observed on 1.38 branch

Details

SubjectRepoBranchLines +/-
Re-add support for "New user message" notificationmediawiki/skins/CologneBlueREL1_38+1 -3
Re-add support for "New user message" notificationmediawiki/skins/CologneBlueREL1_39+1 -3
Re-add support for "New user message" notificationmediawiki/skins/CologneBluemaster+1 -3
Re-add support for "New user message" notificationmediawiki/skins/MonoBookREL1_38+1 -1
Re-add support for "New user message" notificationmediawiki/skins/MonoBookREL1_39+1 -1
Re-add support for "New user message" notificationmediawiki/skins/MonoBookmaster+1 -1
Customize query in gerrit

Event Timeline

Porplemontage created this task.Feb 24 2023, 1:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 24 2023, 1:57 PM
gerritbot added a comment.Feb 24 2023, 2:00 PM

Change 891633 had a related patch set uploaded (by Porplemontage; author: Porplemontage):

[mediawiki/skins/MonoBook@master] Re-add support for "New user message" notification

https://gerrit.wikimedia.org/r/891633

gerritbot added a project: Patch-For-Review.Feb 24 2023, 2:00 PM
Porplemontage renamed this task from Regression: "New user message" notification is never shown to Regression: "New user message" notification is never shown on MonoBook.Feb 24 2023, 2:12 PM
gerritbot added a comment.Feb 24 2023, 5:16 PM

Change 891633 merged by jenkins-bot:

[mediawiki/skins/MonoBook@master] Re-add support for "New user message" notification

https://gerrit.wikimedia.org/r/891633

Maintenance_bot removed a project: Patch-For-Review.Feb 24 2023, 5:30 PM
ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.25; 2023-02-27).Feb 24 2023, 6:00 PM
matmarex added projects: CologneBlue, Vector (legacy skin), Desktop Improvements (Vector 2022).Feb 25 2023, 9:06 PM
matmarex subscribed.

It looks like the bug is also present in CologneBlue, and some documentation in Vector (but not the code) is also wrong. https://codesearch-beta.wmcloud.org/search/?q=html-newtalk

gerritbot added a comment.Feb 25 2023, 9:12 PM

Change 891970 had a related patch set uploaded (by Legoktm; author: Porplemontage):

[mediawiki/skins/MonoBook@REL1_39] Re-add support for "New user message" notification

https://gerrit.wikimedia.org/r/891970

gerritbot added a project: Patch-For-Review.Feb 25 2023, 9:12 PM

Change 891971 had a related patch set uploaded (by Legoktm; author: Porplemontage):

[mediawiki/skins/MonoBook@REL1_38] Re-add support for "New user message" notification

https://gerrit.wikimedia.org/r/891971

gerritbot added a comment.Feb 25 2023, 9:14 PM

Change 891970 merged by jenkins-bot:

[mediawiki/skins/MonoBook@REL1_39] Re-add support for "New user message" notification

https://gerrit.wikimedia.org/r/891970

gerritbot added a comment.Feb 25 2023, 9:14 PM

Change 891971 merged by jenkins-bot:

[mediawiki/skins/MonoBook@REL1_38] Re-add support for "New user message" notification

https://gerrit.wikimedia.org/r/891971

Maintenance_bot removed a project: Patch-For-Review.Feb 25 2023, 9:30 PM
gerritbot added a comment.Mar 4 2023, 4:21 PM

Change 894166 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/CologneBlue@master] Re-add support for "New user message" notification

https://gerrit.wikimedia.org/r/894166

gerritbot added a project: Patch-For-Review.Mar 4 2023, 4:21 PM
matmarex renamed this task from Regression: "New user message" notification is never shown on MonoBook to Regression: "New user message" notification is never shown on MonoBook, CologneBlue.Mar 4 2023, 4:22 PM
matmarex removed projects: Desktop Improvements (Vector 2022), Vector (legacy skin).
gerritbot added a comment.Mar 4 2023, 9:04 PM

Change 894166 merged by jenkins-bot:

[mediawiki/skins/CologneBlue@master] Re-add support for "New user message" notification

https://gerrit.wikimedia.org/r/894166

Maintenance_bot removed a project: Patch-For-Review.Mar 4 2023, 9:10 PM
ReleaseTaggerBot edited projects, added MW-1.40-notes (1.40.0-wmf.26; 2023-03-06); removed MW-1.40-notes (1.40.0-wmf.25; 2023-02-27).Mar 4 2023, 10:00 PM
gerritbot added a comment.Mar 5 2023, 7:08 PM

Change 894192 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/CologneBlue@REL1_39] Re-add support for "New user message" notification

https://gerrit.wikimedia.org/r/894192

gerritbot added a project: Patch-For-Review.Mar 5 2023, 7:08 PM

Change 894193 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/skins/CologneBlue@REL1_38] Re-add support for "New user message" notification

https://gerrit.wikimedia.org/r/894193

gerritbot added a comment.Mar 5 2023, 7:10 PM

Change 894192 merged by jenkins-bot:

[mediawiki/skins/CologneBlue@REL1_39] Re-add support for "New user message" notification

https://gerrit.wikimedia.org/r/894192

gerritbot added a comment.Mar 5 2023, 7:10 PM

Change 894193 merged by jenkins-bot:

[mediawiki/skins/CologneBlue@REL1_38] Re-add support for "New user message" notification

https://gerrit.wikimedia.org/r/894193

matmarex closed this task as Resolved.Mar 5 2023, 7:21 PM
matmarex assigned this task to Porplemontage.

Thanks for reporting the problem!

Maintenance_bot removed a project: Patch-For-Review.Mar 5 2023, 7:31 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits