Maniphest T330529

htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated (via SpecialEditTags)
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

Go to Special:Log
Select "edit tags of selected log entries"

What happens?:

Deprecated:  htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in includes\parser\Sanitizer.php on line 859

from includes\parser\Sanitizer.php(859)
#0 includes\xml\Xml.php(76): Sanitizer::encodeAttribute(NULL)
#1 includes\xml\Xml.php(49): Xml::expandAttributes(array)
#2 includes\xml\Xml.php(292): Xml::element(string, array)
#3 includes\specials\SpecialEditTags.php(278): Xml::input(string, integer, NULL, array)

What should have happened instead?:
No deprecation message should be shown

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

	Subject	Repo	Branch	Lines +/-
	SpecialEditTags: Set default of '' for wpReason	mediawiki/core	REL1_38	+1 -1
	SpecialEditTags: Set default of '' for wpReason	mediawiki/core	REL1_35	+2 -1
	SpecialEditTags: Set default of '' for wpReason	mediawiki/core	REL1_39	+1 -1
	SpecialEditTags: Set default of '' for wpReason	mediawiki/core	master	+1 -1

Customize query in gerrit

Event Timeline

Umherirrender created this task.Feb 24 2023, 8:33 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 24 2023, 8:33 PM

Change 891931 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] SpecialEditTags: Set default of '' for wpReason

https://gerrit.wikimedia.org/r/891931

gerritbot added a project: Patch-For-Review.Feb 25 2023, 12:31 AM

Reedy moved this task from Backlog to MediaWiki core on the PHP 8.1 support board.Feb 25 2023, 12:49 AM

Reedy moved this task from Backlog to MediaWiki core on the PHP 8.2 support board.

Change 891931 merged by jenkins-bot:

[mediawiki/core@master] SpecialEditTags: Set default of '' for wpReason

https://gerrit.wikimedia.org/r/891931

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.25; 2023-02-27).Feb 25 2023, 9:00 AM

Maintenance_bot removed a project: Patch-For-Review.Feb 25 2023, 9:10 AM

Change 891639 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_39] SpecialEditTags: Set default of '' for wpReason

https://gerrit.wikimedia.org/r/891639

Change 891640 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_38] SpecialEditTags: Set default of '' for wpReason

https://gerrit.wikimedia.org/r/891640

Change 891641 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_35] SpecialEditTags: Set default of '' for wpReason

https://gerrit.wikimedia.org/r/891641

Change 891641 merged by jenkins-bot:

[mediawiki/core@REL1_35] SpecialEditTags: Set default of '' for wpReason

https://gerrit.wikimedia.org/r/891641

Change 891639 merged by jenkins-bot:

[mediawiki/core@REL1_39] SpecialEditTags: Set default of '' for wpReason

https://gerrit.wikimedia.org/r/891639

Change 891640 merged by jenkins-bot:

[mediawiki/core@REL1_38] SpecialEditTags: Set default of '' for wpReason

https://gerrit.wikimedia.org/r/891640

Maintenance_bot removed a project: Patch-For-Review.Feb 25 2023, 1:30 PM

ReleaseTaggerBot added projects: MW-1.38-notes, MW-1.35-notes, MW-1.39-notes.Feb 25 2023, 2:00 PM

Reedy closed this task as Resolved.Feb 25 2023, 6:32 PM

Reedy claimed this task.