Page MenuHomePhabricator
Create Task
Maniphest T331708

Remove deprecated Language::commafy and mw.language.commafy
Open, Needs TriagePublic
Actions

Description

The PHP function Language::commafy and the JavaScript function mw.language.commafy are deprecated since rMW4bc5c761296d: Hard deprecate Language::commafy; deprecate mediawiki.language.commafy included MW 1.36.

According https://codesearch.wmcloud.org/search/?q=commafy there is no usage except the test cases.
According to https://global-search.toolforge.org/?q=commafy&namespaces=2%2C4%2C8&title=%28Gadgets-definition%7C.*%5C.%28js%7Ccss%7Cjson%29%29 there is only an usage in https://www.wikidata.org/wiki/User:Bamyers99/UnitsConverter.js which was replaced incomplete.

Details

SubjectRepoBranchLines +/-
Remove deprecated Language::commafy and mw.language.commafymediawiki/coremaster+2 -105
Customize query in gerrit

Related Objects

Event Timeline

Fomafix created this task.Mar 10 2023, 9:47 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 10 2023, 9:47 AM
gerritbot added a comment.Mar 10 2023, 9:48 AM

Change 896308 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/core@master] Remove mw.language.commafy

https://gerrit.wikimedia.org/r/896308

gerritbot added a project: Patch-For-Review.Mar 10 2023, 9:48 AM
Aklapper added projects: Technical-Debt, MediaWiki-Internationalization.Mar 10 2023, 12:50 PM
Fomafix renamed this task from Remove mw.language.commafy to Remove deprecated Language::commafy and mw.language.commafy.Mar 10 2023, 3:20 PM
Fomafix updated the task description. (Show Details)
gerritbot added a comment.Mar 10 2023, 4:56 PM

Change 896308 merged by jenkins-bot:

[mediawiki/core@master] Remove deprecated Language::commafy and mw.language.commafy

https://gerrit.wikimedia.org/r/896308

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.27; 2023-03-13).Mar 10 2023, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 10 2023, 5:10 PM
Krinkle awarded a token.Mar 10 2023, 8:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits