- Cleanup the linter report code to no longer get tag and template info from the params field.
- Cleanup recordLintJob code to no longer record tag and template data in the params field but allow other info to be stored there. Do not attempt to delete existing tag and template data from the params field, just allow it to go away as lint records are replaced and deleted.
Description
Description
Details
Details
Related Objects
Related Objects
Event Timeline
Comment Actions
Researched the use of linter_params for the tag and template data, versus getting those fields directly from the new linter_template and linter_tag columns.
LinterErrorsPager fillQueryBuilder requests the original set of columns but does not use the configuration value "LinterUserInterfaceTagAndTemplateStage" to choose the new columns for template and tag values for each row.
When the removal of the four configuration values in extension,json are removed and the dual mode code is refactored
to assume linter_namespace, linter_template and linter_tag are all present in the linter table and are being written and
the maintenance scripts have been run to do the migration to populate those columns, then the use of the new columns
in the fillQueryBuilder will make more sense to use.
Also researched the ongoing storing of tag and template JSON data in the params column instead of filtering them
out when writing those fields to the new linter_template and linter_tag columns. Again, the removal of dual mode code
and those configuration values should precede this change as well.
Need to consult with the team as to whether the removal of dual mode code is appropriate now that a new WMF release is
done.
Comment Actions
Change #1038426 had a related patch set uploaded (by Sbailey; author: Sbailey):
[mediawiki/extensions/Linter@master] WIP removing linter config and dual mode code for new namespace field
Comment Actions
Change #1038905 had a related patch set uploaded (by Sbailey; author: Sbailey):
[mediawiki/extensions/Linter@master] WIP remove linter tag and template dual mode config and code
This comment was removed by Sbailey.
Comment Actions
Change #1038426 had a related patch set uploaded (by Sbailey; author: Sbailey):
[mediawiki/extensions/Linter@master] WIP remove linter namespace field dual mode config and code
Comment Actions
Change #1038905 had a related patch set uploaded (by Sbailey; author: Sbailey):
[mediawiki/extensions/Linter@master] Remove linter tag and template dual mode config and code
Comment Actions
Change #1038426 merged by jenkins-bot:
[mediawiki/extensions/Linter@master] Remove linter namespace field dual mode config and code
Comment Actions
Change #1038905 merged by jenkins-bot:
[mediawiki/extensions/Linter@master] Remove linter tag and template dual mode config and code