Page MenuHomePhabricator

Sbailey (Sbailey)
User

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 4 2017, 8:49 PM (247 w, 1 d)
Availability
Available
LDAP User
Sbailey
MediaWiki User
SBailey (WMF) [ Global Accounts ]

Recent Activity

Tue, Jun 21

Sbailey closed T177547: Add search support for linter errors as Resolved.

Implemented in:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Linter/+/769772

Tue, Jun 21, 10:01 PM · Discovery-Search, Discovery, MediaWiki-extensions-Linter
Sbailey closed T185685: Linter extension should allow search results to be limited by a prefix: or titlepart . as Resolved.

Implemented in:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Linter/+/769772

Tue, Jun 21, 10:00 PM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), MW-1.38-notes (1.38.0-wmf.26; 2022-03-14), MediaWiki-extensions-Linter
Sbailey closed T298343: Similar pages on it.wv and it.wp or en:wv do not have the same lint errors as Resolved.

Arlo added 'proofread-page' as an additional lintable content model in:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Linter/+/766195

Tue, Jun 21, 9:50 PM · MW-1.38-notes (1.38.0-wmf.24; 2022-02-28), MediaWiki-extensions-Linter
Sbailey closed T151362: Linter: Display lint errors for a single page as Resolved.

Search for a specific page implemented in:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Linter/+/769772
Ability to display all lint errors in a single page provided by LintHint.

Tue, Jun 21, 9:43 PM · MW-1.38-notes (1.38.0-wmf.17; 2022-01-10), MediaWiki-extensions-Linter

Apr 12 2022

Sbailey added a comment to T151362: Linter: Display lint errors for a single page.

I researched what it would take for a "stock" wikimedia install to provide a subset of the features of LintHint (all lint errors on a single page highlighted, possibly with mouse roll over category display in a popup bubble. The default editor in OOUI would need significant enhancements outside the scope of the project to provide a display of all lints for a single page like LintHint can already do. I looked into the VE wikitext editor and the alternative syntax highlighting editor available as a Beta feature when VE is installed. My goals recently are better search narrowing functionality and not to replace LintHint, or to provide all lint errors on a single page as highlighted regions. All lints for a single page is what LintHint provides with a very attractive UI, as a list of all errors in one pane as clickable links that jump to a highlighted text region. My goals have been to offer better stock search capabilities and the next patch in this group is a search box from the special lint page bottom that allows the editor to specify a title prefix and get all pages with any category lint error that matches the partial title prefix. This allows editors that have created a directory tree structure for all their pages in the title, can search for only those pages. For editors that want a more advanced all lints on a single page, LintHint is not too hard to enable for wikis with VE enabled.

Apr 12 2022, 6:50 PM · MW-1.38-notes (1.38.0-wmf.17; 2022-01-10), MediaWiki-extensions-Linter

Mar 4 2022

Sbailey claimed T185685: Linter extension should allow search results to be limited by a prefix: or titlepart ..

It looks like at least searching and reporting by namespace, by category, by a title prefix is possible (database performance impacts are what gate what is safe to implement, not whether a feature technically can be implemented). Search by prefix, by namespace, for all categories also maybe possible, and be added to the report type provided for all lints for a single page. Would be good to get feedback on whether that is also a useful search/report type. But for now I will focus on prefix, namespace and category as search criteria report.

Mar 4 2022, 2:59 PM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), MW-1.38-notes (1.38.0-wmf.26; 2022-03-14), MediaWiki-extensions-Linter

Mar 3 2022

Sbailey added a comment to T151362: Linter: Display lint errors for a single page.

I added a brief description of the new feature "Show all linter errors for a specific page" in the help page for linter. Due to this page being translated, the guidance is to keep changes brief, but hopefully I have covered its use, caveat of syntax highlighting interfering with its highlighting, and how to work from bottom up to avoid changing character offsets.
If you feel I need to add something more, let me know.
Again thanks for your care and comments.

Mar 3 2022, 8:28 PM · MW-1.38-notes (1.38.0-wmf.17; 2022-01-10), MediaWiki-extensions-Linter

Mar 2 2022

Sbailey claimed T245492: Slow query: IndexPager::buildQueryInfo (MediaWiki\Linter\LintErrorsPager).

The new namespace column may allow the query optimizer to improve this performance significantly.

Mar 2 2022, 5:54 PM · DBA, mariadb-optimizer-bug, MediaWiki-extensions-Linter, Performance Issue
Sbailey added a comment to T151362: Linter: Display lint errors for a single page.

Jonesey95 and Izno,
Thanks for your care and comments. The new all lints for a single page is located at the bottom of the special lints page and takes a page titles such as "User:Delta40" and returns all lints for that page in a list which allows you to use the edit button to take you to the highlighted area of the page wikitext source. To edit a bunch of errors on a single page, I suggest editing the last error first so that any insertion or deletion of characters happens below where other errors are still present, before Parsoid regenerates the linter error list (due to caching and timeouts, etc.). This feature was added so we have a native implementation that is similar to LintHint, but requires no special efforts on the editors part to setup and use LintHint. LintHint can also add more features that we arn't able to add for various reasons.
I'll look at where in the doc I should add some info about this new feature.

Mar 2 2022, 3:45 PM · MW-1.38-notes (1.38.0-wmf.17; 2022-01-10), MediaWiki-extensions-Linter

Mar 1 2022

Sbailey placed T207032: Lint away 'pxpx' up for grabs.
Mar 1 2022, 8:12 PM · Parsoid
Sbailey added a comment to T151362: Linter: Display lint errors for a single page.

Is the newish "Show all linter errors for a specific page" feature helping and providing most of what this ticket was requesting?
Other selection features are in the works (waiting on new fields being added to the linter table) such as namespace and template and tag allowing further narrowing of search results.

Mar 1 2022, 8:11 PM · MW-1.38-notes (1.38.0-wmf.17; 2022-01-10), MediaWiki-extensions-Linter
Sbailey added a comment to T165538: Need a mechanism / process to purge invalid / stale entries from the Linter database.

Two tasks address some of these stale linter data issues:
Delete lint error records when content model changes from wikitext
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Linter/+/761070
and
Delete lint errors when blank page saved... (the title of this ticket implies content model change also needed but only requirement is saving a blank page regardless of content model.
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Linter/+/766872

Mar 1 2022, 7:21 PM · MediaWiki-extensions-Linter
Sbailey placed T280193: ContentHandler::getChangeType is limited to a single type per edit, ignoring content model changes up for grabs.
Mar 1 2022, 3:32 PM · MW-1.38-notes (1.38.0-wmf.24; 2022-02-28), Patch-For-Review, MediaWiki-Page-editing, User-DannyS712, MediaWiki-ContentHandler

Feb 28 2022

Sbailey claimed T280193: ContentHandler::getChangeType is limited to a single type per edit, ignoring content model changes.

Lint errors are now being deleted during save of a blank page while the content model is being changed.
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Linter/+/766872

Feb 28 2022, 10:53 PM · MW-1.38-notes (1.38.0-wmf.24; 2022-02-28), Patch-For-Review, MediaWiki-Page-editing, User-DannyS712, MediaWiki-ContentHandler

Feb 7 2022

Sbailey placed T233252: Need to write more tests for LinkHandlerUtils.php figureHandler to add coverage up for grabs.
Feb 7 2022, 7:25 PM · Parsoid
Sbailey claimed T298343: Similar pages on it.wv and it.wp or en:wv do not have the same lint errors.
Feb 7 2022, 7:16 PM · MW-1.38-notes (1.38.0-wmf.24; 2022-02-28), MediaWiki-extensions-Linter

Feb 4 2022

Sbailey created T300992: Add linter_template and linter_tag columns to the Linter table.
Feb 4 2022, 5:30 PM · User-Ladsgroup, DBA, Schema-change-in-production, MediaWiki-extensions-Linter

Jan 28 2022

Sbailey added a project to T300402: Add namespace column to Linter table: Schema-change-in-production.
Jan 28 2022, 8:48 PM · MediaWiki-extensions-Linter, DBA, Schema-change-in-production
Sbailey created T300402: Add namespace column to Linter table.
Jan 28 2022, 8:46 PM · MediaWiki-extensions-Linter, DBA, Schema-change-in-production

Jan 22 2022

Sbailey added a comment to T299612: Add namespace column and index to table.

So in the process of creating a set of patches that add a column for part 1, start populating the new column when new records are written in part 2, will do a full pass through existing records migrating data derived form data in another column to populate the new column completely in part 3, then add code to utilize the new column for search/reporting in part 4, then do a complete refactor of old and new code, removing old code and moving new code around as needed and removing config variable enablements, etc.

Jan 22 2022, 12:02 AM · MW-1.38-notes (1.38.0-wmf.20; 2022-01-31), Patch-For-Review, Documentation

Jan 20 2022

Sbailey added a comment to T299612: Add namespace column and index to table.

It was unintentional, sorry about that,

Jan 20 2022, 4:07 PM · MW-1.38-notes (1.38.0-wmf.20; 2022-01-31), Patch-For-Review, Documentation
Sbailey removed a project from T299612: Add namespace column and index to table: ContentTranslation.
Jan 20 2022, 4:06 PM · MW-1.38-notes (1.38.0-wmf.20; 2022-01-31), Patch-For-Review, Documentation
Sbailey updated the task description for T299612: Add namespace column and index to table.
Jan 20 2022, 12:34 AM · MW-1.38-notes (1.38.0-wmf.20; 2022-01-31), Patch-For-Review, Documentation

Jan 19 2022

Sbailey created T299612: Add namespace column and index to table.
Jan 19 2022, 11:11 PM · MW-1.38-notes (1.38.0-wmf.20; 2022-01-31), Patch-For-Review, Documentation

Jan 7 2022

Sbailey claimed T298782: Linter seems to be not cleaning up after page deletion.

I will look into this as I already have attempted to improve the error count results and this continues that effort in:
https://phabricator.wikimedia.org/T194872

Jan 7 2022, 5:44 PM · MediaWiki-extensions-Linter, Data-Persistence (Consultation)

Sep 30 2021

Sbailey claimed T151362: Linter: Display lint errors for a single page.
Sep 30 2021, 9:21 PM · MW-1.38-notes (1.38.0-wmf.17; 2022-01-10), MediaWiki-extensions-Linter

Sep 21 2021

Sbailey created T291513: Review schema changes for T175177.
Sep 21 2021, 6:55 PM · Data-Persistence (Consultation), MediaWiki-extensions-Linter

Aug 11 2021

Sbailey committed rELINTcc2e08546be6: Fix broken RecordLintJobTest (authored by Sbailey).
Fix broken RecordLintJobTest
Aug 11 2021, 11:12 PM

Jun 11 2021

Sbailey claimed T225337: Unbreak RecordLintJobTest.

I believe I have a fix for this and want this fix done prior to adding additional tests to RecordListJobTest.php
The issue appears to be that RecordLintJob.php run() checks the revision and then delays the job run which in a production environment is a good idea, but not for this test, so I removed the revision property. I also set the pageID to 0 instead of 1 as that seems to be a new default allowing the test to find the inserted lint error appropriately.

Jun 11 2021, 5:40 PM · MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Regression, MediaWiki-extensions-Linter

May 26 2021

Sbailey closed T162983: Parsoid linter shows rest of page as error when unbalanced brackets exists as Resolved.

The Linter error no longer is generated in this case, so the issue of error running to end of page is resolved.
A new phab ticket covering broken use of Wikilink with unclosed ]] might be worth creating as a low priority.

May 26 2021, 8:23 PM · Parsoid, Parsoid-Tokenizer, MediaWiki-extensions-Linter

May 25 2021

Sbailey claimed T162983: Parsoid linter shows rest of page as error when unbalanced brackets exists.
May 25 2021, 5:24 PM · Parsoid, Parsoid-Tokenizer, MediaWiki-extensions-Linter

Apr 30 2021

Sbailey claimed T170313: Linter count not updated on deleted page.

Exploring why Linter error counts are still incorrect after a page is deleted.

Apr 30 2021, 6:46 PM · MW-1.38-notes (1.38.0-wmf.17; 2022-01-10), MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), WMSE-Bug-Reporting-and-Translation-2017, MediaWiki-extensions-Linter

Apr 27 2021

Sbailey updated the task description for T194872: Linter : have correct counters for categories populated with only a few errors (or none).
Apr 27 2021, 7:41 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), MediaWiki-extensions-Linter
Sbailey updated the task description for T194872: Linter : have correct counters for categories populated with only a few errors (or none).
Apr 27 2021, 7:40 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), MediaWiki-extensions-Linter
Sbailey added a comment to T194872: Linter : have correct counters for categories populated with only a few errors (or none).

So gerrit patch 677673 modifies the code which generates estimated linter error counts for a category to produce an accurate count when the actual count in the database is less than (20) or whatever MAX_ACCURATE_COUNT is set to in Database.php in the Linter extension directory. While this change will help produce more accurate counts, other issues of when the object cache gets refreshed still apply as does errors that become stale when a page with errors is deleted, prior to a full refresh of the Linter errors from all active pages is performed. Still this should provide better counts in most circumstances.
I am not going to close this ticket as resolved, until a more complete solution is implemented that has fewer caveats.

Apr 27 2021, 7:38 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), MediaWiki-extensions-Linter
Sbailey committed rELINT201b47e01d38: Make Linter category counts more accurate when counts are low (authored by Sbailey).
Make Linter category counts more accurate when counts are low
Apr 27 2021, 6:00 PM

Mar 15 2021

Sbailey claimed T194872: Linter : have correct counters for categories populated with only a few errors (or none).
Mar 15 2021, 10:12 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), MediaWiki-extensions-Linter

Mar 10 2021

Sbailey moved T165538: Need a mechanism / process to purge invalid / stale entries from the Linter database from Backlog to Linter-UI on the MediaWiki-extensions-Linter board.
Mar 10 2021, 10:09 PM · MediaWiki-extensions-Linter

Mar 5 2021

Sbailey moved T246403: Lint error counts on "Page information" page do not update, even with null edit from Backlog to Linter-UI on the MediaWiki-extensions-Linter board.
Mar 5 2021, 8:57 PM · MediaWiki-extensions-Linter
Sbailey moved T171788: On wikis without changeprop enabled, lint errors don't update after page edits from Backlog to Linter-UI on the MediaWiki-extensions-Linter board.
Mar 5 2021, 6:59 PM · Parsoid (Tracking), Platform Team Legacy (Designing), Services (designing), wikitech.wikimedia.org, MediaWiki-extensions-Linter

Feb 25 2021

Sbailey closed T248369: Add linting rule for detecting presence of image wikitext in extlinks as Resolved.
Feb 25 2021, 11:01 PM · MediaWiki-extensions-Linter, Parsoid

Feb 22 2021

Sbailey placed T275415: Content duplicated when editing when a block template is used in a wikilink up for grabs.
Feb 22 2021, 8:27 PM · DiscussionTools, Parsoid
Sbailey added a comment to T275415: Content duplicated when editing when a block template is used in a wikilink.

Subbu wrote in IRC:

Feb 22 2021, 8:26 PM · DiscussionTools, Parsoid
Sbailey claimed T275415: Content duplicated when editing when a block template is used in a wikilink.
Feb 22 2021, 5:55 PM · DiscussionTools, Parsoid

Feb 19 2021

Sbailey closed T215999: Linter does not detect invalid "500px500px" as a bogus file option as Resolved.

Fixed by patches:

https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/661820

which addresses bogus width options, and

https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/665226

which addresses duplicate width options.

Feb 19 2021, 7:57 PM · Parsoid, MediaWiki-extensions-Linter

Feb 18 2021

Sbailey added a comment to T275074: Gallery does not allow lowercase "center" "left" or "right" as a caption for a gallery image.

Jonesey, this is a bug, and it will be fixed, not put off for years. It was
just more than a Linter bug, which is what I am focussing on, and after
debugging it, I determined that the problem occurs fairly early in the
parsing stages far removed from the Linter and is going to be tricky to
fix. I confirmed with my team mates that we will not deem this an annoying
quirk that we ignore, but fixing it was outside the scope of my current
tasks. I'll keep an eye on this task. Thanks for the additional insight as
to how editors might use Center more often than one might imagine.
Best,
Shannon

Feb 18 2021, 11:18 PM · Parsoid
Sbailey placed T266406: Linter false positive: "Center/Left/Right" as caption for gallery image up for grabs.
Feb 18 2021, 8:40 PM · Parsoid, MediaWiki-extensions-Linter
Sbailey updated the task description for T266406: Linter false positive: "Center/Left/Right" as caption for gallery image.
Feb 18 2021, 8:37 PM · Parsoid, MediaWiki-extensions-Linter

Feb 17 2021

Sbailey created T275074: Gallery does not allow lowercase "center" "left" or "right" as a caption for a gallery image.
Feb 17 2021, 8:09 PM · Parsoid

Feb 11 2021

Sbailey added a comment to T266406: Linter false positive: "Center/Left/Right" as caption for gallery image.

Notes: If looks like the use of left, right or center as caption words not only generates linter errors, the captions are not there, as the words have been eaten as options and not allowed to be captions. In looking at this further, the use of left, right or center in gallary seems not to be valid as an option, and so should be allowed as captions. In the following example,

<gallery>
File:Foobar.jpg|left
File:Foobar.jpg|notaleft
</gallery>

produces linter error:

{"type":"bogus-image-options","dsr":[0,66,9,10],"params":{"items":["left"]}}

and renders as:

... class="gallerytext" data-parsoid="{}"></div></li>
... class="gallerytext" data-parsoid='{"dsr":[47,55,0,0]}'>notaleft</div></li>
Feb 11 2021, 11:22 PM · Parsoid, MediaWiki-extensions-Linter

Feb 4 2021

Sbailey claimed T266406: Linter false positive: "Center/Left/Right" as caption for gallery image.
Feb 4 2021, 9:22 PM · Parsoid, MediaWiki-extensions-Linter
Sbailey claimed T264464: Conflicting border/thumb/frame options are not detected as Linter errors.
Feb 4 2021, 9:22 PM · MediaWiki-extensions-Linter
Sbailey claimed T207032: Lint away 'pxpx'.

This appears to be related to T215999
Linter does not detect invalid "500px500px" as a bogus file option

Feb 4 2021, 9:15 PM · Parsoid
Sbailey closed T242068: Linter does not detect link-in-link when wikilink is wrapped in italics as Resolved.
Feb 4 2021, 8:14 PM · Parsoid, MediaWiki-extensions-Linter

Jan 27 2021

Sbailey claimed T215999: Linter does not detect invalid "500px500px" as a bogus file option.
Jan 27 2021, 6:43 PM · Parsoid, MediaWiki-extensions-Linter
Sbailey claimed T248369: Add linting rule for detecting presence of image wikitext in extlinks.
Jan 27 2021, 6:40 PM · MediaWiki-extensions-Linter, Parsoid
Sbailey claimed T242068: Linter does not detect link-in-link when wikilink is wrapped in italics.
Jan 27 2021, 6:40 PM · Parsoid, MediaWiki-extensions-Linter

Jan 22 2021

Sbailey placed T267059: Spec for precisely positioned, localized error message in Parsoid up for grabs.
Jan 22 2021, 8:42 PM · Parsoid-Rendering, Parsoid

Jan 21 2021

Sbailey claimed T267059: Spec for precisely positioned, localized error message in Parsoid.
Jan 21 2021, 10:26 PM · Parsoid-Rendering, Parsoid

Jan 20 2021

Sbailey closed T272097: Parsoid Cite doesn't know about special group names like "lower-alpha" etc. and treats them like other group names like "xyz", "books", etc. as Resolved.

Verified the special group names are present in the data-mw-group attributes as produced by Parsoid Cite extension.
Verified that T246761 (on Apple iPhone 6+ with latest Wikipedia iOS app), is still producing the correct format for backlinks on that closed bug.
Notes: Parsoid Cite extension must deviate from Core Cite extensions handling of special group names such as lower-greek, so that VE gets numeric counters instead of language or style specific counters that it would not be able to continue to extend with additional counters of the same format. As such Parsoid Cite extension relies of CSS to see the data-mw-group attribute having a special group name like lower-greek, and provide custom format counters for display where needed. Mobile applications must provide equivalent detection and display of custom counter formats.

Jan 20 2021, 11:01 PM · Parsoid
Sbailey claimed T272097: Parsoid Cite doesn't know about special group names like "lower-alpha" etc. and treats them like other group names like "xyz", "books", etc..
Jan 20 2021, 4:45 PM · Parsoid

Jan 14 2021

Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Jan 14 2021, 10:33 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid
Sbailey created T272097: Parsoid Cite doesn't know about special group names like "lower-alpha" etc. and treats them like other group names like "xyz", "books", etc..
Jan 14 2021, 10:30 PM · Parsoid

Jan 13 2021

Sbailey placed T241997: Create proper (documented!) class for Parsoid $attribs array up for grabs.
Jan 13 2021, 8:05 PM · Parsoid

Jan 5 2021

Sbailey added a comment to T221490: Parsoid: Cite silently ignores all parameters in <ref> with more than two parameters.

It appears that core cite no longer ignores refs with more than 2 parameters, and parsoid cite never did inherit this (bug). In discussion with Arlo, we find parsoid cite correct as is, but also find we could add an error case for illegal parameters instead of just ignoring them.

Jan 5 2021, 6:24 PM · Parsoid

Dec 10 2020

Sbailey closed T263052: Move inline css on follow refs to the Cite extension stylesheet, a subtask of T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension, as Resolved.
Dec 10 2020, 8:24 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid
Sbailey closed T263052: Move inline css on follow refs to the Cite extension stylesheet as Resolved.
Dec 10 2020, 8:24 PM · MW-1.36-notes (1.36.0-wmf.21; 2020-12-08), Parsoid

Dec 2 2020

Sbailey added a comment to T267974: Some linebreak chars in <ref>'s name attribute (and possibly other attributes as well) not handled correctly by Parsoid's Cite implementation.

It looks like code in Sanitizer.php (line 1302) escapeIdInternal() is insufficient to handle the case of other characters
than "\t", "\n", "\f", "\r", " " being replaced as Cite refName IDs. Not sure how we ought to determine which unicode characters that some fonts my not have a glyph for should be converted to an underbar.

Dec 2 2020, 8:13 PM · MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Patch-For-Review, Cite, Parsoid
Sbailey added a comment to T267974: Some linebreak chars in <ref>'s name attribute (and possibly other attributes as well) not handled correctly by Parsoid's Cite implementation.

So analyzing the example WT, with current Parsoid/Cite code the following behavior for the $refName ID text occurs;

Dec 2 2020, 8:06 PM · MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Patch-For-Review, Cite, Parsoid
Sbailey added a comment to T267974: Some linebreak chars in <ref>'s name attribute (and possibly other attributes as well) not handled correctly by Parsoid's Cite implementation.

test<ref name="a
b">asdf</ref>

Dec 2 2020, 7:21 PM · MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Patch-For-Review, Cite, Parsoid

Dec 1 2020

Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Dec 1 2020, 6:48 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid
Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Dec 1 2020, 6:47 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Nov 25 2020

Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Nov 25 2020, 9:37 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Nov 10 2020

Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Nov 10 2020, 7:09 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Oct 28 2020

Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Oct 28 2020, 8:18 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Oct 19 2020

Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Oct 19 2020, 9:13 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Oct 13 2020

Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Oct 13 2020, 10:39 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid
Sbailey added a comment to T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.

Parsoid does not tokenize unbalanced tags so the following two errors are not identifiable. A <ref ...> without closing </ref> and <referances ...> without a closing </references>. Self closing <ref ... /> and <references /> are handled properly.
"cite_error_included_ref": "Closing </ref> missing for <ref> tag",
"cite_error_included_references": "Closing tag missing for <references>",

Oct 13 2020, 10:28 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Oct 5 2020

Sbailey added a comment to T264127: Please replace Shannon Baileys SSH key.

Thank you. I tested in and can now access scandium as needed.

Oct 5 2020, 6:09 PM · Patch-For-Review, SRE-Access-Requests, SRE

Oct 2 2020

Sbailey added a comment to T264127: Please replace Shannon Baileys SSH key.

Ok, there must be some other way to verify security. My previous SSH key is gone, I need a new one installed so I can log in to scandium somehow.

Oct 2 2020, 5:21 PM · Patch-For-Review, SRE-Access-Requests, SRE

Oct 1 2020

Sbailey added a comment to T264127: Please replace Shannon Baileys SSH key.

I cannot access bast1002 using ssh bast1002.wikimedia.org
Keeps asking for Password: which I do not have.

Oct 1 2020, 8:50 PM · Patch-For-Review, SRE-Access-Requests, SRE
Sbailey added a comment to T264127: Please replace Shannon Baileys SSH key.

Ya, tried to do this, but do not have access. I might need to refresh my id_rsa.pub key as well. Not sure how this whole house of cards hangs together:

Oct 1 2020, 4:45 PM · Patch-For-Review, SRE-Access-Requests, SRE

Sep 29 2020

Sbailey created T264127: Please replace Shannon Baileys SSH key.
Sep 29 2020, 8:01 PM · Patch-For-Review, SRE-Access-Requests, SRE

Sep 24 2020

Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Sep 24 2020, 6:08 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Sep 21 2020

Sbailey added a comment to T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.

Notes about errors that Parsoid Cite will not or may not generate and new errors that should be generated but have no key or error message yet in the en.json file:

Sep 21 2020, 8:23 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Jul 8 2020

Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Jul 8 2020, 8:31 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Jul 1 2020

Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Jul 1 2020, 5:06 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Jun 22 2020

Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Jun 22 2020, 10:31 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Jun 17 2020

Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Jun 17 2020, 5:37 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Jun 15 2020

Sbailey added a comment to T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.

Catalog of all Cite errors from Core Cite en.json array.

Jun 15 2020, 10:38 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

May 21 2020

Sbailey updated the task description for T251842: Proposal for Parsoid Cite error html generation.
May 21 2020, 3:33 PM · Parsing-Active-Work, Parsoid

May 20 2020

Sbailey added a comment to T251842: Proposal for Parsoid Cite error html generation.

Updated the specification to match recent discussion and the current implementation of patch https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/584746 which addresses aspects of Phab ticket T51538

May 20 2020, 11:08 PM · Parsing-Active-Work, Parsoid
Sbailey updated the task description for T251842: Proposal for Parsoid Cite error html generation.
May 20 2020, 11:06 PM · Parsing-Active-Work, Parsoid

May 15 2020

Sbailey added a comment to T251842: Proposal for Parsoid Cite error html generation.

Before I update the actual proposal, I am experimenting with changes to the "ref" and "reference" html generated.
The ref now does not include the class="error mw-ext-cite-error" and is set to the normal class="mw-ref" allowing normal display.
But it does include the data-mw={"errors":[{"key":{"cite_error_ref_no_input"}]} so code that cares can know there is an error and the i18n key is there to allow message text to be displayed internationally compliant.

May 15 2020, 1:02 AM · Parsing-Active-Work, Parsoid

May 7 2020

Sbailey updated the task description for T251842: Proposal for Parsoid Cite error html generation.
May 7 2020, 6:09 PM · Parsing-Active-Work, Parsoid
Sbailey updated the task description for T251842: Proposal for Parsoid Cite error html generation.
May 7 2020, 6:09 PM · Parsing-Active-Work, Parsoid
Sbailey updated the task description for T251842: Proposal for Parsoid Cite error html generation.
May 7 2020, 6:07 PM · Parsing-Active-Work, Parsoid
Sbailey added a comment to T251842: Proposal for Parsoid Cite error html generation.
May 7 2020, 5:54 PM · Parsing-Active-Work, Parsoid

May 5 2020

Sbailey updated the task description for T251842: Proposal for Parsoid Cite error html generation.
May 5 2020, 5:12 PM · Parsing-Active-Work, Parsoid

May 4 2020

Sbailey created T251842: Proposal for Parsoid Cite error html generation.
May 4 2020, 11:49 PM · Parsing-Active-Work, Parsoid