Page MenuHomePhabricator

Sbailey (Sbailey)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 4 2017, 8:49 PM (165 w, 2 d)
Availability
Available
LDAP User
Sbailey
MediaWiki User
SBailey (WMF) [ Global Accounts ]

Recent Activity

Wed, Dec 2

Sbailey added a comment to T267974: Some linebreak chars in <ref>'s name attribute (and possibly other attributes as well) not handled correctly by Parsoid's Cite implementation.

It looks like code in Sanitizer.php (line 1302) escapeIdInternal() is insufficient to handle the case of other characters
than "\t", "\n", "\f", "\r", " " being replaced as Cite refName IDs. Not sure how we ought to determine which unicode characters that some fonts my not have a glyph for should be converted to an underbar.

Wed, Dec 2, 8:13 PM · Patch-For-Review, Cite, Parsoid
Sbailey added a comment to T267974: Some linebreak chars in <ref>'s name attribute (and possibly other attributes as well) not handled correctly by Parsoid's Cite implementation.

So analyzing the example WT, with current Parsoid/Cite code the following behavior for the $refName ID text occurs;

Wed, Dec 2, 8:06 PM · Patch-For-Review, Cite, Parsoid
Sbailey added a comment to T267974: Some linebreak chars in <ref>'s name attribute (and possibly other attributes as well) not handled correctly by Parsoid's Cite implementation.

test<ref name="a
b">asdf</ref>

Wed, Dec 2, 7:21 PM · Patch-For-Review, Cite, Parsoid

Tue, Dec 1

Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Tue, Dec 1, 6:48 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid
Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Tue, Dec 1, 6:47 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Wed, Nov 25

Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Wed, Nov 25, 9:37 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Tue, Nov 10

Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Tue, Nov 10, 7:09 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Oct 28 2020

Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Oct 28 2020, 8:18 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Oct 19 2020

Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Oct 19 2020, 9:13 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Oct 13 2020

Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Oct 13 2020, 10:39 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid
Sbailey added a comment to T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.

Parsoid does not tokenize unbalanced tags so the following two errors are not identifiable. A <ref ...> without closing </ref> and <referances ...> without a closing </references>. Self closing <ref ... /> and <references /> are handled properly.
"cite_error_included_ref": "Closing </ref> missing for <ref> tag",
"cite_error_included_references": "Closing tag missing for <references>",

Oct 13 2020, 10:28 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Oct 5 2020

Sbailey added a comment to T264127: Please replace Shannon Baileys SSH key.

Thank you. I tested in and can now access scandium as needed.

Oct 5 2020, 6:09 PM · Patch-For-Review, SRE-Access-Requests, Operations

Oct 2 2020

Sbailey added a comment to T264127: Please replace Shannon Baileys SSH key.

Ok, there must be some other way to verify security. My previous SSH key is gone, I need a new one installed so I can log in to scandium somehow.

Oct 2 2020, 5:21 PM · Patch-For-Review, SRE-Access-Requests, Operations

Oct 1 2020

Sbailey added a comment to T264127: Please replace Shannon Baileys SSH key.

I cannot access bast1002 using ssh bast1002.wikimedia.org
Keeps asking for Password: which I do not have.

Oct 1 2020, 8:50 PM · Patch-For-Review, SRE-Access-Requests, Operations
Sbailey added a comment to T264127: Please replace Shannon Baileys SSH key.

Ya, tried to do this, but do not have access. I might need to refresh my id_rsa.pub key as well. Not sure how this whole house of cards hangs together:

Oct 1 2020, 4:45 PM · Patch-For-Review, SRE-Access-Requests, Operations

Sep 29 2020

Sbailey created T264127: Please replace Shannon Baileys SSH key.
Sep 29 2020, 8:01 PM · Patch-For-Review, SRE-Access-Requests, Operations

Sep 24 2020

Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Sep 24 2020, 6:08 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Sep 21 2020

Sbailey added a comment to T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.

Notes about errors that Parsoid Cite will not or may not generate and new errors that should be generated but have no key or error message yet in the en.json file:

Sep 21 2020, 8:23 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Jul 8 2020

Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Jul 8 2020, 8:31 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Jul 1 2020

Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Jul 1 2020, 5:06 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Jun 22 2020

Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Jun 22 2020, 10:31 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Jun 17 2020

Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Jun 17 2020, 5:37 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Jun 15 2020

Sbailey added a comment to T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.

Catalog of all Cite errors from Core Cite en.json array.

Jun 15 2020, 10:38 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

May 21 2020

Sbailey updated the task description for T251842: Proposal for Parsoid Cite error html generation.
May 21 2020, 3:33 PM · Parsing-Active-Work, Parsoid

May 20 2020

Sbailey added a comment to T251842: Proposal for Parsoid Cite error html generation.

Updated the specification to match recent discussion and the current implementation of patch https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/584746 which addresses aspects of Phab ticket T51538

May 20 2020, 11:08 PM · Parsing-Active-Work, Parsoid
Sbailey updated the task description for T251842: Proposal for Parsoid Cite error html generation.
May 20 2020, 11:06 PM · Parsing-Active-Work, Parsoid

May 15 2020

Sbailey added a comment to T251842: Proposal for Parsoid Cite error html generation.

Before I update the actual proposal, I am experimenting with changes to the "ref" and "reference" html generated.
The ref now does not include the class="error mw-ext-cite-error" and is set to the normal class="mw-ref" allowing normal display.
But it does include the data-mw={"errors":[{"key":{"cite_error_ref_no_input"}]} so code that cares can know there is an error and the i18n key is there to allow message text to be displayed internationally compliant.

May 15 2020, 1:02 AM · Parsing-Active-Work, Parsoid

May 7 2020

Sbailey updated the task description for T251842: Proposal for Parsoid Cite error html generation.
May 7 2020, 6:09 PM · Parsing-Active-Work, Parsoid
Sbailey updated the task description for T251842: Proposal for Parsoid Cite error html generation.
May 7 2020, 6:09 PM · Parsing-Active-Work, Parsoid
Sbailey updated the task description for T251842: Proposal for Parsoid Cite error html generation.
May 7 2020, 6:07 PM · Parsing-Active-Work, Parsoid
Sbailey added a comment to T251842: Proposal for Parsoid Cite error html generation.
May 7 2020, 5:54 PM · Parsing-Active-Work, Parsoid

May 5 2020

Sbailey updated the task description for T251842: Proposal for Parsoid Cite error html generation.
May 5 2020, 5:12 PM · Parsing-Active-Work, Parsoid

May 4 2020

Sbailey created T251842: Proposal for Parsoid Cite error html generation.
May 4 2020, 11:49 PM · Parsing-Active-Work, Parsoid

Mar 17 2020

Sbailey added a comment to T215628: Make Parsoid and PHP edit-section numbering consistent when <noinclude> and <includeonly> are in use.

A paused Gerrit patch for this exists that fixes one test but does not fix the test mentioned in comments in:
https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/577368

Mar 17 2020, 5:30 PM · Patch-For-Review, Parsoid
Sbailey placed T215628: Make Parsoid and PHP edit-section numbering consistent when <noinclude> and <includeonly> are in use up for grabs.

As advised by Subbu, there are two possible (probably correct) solutions to this bug beyond the partial fix that is here, but in fact is not correct for all circumstances as his note describes. Either a DOM based solution that walks the DOM and fixes the nested section ID's as a post process, or by taking advantage of the fact we no longer have asyncronous execution and having the $headingIndex, as set in line 54 of Grammar.php be set to an ongoing globally scoped state that increments appropriately and avoid ID's being reset to zero when new pipelines are created.

Mar 17 2020, 5:29 PM · Patch-For-Review, Parsoid

Mar 6 2020

Sbailey placed T95931: Parsoid automatically changes pseudo-interlanguage interwiki link text to match link prefix + full target page name up for grabs.
Mar 6 2020, 5:12 PM · Parsoid
Sbailey placed T69373: Parsoid shouldn't convert external links to interwiki links when the interwiki prefix matches a local namespace name up for grabs.
Mar 6 2020, 5:12 PM · Parsoid

Mar 4 2020

Sbailey claimed T215628: Make Parsoid and PHP edit-section numbering consistent when <noinclude> and <includeonly> are in use.
Mar 4 2020, 5:30 PM · Patch-For-Review, Parsoid
Sbailey added a comment to T237462: Port Parsoid/JS JSON extension to Parsoid/PHP.

JSON extension ported from JS to PHP complete.
1 Port-fixme is still present due to a dependence on addMetaData that is not avaialble yet to extensions.
Part of the addMetaData functionality was duplicated in the extension in the mean time.

Mar 4 2020, 3:52 PM · Parsoid-PHP

Feb 28 2020

Sbailey added a comment to T245877: Give all members of the Parsing team production `deployment` access ( add arlolra to deployers).

Subbu says yes to here it is:
ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDCYenmO37Azx5fr7WO5F107ZL6g3o5AAgkLsGtheyCC9soguCltps4a2MBrw3nBMVXRPFSfJiTvsWARUC40d0oWxcqpXkRtHrY4mNzMMMz8lFzxRQ8ts+zKdU2KZJ8vaEhCnVmRemvIGE8xlaVPEleaAeyAZOjKxBaPVHB9CX7b0QgnZ+RTZRXi9BD1Aa0gnYurwJ5tA1nwPub0MRtGrkXhVaG78rUpkHECeM5BbmQoZnrvL4J9FdRkMkifEyHop+75RweUNbFhkiQ6pNia3MSMBC2tSYSL8IaLCqha8lFDkwHBNpzG09mpzFw1La6Niuth3CQ/72U9dQRvQFk+/Mp shannonbailey@wmf1287.local

Feb 28 2020, 4:15 PM · Operations, SRE-Access-Requests, serviceops, Parsoid-PHP
Sbailey added a comment to T245877: Give all members of the Parsing team production `deployment` access ( add arlolra to deployers).

Greg, do you really want me to post my public key in this form? or send it in a seperate message?

Feb 28 2020, 4:04 PM · Operations, SRE-Access-Requests, serviceops, Parsoid-PHP

Jan 21 2020

Sbailey claimed T237462: Port Parsoid/JS JSON extension to Parsoid/PHP.
Jan 21 2020, 7:56 PM · Parsoid-PHP
Sbailey claimed T235273: Remove PHPUtils::jsSort routine (or make it no-op) once Parsoid/JS is retired.
Jan 21 2020, 7:56 PM · Parsoid-PHP

Jan 6 2020

Sbailey claimed T241997: Create proper (documented!) class for Parsoid $attribs array.
Jan 6 2020, 11:15 PM · Parsoid

Dec 18 2019

Sbailey added a comment to T238845: Call to a member function serialize() on null.

I configured my local wiki to allow:

GroupPermissions['administrators']['suppressrevision'] = true;
and added 'suppressor' for revisions to my administrators
http://localhost:8080/index.php?title=Special%3AUserRights
account. I then used local user account to edit a page
and then used my admin account to edit it again. I captured
the other users edit oldid and used the admin account to
access the page history and used 'Change visibility of selected
revisions' button on right to suppress the ability to read that
old revision. This reproduced the bug and I found that
Api/PageConfig makeRequest( ... ) was not returned the [pages]
as designed, but our code was accessing that associative key
anyway without protection causing a crash.
Dec 18 2019, 7:47 PM · Parsoid-PHP
Sbailey added a comment to T238745: Argument 1 passed to Parsoid\Wt2Html\TokenTransformManager::processChunk() must be of the type array, boolean given.

I believe this is a duplicate of T238845 and is triggered by an editor electing to 'suppress' an edit revision which then causes the Api/PageConfig.php code call to makeRequest( ... ) to return associative array missing the ['pages'] elements appropriately, but the code then went and attempted to access ['pages'] anyway without protection causing a crash.
The fix for T238845 seems to fix this case as well.

Dec 18 2019, 7:46 PM · Parsoid-PHP

Dec 17 2019

Sbailey claimed T238745: Argument 1 passed to Parsoid\Wt2Html\TokenTransformManager::processChunk() must be of the type array, boolean given.
Dec 17 2019, 6:00 PM · Parsoid-PHP

Dec 16 2019

Sbailey closed T236415: Edge case category link output difference as Resolved.
Dec 16 2019, 3:29 PM · Parsoid-PHP

Dec 10 2019

Sbailey claimed T238845: Call to a member function serialize() on null.
Dec 10 2019, 6:19 PM · Parsoid-PHP

Dec 9 2019

Sbailey claimed T239252: Invariant failed: Bad SourceRange length.
Dec 9 2019, 4:20 PM · Parsoid-PHP

Nov 19 2019

Sbailey closed T237461: Parsoid/PHP LintLogger has gaps relative to Parsoid/JS, a subtask of T237326: Make Parsoid/PHP cluster read-write to ensure lints discovered by Parsoid/PHP are stored in the DB, as Resolved.
Nov 19 2019, 6:43 PM · Platform Engineering, User-WDoran, Parsoid-PHP
Sbailey closed T237461: Parsoid/PHP LintLogger has gaps relative to Parsoid/JS as Resolved.
Nov 19 2019, 6:43 PM · Parsoid-PHP

Nov 12 2019

Sbailey closed T236868: Invariant failed: Bad SourceRange length as Resolved.
Nov 12 2019, 6:21 PM · Parsoid-PHP

Nov 7 2019

Sbailey closed T236846: TemplateHandler.php: trim() expects parameter 1 to be string, boolean given as Resolved.

Fix for crash completed and fixes that produce desired behavior and correct wikitext and VE edit updates all implemented and tests written.

Nov 7 2019, 11:52 PM · Parsoid-PHP

Nov 6 2019

Sbailey claimed T237461: Parsoid/PHP LintLogger has gaps relative to Parsoid/JS.
Nov 6 2019, 5:13 PM · Parsoid-PHP

Nov 5 2019

Sbailey claimed T236846: TemplateHandler.php: trim() expects parameter 1 to be string, boolean given.
Nov 5 2019, 6:00 PM · Parsoid-PHP

Oct 31 2019

Sbailey claimed T236868: Invariant failed: Bad SourceRange length.
Oct 31 2019, 3:29 PM · Parsoid-PHP
Sbailey added a comment to T235231: Parsoid/JS video tag has a "seek" parameter in the URL that Parsoid/PHP video tag output doesn't.

Should be resolved by:
https://gerrit.wikimedia.org/r/547335

Oct 31 2019, 2:59 PM · Parsoid-PHP

Oct 24 2019

Sbailey placed T235777: Redlink differences between Parsoid/PHP and Parsoid/JS up for grabs.

Debugged both parsoid JS and PHP and without, and with --useBatchAPI enabled on parsoidJS, the class="new" does appear, but the redlinks code will not get called without that command line flag enabled. The parsoid PHP calls the redlink code without any command line flags required.
Unable to reproduce the error that occurred in the server environment, possibly missing --useBatchAPI?

Oct 24 2019, 6:27 PM · Parsoid-PHP

Oct 18 2019

Sbailey added a comment to T235709: Too many diffs on this page.

The JS Poem extension was also failing to properly handle the following (enhanced slightly WT below) and the PHP Poem was dramatically failing to produce viable HTML from:

Oct 18 2019, 11:56 PM · Parsoid-PHP

Oct 16 2019

Sbailey added a comment to T235231: Parsoid/JS video tag has a "seek" parameter in the URL that Parsoid/PHP video tag output doesn't.

Researched and attempted to reproduce using command line parse.php and in that mode, does not fail to match ParsoidJS in command line mode. The core parser also produces the seek correctly, but when ParsoidPHP is used in production mode, fails with local installation of mediawiki or on server installations.
I need to get my local mediawiki install back in running state after upgrading OSX to Catalina to continue.

Oct 16 2019, 9:35 PM · Parsoid-PHP

Oct 15 2019

Sbailey closed T233738: Add a flag (--mock?) to the parse.php script to use the mock SiteConfig and DataAccess, a subtask of T228217: Ensure all the features of parse.js are covered by parse.php, as Resolved.
Oct 15 2019, 10:54 PM · Parsoid-PHP
Sbailey closed T233738: Add a flag (--mock?) to the parse.php script to use the mock SiteConfig and DataAccess as Resolved.

Added:
https://gerrit.wikimedia.org/r/#/c/mediawiki/services/parsoid/+/541343/

Oct 15 2019, 10:54 PM · Parsoid-PHP
Sbailey closed T226437: Audit uses of empty() and isset() and eliminate unnecessary uses as Resolved.

Replaced empty() and isset() where safe.
https://gerrit.wikimedia.org/r/#/c/mediawiki/services/parsoid/+/543229/

Oct 15 2019, 10:53 PM · Parsoid, Technical-Debt

Oct 9 2019

Sbailey closed T223194: Consider using instanceof checks for DOM Nodes instead of DOMUtils::is* + DOMUtils::assertElt combinations as Resolved.

After reviewing Parsoid/PHP on Oct, 9, it appears that all performance improvements possible were addressed by:
https://gerrit.wikimedia.org/r/533258

Oct 9 2019, 10:36 PM · Parsoid-PHP
Sbailey closed T223193: Consider using instanceof instead of TokenUtils::getTokenType as Resolved.
Oct 9 2019, 8:30 PM · Parsoid-PHP

Sep 18 2019

Sbailey created T233252: Need to write more tests for LinkHandlerUtils.php figureHandler to add coverage.
Sep 18 2019, 7:07 PM · Parsoid

Aug 1 2019

Sbailey claimed T229264: Logging out on web logs out iOS session.
Aug 1 2019, 8:21 PM · iOS-app-v6.6-Penguin-On-A-Sled, iOS-app-Bugs, Wikipedia-iOS-App-Backlog

Jul 30 2019

Sbailey closed T138784: add support Maldivian Wikipedia as Resolved.
Jul 30 2019, 6:14 PM · iOS-app-v6.4-Seamonkey-On-A-Hoverboard, I18n, iOS-app-feature-Multilingual, Wikipedia-iOS-App-Backlog

Jul 26 2019

Sbailey claimed T138784: add support Maldivian Wikipedia.
Jul 26 2019, 12:03 AM · iOS-app-v6.4-Seamonkey-On-A-Hoverboard, I18n, iOS-app-feature-Multilingual, Wikipedia-iOS-App-Backlog
Sbailey moved T138784: add support Maldivian Wikipedia from Ready for Development to Doing on the iOS-app-v6.4-Seamonkey-On-A-Hoverboard board.
Jul 26 2019, 12:03 AM · iOS-app-v6.4-Seamonkey-On-A-Hoverboard, I18n, iOS-app-feature-Multilingual, Wikipedia-iOS-App-Backlog

Jul 17 2019

Sbailey claimed T196679: [BUG] "Syncing will resume when internet available" appears at top of theme panel.
Jul 17 2019, 5:37 PM · iOS-app-v6.3.1 Lobster-On-An-ORV, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
Sbailey moved T196679: [BUG] "Syncing will resume when internet available" appears at top of theme panel from Ready for Development to Doing on the iOS-app-v6.3.1 Lobster-On-An-ORV board.
Jul 17 2019, 5:36 PM · iOS-app-v6.3.1 Lobster-On-An-ORV, iOS-app-Bugs, Wikipedia-iOS-App-Backlog

Jul 16 2019

Sbailey moved T213465: Article footer is too tall from Doing to Ready for Development on the iOS-app-v6.3.1 Lobster-On-An-ORV board.
Jul 16 2019, 3:17 PM · iOS-app-Bugs, Wikipedia-iOS-App-Backlog
Sbailey placed T213465: Article footer is too tall up for grabs.
Jul 16 2019, 3:16 PM · iOS-app-Bugs, Wikipedia-iOS-App-Backlog

Jul 15 2019

Sbailey created T228115: querySelectorAll seems to be malfunctioning on "body > p:nth-child( 1 )" and ...( 2 ).
Jul 15 2019, 11:03 PM · Parsoid-PHP

Jul 10 2019

Sbailey moved T213465: Article footer is too tall from Ready for Development to Doing on the iOS-app-v6.3.1 Lobster-On-An-ORV board.
Jul 10 2019, 7:17 PM · iOS-app-Bugs, Wikipedia-iOS-App-Backlog
Sbailey claimed T213465: Article footer is too tall.
Jul 10 2019, 7:14 PM · iOS-app-Bugs, Wikipedia-iOS-App-Backlog

Nov 27 2018

Sbailey updated the task description for T209186: Create a "unit-testing" framework for DOM transformers.
Nov 27 2018, 9:39 PM · Parsoid-PHP
Sbailey added a comment to T209186: Create a "unit-testing" framework for DOM transformers.

First phase of generating dom pre and post pass test files completed:
https://gerrit.wikimedia.org/r/#/c/mediawiki/services/parsoid/+/474775/

Nov 27 2018, 9:33 PM · Parsoid-PHP

Nov 8 2018

Sbailey created T209118: Add time usage and call count to TokenTransformMangers add, remove and getTransform functions.
Nov 8 2018, 9:58 PM · Patch-For-Review, Parsoid

Aug 16 2018

Sbailey added a comment to T199246: Parsoid should expose content inside <includeonly> to editors instead of hiding it in the meta tag's data-parsoid attribute.

WIP
https://gerrit.wikimedia.org/r/#/c/mediawiki/services/parsoid/+/452837/

Aug 16 2018, 9:20 PM · Patch-For-Review, Parsoid

Jul 17 2018

Sbailey added a comment to T199718: Parsoid doesn't support {{!}} in links.

So on my development Parsoid (some configuration info is not the same as production), I cannot reproduce this bug:

Jul 17 2018, 6:48 PM · Parsoid

Jun 11 2018

Gerrit Code Review <gerrit@wikimedia.org> committed rELINTe881f5c079f0: Update patch set 1 (authored by Sbailey).
Update patch set 1
Jun 11 2018, 2:15 PM

May 22 2018

Sbailey claimed T194945: Infobox overlaps with text, prevents editing the latter..
May 22 2018, 3:09 PM · Parsoid, VisualEditor

Apr 19 2018

Restricted Application added a project to T191700: VE: Avoid piping links for formatting where possible: Product-Analytics.

The normalization code now checks for matching href and textContent, and also avoid normalizing WikiLinks that have color, style and class attributes.

Apr 19 2018, 12:02 AM · Parsoid

Apr 4 2018

Sbailey added a comment to T189474: Image captions should ignore paragraph tags.

Adding a second patch to handle multiple paragraphs being collapsed in a figcaption.

Apr 4 2018, 8:10 PM · Patch-Needs-Improvement, Parsoid

Mar 19 2018

Sbailey added a comment to T189474: Image captions should ignore paragraph tags.

The first submission of the patch just fixes the single case.

Mar 19 2018, 11:36 PM · Patch-Needs-Improvement, Parsoid
Sbailey added a comment to T189474: Image captions should ignore paragraph tags.

Ed, Subbu and I have discussed that for multiple p tags in the caption, we will be replacing the new lines with a single space, merging the captions together. The hope is that the captions would be sentences and that joining them with a space will be a reasonable way to "fix" this situation.

Mar 19 2018, 11:36 PM · Patch-Needs-Improvement, Parsoid

Feb 1 2018

Sbailey reopened T58756: Parsoid doesn't give external links class="external free|text" as "Open".

Re-opened until merged and deployed, my bad.

Feb 1 2018, 4:59 PM · Patch-For-Review, Parsoid
Sbailey reopened T58756: Parsoid doesn't give external links class="external free|text", a subtask of T67243: Flow: Obey the Exlinks gadget (open external links in new tab/window), as Open.
Feb 1 2018, 4:59 PM · Collaboration-Team-Triage, StructuredDiscussions
Sbailey reopened T58756: Parsoid doesn't give external links class="external free|text", a subtask of T96855: A15. Flow rendering doesn't render external links correctly, as Open.
Feb 1 2018, 4:59 PM · Patch-For-Review, Collaboration-Team-Triage, Collaboration-Team-Sprint-A-2015-05-06, StructuredDiscussions
Sbailey closed T58756: Parsoid doesn't give external links class="external free|text" as Resolved.

So for class = "external free", "external text" and "external autonumber", parsoid now generates the proper class attributes and matches the PHP parser output.
See gerrit:
https://gerrit.wikimedia.org/r/#/c/407053/

Feb 1 2018, 4:09 PM · Patch-For-Review, Parsoid
Sbailey closed T58756: Parsoid doesn't give external links class="external free|text", a subtask of T67243: Flow: Obey the Exlinks gadget (open external links in new tab/window), as Resolved.
Feb 1 2018, 4:09 PM · Collaboration-Team-Triage, StructuredDiscussions
Sbailey closed T58756: Parsoid doesn't give external links class="external free|text", a subtask of T96855: A15. Flow rendering doesn't render external links correctly, as Resolved.
Feb 1 2018, 4:09 PM · Patch-For-Review, Collaboration-Team-Triage, Collaboration-Team-Sprint-A-2015-05-06, StructuredDiscussions

Dec 18 2017

Sbailey added a comment to T71207: Parsoid: Interwiki links are halfway converted to external links, and completely broken.

I retried James example the current Parsoid and it seems to work properly. Is there another failing case I can look at?

Dec 18 2017, 11:56 PM · Parsoid, Parsoid-Serializer

Oct 5 2017

Sbailey added a comment to T177447: Add Sbailey to the #WMF-NDA group.

Hi,
Hi, thanks, I linked the accounts (I think).
Best,
Shannon

Oct 5 2017, 5:09 PM · WMF-NDA-Requests
Sbailey added a comment to T177447: Add Sbailey to the #WMF-NDA group.

Hi,
THanks I linked the accounts.
Shannon

Oct 5 2017, 5:08 PM · WMF-NDA-Requests

Oct 4 2017

Sbailey created T177447: Add Sbailey to the #WMF-NDA group.
Oct 4 2017, 10:56 PM · WMF-NDA-Requests
Sbailey added a watcher for WMF-NDA: Sbailey.
Oct 4 2017, 10:53 PM