Page MenuHomePhabricator

Sbailey (Sbailey)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 4 2017, 8:49 PM (192 w, 6 d)
Availability
Available
LDAP User
Sbailey
MediaWiki User
SBailey (WMF) [ Global Accounts ]

Recent Activity

Fri, Jun 11

Sbailey claimed T225337: Unbreak RecordLintJobTest.

I believe I have a fix for this and want this fix done prior to adding additional tests to RecordListJobTest.php
The issue appears to be that RecordLintJob.php run() checks the revision and then delays the job run which in a production environment is a good idea, but not for this test, so I removed the revision property. I also set the pageID to 0 instead of 1 as that seems to be a new default allowing the test to find the inserted lint error appropriately.

Fri, Jun 11, 5:40 PM · Regression, Patch-For-Review, MediaWiki-extensions-Linter

Wed, May 26

Sbailey closed T162983: Parsoid linter shows rest of page as error when unbalanced brackets exists as Resolved.

The Linter error no longer is generated in this case, so the issue of error running to end of page is resolved.
A new phab ticket covering broken use of Wikilink with unclosed ]] might be worth creating as a low priority.

Wed, May 26, 8:23 PM · Parsoid, Parsoid-Tokenizer, MediaWiki-extensions-Linter

Tue, May 25

Sbailey claimed T162983: Parsoid linter shows rest of page as error when unbalanced brackets exists.
Tue, May 25, 5:24 PM · Parsoid, Parsoid-Tokenizer, MediaWiki-extensions-Linter

Apr 30 2021

Sbailey claimed T170313: Linter count not updated on deleted page.

Exploring why Linter error counts are still incorrect after a page is deleted.

Apr 30 2021, 6:46 PM · MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), WMSE-Bug-Reporting-and-Translation-2017, MediaWiki-extensions-Linter

Apr 27 2021

Sbailey updated the task description for T194872: Linter : have correct counters for categories populated with only a few errors (or none).
Apr 27 2021, 7:41 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), MediaWiki-extensions-Linter
Sbailey updated the task description for T194872: Linter : have correct counters for categories populated with only a few errors (or none).
Apr 27 2021, 7:40 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), MediaWiki-extensions-Linter
Sbailey added a comment to T194872: Linter : have correct counters for categories populated with only a few errors (or none).

So gerrit patch 677673 modifies the code which generates estimated linter error counts for a category to produce an accurate count when the actual count in the database is less than (20) or whatever MAX_ACCURATE_COUNT is set to in Database.php in the Linter extension directory. While this change will help produce more accurate counts, other issues of when the object cache gets refreshed still apply as does errors that become stale when a page with errors is deleted, prior to a full refresh of the Linter errors from all active pages is performed. Still this should provide better counts in most circumstances.
I am not going to close this ticket as resolved, until a more complete solution is implemented that has fewer caveats.

Apr 27 2021, 7:38 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), MediaWiki-extensions-Linter
Sbailey committed rELINT201b47e01d38: Make Linter category counts more accurate when counts are low (authored by Sbailey).
Make Linter category counts more accurate when counts are low
Apr 27 2021, 6:00 PM

Mar 15 2021

Sbailey claimed T194872: Linter : have correct counters for categories populated with only a few errors (or none).
Mar 15 2021, 10:12 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), MediaWiki-extensions-Linter

Mar 10 2021

Sbailey moved T165538: Need a mechanism / process to purge invalid / stale entries from the Linter database from Backlog to Linter-UI on the MediaWiki-extensions-Linter board.
Mar 10 2021, 10:09 PM · MediaWiki-extensions-Linter

Mar 5 2021

Sbailey moved T246403: Lint error counts on "Page information" page do not update, even with null edit from Backlog to Linter-UI on the MediaWiki-extensions-Linter board.
Mar 5 2021, 8:57 PM · MediaWiki-extensions-Linter
Sbailey moved T171788: On wikis without changeprop enabled, lint errors don't update after page edits from Backlog to Linter-UI on the MediaWiki-extensions-Linter board.
Mar 5 2021, 6:59 PM · Parsoid (Tracking), Platform Team Legacy (Designing), Services (designing), wikitech.wikimedia.org, MediaWiki-extensions-Linter

Feb 25 2021

Sbailey closed T248369: Add linting rule for detecting presence of image wikitext in extlinks as Resolved.
Feb 25 2021, 11:01 PM · MediaWiki-extensions-Linter, Parsoid

Feb 22 2021

Sbailey placed T275415: Content duplicated when editing when a block template is used in a wikilink up for grabs.
Feb 22 2021, 8:27 PM · DiscussionTools, Parsoid
Sbailey added a comment to T275415: Content duplicated when editing when a block template is used in a wikilink.

Subbu wrote in IRC:

Feb 22 2021, 8:26 PM · DiscussionTools, Parsoid
Sbailey claimed T275415: Content duplicated when editing when a block template is used in a wikilink.
Feb 22 2021, 5:55 PM · DiscussionTools, Parsoid

Feb 19 2021

Sbailey closed T215999: Linter does not detect invalid "500px500px" as a bogus file option as Resolved.

Fixed by patches:

https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/661820

which addresses bogus width options, and

https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/665226

which addresses duplicate width options.

Feb 19 2021, 7:57 PM · Parsoid, MediaWiki-extensions-Linter

Feb 18 2021

Sbailey added a comment to T275074: Gallery does not allow "center" "left" or "right" as a caption for a gallery image.

Jonesey, this is a bug, and it will be fixed, not put off for years. It was
just more than a Linter bug, which is what I am focussing on, and after
debugging it, I determined that the problem occurs fairly early in the
parsing stages far removed from the Linter and is going to be tricky to
fix. I confirmed with my team mates that we will not deem this an annoying
quirk that we ignore, but fixing it was outside the scope of my current
tasks. I'll keep an eye on this task. Thanks for the additional insight as
to how editors might use Center more often than one might imagine.
Best,
Shannon

Feb 18 2021, 11:18 PM · Parsoid
Sbailey placed T266406: Linter false positive: "Center/Left/Right" as caption for gallery image up for grabs.
Feb 18 2021, 8:40 PM · Parsoid, MediaWiki-extensions-Linter
Sbailey updated the task description for T266406: Linter false positive: "Center/Left/Right" as caption for gallery image.
Feb 18 2021, 8:37 PM · Parsoid, MediaWiki-extensions-Linter

Feb 17 2021

Sbailey created T275074: Gallery does not allow "center" "left" or "right" as a caption for a gallery image.
Feb 17 2021, 8:09 PM · Parsoid

Feb 11 2021

Sbailey added a comment to T266406: Linter false positive: "Center/Left/Right" as caption for gallery image.

Notes: If looks like the use of left, right or center as caption words not only generates linter errors, the captions are not there, as the words have been eaten as options and not allowed to be captions. In looking at this further, the use of left, right or center in gallary seems not to be valid as an option, and so should be allowed as captions. In the following example,

<gallery>
File:Foobar.jpg|left
File:Foobar.jpg|notaleft
</gallery>

produces linter error:

{"type":"bogus-image-options","dsr":[0,66,9,10],"params":{"items":["left"]}}

and renders as:

... class="gallerytext" data-parsoid="{}"></div></li>
... class="gallerytext" data-parsoid='{"dsr":[47,55,0,0]}'>notaleft</div></li>
Feb 11 2021, 11:22 PM · Parsoid, MediaWiki-extensions-Linter

Feb 4 2021

Sbailey claimed T266406: Linter false positive: "Center/Left/Right" as caption for gallery image.
Feb 4 2021, 9:22 PM · Parsoid, MediaWiki-extensions-Linter
Sbailey claimed T264464: Conflicting border/thumb/frame options are not detected as Linter errors.
Feb 4 2021, 9:22 PM · MediaWiki-extensions-Linter
Sbailey claimed T207032: Lint away 'pxpx'.

This appears to be related to T215999
Linter does not detect invalid "500px500px" as a bogus file option

Feb 4 2021, 9:15 PM · Parsoid
Sbailey closed T242068: Linter does not detect link-in-link when wikilink is wrapped in italics as Resolved.
Feb 4 2021, 8:14 PM · Parsoid, MediaWiki-extensions-Linter

Jan 27 2021

Sbailey claimed T215999: Linter does not detect invalid "500px500px" as a bogus file option.
Jan 27 2021, 6:43 PM · Parsoid, MediaWiki-extensions-Linter
Sbailey claimed T248369: Add linting rule for detecting presence of image wikitext in extlinks.
Jan 27 2021, 6:40 PM · MediaWiki-extensions-Linter, Parsoid
Sbailey claimed T242068: Linter does not detect link-in-link when wikilink is wrapped in italics.
Jan 27 2021, 6:40 PM · Parsoid, MediaWiki-extensions-Linter

Jan 22 2021

Sbailey placed T267059: Spec for precisely positioned, localized error message in Parsoid up for grabs.
Jan 22 2021, 8:42 PM · Parsoid-Rendering, Parsoid

Jan 21 2021

Sbailey claimed T267059: Spec for precisely positioned, localized error message in Parsoid.
Jan 21 2021, 10:26 PM · Parsoid-Rendering, Parsoid

Jan 20 2021

Sbailey closed T272097: Parsoid Cite doesn't know about special group names like "lower-alpha" etc. and treats them like other group names like "xyz", "books", etc. as Resolved.

Verified the special group names are present in the data-mw-group attributes as produced by Parsoid Cite extension.
Verified that T246761 (on Apple iPhone 6+ with latest Wikipedia iOS app), is still producing the correct format for backlinks on that closed bug.
Notes: Parsoid Cite extension must deviate from Core Cite extensions handling of special group names such as lower-greek, so that VE gets numeric counters instead of language or style specific counters that it would not be able to continue to extend with additional counters of the same format. As such Parsoid Cite extension relies of CSS to see the data-mw-group attribute having a special group name like lower-greek, and provide custom format counters for display where needed. Mobile applications must provide equivalent detection and display of custom counter formats.

Jan 20 2021, 11:01 PM · Parsoid
Sbailey claimed T272097: Parsoid Cite doesn't know about special group names like "lower-alpha" etc. and treats them like other group names like "xyz", "books", etc..
Jan 20 2021, 4:45 PM · Parsoid

Jan 14 2021

Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Jan 14 2021, 10:33 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid
Sbailey created T272097: Parsoid Cite doesn't know about special group names like "lower-alpha" etc. and treats them like other group names like "xyz", "books", etc..
Jan 14 2021, 10:30 PM · Parsoid

Jan 13 2021

Sbailey placed T241997: Create proper (documented!) class for Parsoid $attribs array up for grabs.
Jan 13 2021, 8:05 PM · Parsoid

Jan 5 2021

Sbailey added a comment to T221490: Parsoid: Cite silently ignores all parameters in <ref> with more than two parameters.

It appears that core cite no longer ignores refs with more than 2 parameters, and parsoid cite never did inherit this (bug). In discussion with Arlo, we find parsoid cite correct as is, but also find we could add an error case for illegal parameters instead of just ignoring them.

Jan 5 2021, 6:24 PM · Parsoid

Dec 10 2020

Sbailey closed T263052: Move inline css on follow refs to the Cite extension stylesheet, a subtask of T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension, as Resolved.
Dec 10 2020, 8:24 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid
Sbailey closed T263052: Move inline css on follow refs to the Cite extension stylesheet as Resolved.
Dec 10 2020, 8:24 PM · MW-1.36-notes (1.36.0-wmf.21; 2020-12-08), Parsoid

Dec 2 2020

Sbailey added a comment to T267974: Some linebreak chars in <ref>'s name attribute (and possibly other attributes as well) not handled correctly by Parsoid's Cite implementation.

It looks like code in Sanitizer.php (line 1302) escapeIdInternal() is insufficient to handle the case of other characters
than "\t", "\n", "\f", "\r", " " being replaced as Cite refName IDs. Not sure how we ought to determine which unicode characters that some fonts my not have a glyph for should be converted to an underbar.

Dec 2 2020, 8:13 PM · MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Patch-For-Review, Cite, Parsoid
Sbailey added a comment to T267974: Some linebreak chars in <ref>'s name attribute (and possibly other attributes as well) not handled correctly by Parsoid's Cite implementation.

So analyzing the example WT, with current Parsoid/Cite code the following behavior for the $refName ID text occurs;

Dec 2 2020, 8:06 PM · MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Patch-For-Review, Cite, Parsoid
Sbailey added a comment to T267974: Some linebreak chars in <ref>'s name attribute (and possibly other attributes as well) not handled correctly by Parsoid's Cite implementation.

test<ref name="a
b">asdf</ref>

Dec 2 2020, 7:21 PM · MW-1.36-notes (1.36.0-wmf.28; 2021-01-26), Patch-For-Review, Cite, Parsoid

Dec 1 2020

Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Dec 1 2020, 6:48 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid
Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Dec 1 2020, 6:47 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Nov 25 2020

Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Nov 25 2020, 9:37 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Nov 10 2020

Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Nov 10 2020, 7:09 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Oct 28 2020

Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Oct 28 2020, 8:18 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Oct 19 2020

Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Oct 19 2020, 9:13 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Oct 13 2020

Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Oct 13 2020, 10:39 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid
Sbailey added a comment to T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.

Parsoid does not tokenize unbalanced tags so the following two errors are not identifiable. A <ref ...> without closing </ref> and <referances ...> without a closing </references>. Self closing <ref ... /> and <references /> are handled properly.
"cite_error_included_ref": "Closing </ref> missing for <ref> tag",
"cite_error_included_references": "Closing tag missing for <references>",

Oct 13 2020, 10:28 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Oct 5 2020

Sbailey added a comment to T264127: Please replace Shannon Baileys SSH key.

Thank you. I tested in and can now access scandium as needed.

Oct 5 2020, 6:09 PM · Patch-For-Review, SRE-Access-Requests, SRE

Oct 2 2020

Sbailey added a comment to T264127: Please replace Shannon Baileys SSH key.

Ok, there must be some other way to verify security. My previous SSH key is gone, I need a new one installed so I can log in to scandium somehow.

Oct 2 2020, 5:21 PM · Patch-For-Review, SRE-Access-Requests, SRE

Oct 1 2020

Sbailey added a comment to T264127: Please replace Shannon Baileys SSH key.

I cannot access bast1002 using ssh bast1002.wikimedia.org
Keeps asking for Password: which I do not have.

Oct 1 2020, 8:50 PM · Patch-For-Review, SRE-Access-Requests, SRE
Sbailey added a comment to T264127: Please replace Shannon Baileys SSH key.

Ya, tried to do this, but do not have access. I might need to refresh my id_rsa.pub key as well. Not sure how this whole house of cards hangs together:

Oct 1 2020, 4:45 PM · Patch-For-Review, SRE-Access-Requests, SRE

Sep 29 2020

Sbailey created T264127: Please replace Shannon Baileys SSH key.
Sep 29 2020, 8:01 PM · Patch-For-Review, SRE-Access-Requests, SRE

Sep 24 2020

Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Sep 24 2020, 6:08 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Sep 21 2020

Sbailey added a comment to T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.

Notes about errors that Parsoid Cite will not or may not generate and new errors that should be generated but have no key or error message yet in the en.json file:

Sep 21 2020, 8:23 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Jul 8 2020

Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Jul 8 2020, 8:31 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Jul 1 2020

Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Jul 1 2020, 5:06 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Jun 22 2020

Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Jun 22 2020, 10:31 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Jun 17 2020

Sbailey updated the task description for T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.
Jun 17 2020, 5:37 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

Jun 15 2020

Sbailey added a comment to T51538: Cite: Improve compatibility between Parsoid's port and the PHP extension.

Catalog of all Cite errors from Core Cite en.json array.

Jun 15 2020, 10:38 PM · MW-1.36-notes (1.36.0-wmf.16; 2020-11-03), Patch-For-Review, Parsing-Active-Work, Parsoid-Rendering, Parsoid

May 21 2020

Sbailey updated the task description for T251842: Proposal for Parsoid Cite error html generation.
May 21 2020, 3:33 PM · Parsing-Active-Work, Parsoid

May 20 2020

Sbailey added a comment to T251842: Proposal for Parsoid Cite error html generation.

Updated the specification to match recent discussion and the current implementation of patch https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/584746 which addresses aspects of Phab ticket T51538

May 20 2020, 11:08 PM · Parsing-Active-Work, Parsoid
Sbailey updated the task description for T251842: Proposal for Parsoid Cite error html generation.
May 20 2020, 11:06 PM · Parsing-Active-Work, Parsoid

May 15 2020

Sbailey added a comment to T251842: Proposal for Parsoid Cite error html generation.

Before I update the actual proposal, I am experimenting with changes to the "ref" and "reference" html generated.
The ref now does not include the class="error mw-ext-cite-error" and is set to the normal class="mw-ref" allowing normal display.
But it does include the data-mw={"errors":[{"key":{"cite_error_ref_no_input"}]} so code that cares can know there is an error and the i18n key is there to allow message text to be displayed internationally compliant.

May 15 2020, 1:02 AM · Parsing-Active-Work, Parsoid

May 7 2020

Sbailey updated the task description for T251842: Proposal for Parsoid Cite error html generation.
May 7 2020, 6:09 PM · Parsing-Active-Work, Parsoid
Sbailey updated the task description for T251842: Proposal for Parsoid Cite error html generation.
May 7 2020, 6:09 PM · Parsing-Active-Work, Parsoid
Sbailey updated the task description for T251842: Proposal for Parsoid Cite error html generation.
May 7 2020, 6:07 PM · Parsing-Active-Work, Parsoid
Sbailey added a comment to T251842: Proposal for Parsoid Cite error html generation.
May 7 2020, 5:54 PM · Parsing-Active-Work, Parsoid

May 5 2020

Sbailey updated the task description for T251842: Proposal for Parsoid Cite error html generation.
May 5 2020, 5:12 PM · Parsing-Active-Work, Parsoid

May 4 2020

Sbailey created T251842: Proposal for Parsoid Cite error html generation.
May 4 2020, 11:49 PM · Parsing-Active-Work, Parsoid

Mar 17 2020

Sbailey added a comment to T215628: Make Parsoid and PHP edit-section numbering consistent when <noinclude> and <includeonly> are in use.

A paused Gerrit patch for this exists that fixes one test but does not fix the test mentioned in comments in:
https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/577368

Mar 17 2020, 5:30 PM · Patch-For-Review, Parsoid
Sbailey placed T215628: Make Parsoid and PHP edit-section numbering consistent when <noinclude> and <includeonly> are in use up for grabs.

As advised by Subbu, there are two possible (probably correct) solutions to this bug beyond the partial fix that is here, but in fact is not correct for all circumstances as his note describes. Either a DOM based solution that walks the DOM and fixes the nested section ID's as a post process, or by taking advantage of the fact we no longer have asyncronous execution and having the $headingIndex, as set in line 54 of Grammar.php be set to an ongoing globally scoped state that increments appropriately and avoid ID's being reset to zero when new pipelines are created.

Mar 17 2020, 5:29 PM · Patch-For-Review, Parsoid

Mar 6 2020

Sbailey placed T95931: Parsoid automatically changes pseudo-interlanguage interwiki link text to match link prefix + full target page name up for grabs.
Mar 6 2020, 5:12 PM · Parsoid
Sbailey placed T69373: Parsoid shouldn't convert external links to interwiki links when the interwiki prefix matches a local namespace name up for grabs.
Mar 6 2020, 5:12 PM · Parsoid

Mar 4 2020

Sbailey claimed T215628: Make Parsoid and PHP edit-section numbering consistent when <noinclude> and <includeonly> are in use.
Mar 4 2020, 5:30 PM · Patch-For-Review, Parsoid
Sbailey added a comment to T237462: Port Parsoid/JS JSON extension to Parsoid/PHP.

JSON extension ported from JS to PHP complete.
1 Port-fixme is still present due to a dependence on addMetaData that is not avaialble yet to extensions.
Part of the addMetaData functionality was duplicated in the extension in the mean time.

Mar 4 2020, 3:52 PM · Parsoid-PHP

Feb 28 2020

Sbailey added a comment to T245877: Give all members of the Parsing team production `deployment` access ( add arlolra to deployers).

Subbu says yes to here it is:
ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABAQDCYenmO37Azx5fr7WO5F107ZL6g3o5AAgkLsGtheyCC9soguCltps4a2MBrw3nBMVXRPFSfJiTvsWARUC40d0oWxcqpXkRtHrY4mNzMMMz8lFzxRQ8ts+zKdU2KZJ8vaEhCnVmRemvIGE8xlaVPEleaAeyAZOjKxBaPVHB9CX7b0QgnZ+RTZRXi9BD1Aa0gnYurwJ5tA1nwPub0MRtGrkXhVaG78rUpkHECeM5BbmQoZnrvL4J9FdRkMkifEyHop+75RweUNbFhkiQ6pNia3MSMBC2tSYSL8IaLCqha8lFDkwHBNpzG09mpzFw1La6Niuth3CQ/72U9dQRvQFk+/Mp shannonbailey@wmf1287.local

Feb 28 2020, 4:15 PM · SRE, SRE-Access-Requests, serviceops, Parsoid-PHP
Sbailey added a comment to T245877: Give all members of the Parsing team production `deployment` access ( add arlolra to deployers).

Greg, do you really want me to post my public key in this form? or send it in a seperate message?

Feb 28 2020, 4:04 PM · SRE, SRE-Access-Requests, serviceops, Parsoid-PHP

Jan 21 2020

Sbailey claimed T237462: Port Parsoid/JS JSON extension to Parsoid/PHP.
Jan 21 2020, 7:56 PM · Parsoid-PHP
Sbailey claimed T235273: Remove PHPUtils::jsSort routine (or make it no-op) once Parsoid/JS is retired.
Jan 21 2020, 7:56 PM · Parsoid-PHP

Jan 6 2020

Sbailey claimed T241997: Create proper (documented!) class for Parsoid $attribs array.
Jan 6 2020, 11:15 PM · Parsoid

Dec 18 2019

Sbailey added a comment to T238845: Call to a member function serialize() on null.

I configured my local wiki to allow:

GroupPermissions['administrators']['suppressrevision'] = true;
and added 'suppressor' for revisions to my administrators
http://localhost:8080/index.php?title=Special%3AUserRights
account. I then used local user account to edit a page
and then used my admin account to edit it again. I captured
the other users edit oldid and used the admin account to
access the page history and used 'Change visibility of selected
revisions' button on right to suppress the ability to read that
old revision. This reproduced the bug and I found that
Api/PageConfig makeRequest( ... ) was not returned the [pages]
as designed, but our code was accessing that associative key
anyway without protection causing a crash.
Dec 18 2019, 7:47 PM · Parsoid-PHP
Sbailey added a comment to T238745: Argument 1 passed to Parsoid\Wt2Html\TokenTransformManager::processChunk() must be of the type array, boolean given.

I believe this is a duplicate of T238845 and is triggered by an editor electing to 'suppress' an edit revision which then causes the Api/PageConfig.php code call to makeRequest( ... ) to return associative array missing the ['pages'] elements appropriately, but the code then went and attempted to access ['pages'] anyway without protection causing a crash.
The fix for T238845 seems to fix this case as well.

Dec 18 2019, 7:46 PM · Parsoid-PHP

Dec 17 2019

Sbailey claimed T238745: Argument 1 passed to Parsoid\Wt2Html\TokenTransformManager::processChunk() must be of the type array, boolean given.
Dec 17 2019, 6:00 PM · Parsoid-PHP

Dec 16 2019

Sbailey closed T236415: Edge case category link output difference as Resolved.
Dec 16 2019, 3:29 PM · Parsoid-PHP

Dec 10 2019

Sbailey claimed T238845: Call to a member function serialize() on null.
Dec 10 2019, 6:19 PM · Parsoid-PHP

Dec 9 2019

Sbailey claimed T239252: Invariant failed: Bad SourceRange length.
Dec 9 2019, 4:20 PM · Parsoid-PHP

Nov 19 2019

Sbailey closed T237461: Parsoid/PHP LintLogger has gaps relative to Parsoid/JS, a subtask of T237326: Make Parsoid/PHP cluster read-write to ensure lints discovered by Parsoid/PHP are stored in the DB, as Resolved.
Nov 19 2019, 6:43 PM · Platform Engineering, User-WDoran, Parsoid-PHP
Sbailey closed T237461: Parsoid/PHP LintLogger has gaps relative to Parsoid/JS as Resolved.
Nov 19 2019, 6:43 PM · Parsoid-PHP

Nov 12 2019

Sbailey closed T236868: Invariant failed: Bad SourceRange length as Resolved.
Nov 12 2019, 6:21 PM · Parsoid-PHP

Nov 7 2019

Sbailey closed T236846: TemplateHandler.php: trim() expects parameter 1 to be string, boolean given as Resolved.

Fix for crash completed and fixes that produce desired behavior and correct wikitext and VE edit updates all implemented and tests written.

Nov 7 2019, 11:52 PM · Parsoid-PHP

Nov 6 2019

Sbailey claimed T237461: Parsoid/PHP LintLogger has gaps relative to Parsoid/JS.
Nov 6 2019, 5:13 PM · Parsoid-PHP

Nov 5 2019

Sbailey claimed T236846: TemplateHandler.php: trim() expects parameter 1 to be string, boolean given.
Nov 5 2019, 6:00 PM · Parsoid-PHP

Oct 31 2019

Sbailey claimed T236868: Invariant failed: Bad SourceRange length.
Oct 31 2019, 3:29 PM · Parsoid-PHP
Sbailey added a comment to T235231: Parsoid/JS video tag has a "seek" parameter in the URL that Parsoid/PHP video tag output doesn't.

Should be resolved by:
https://gerrit.wikimedia.org/r/547335

Oct 31 2019, 2:59 PM · Parsoid-PHP

Oct 24 2019

Sbailey placed T235777: Redlink differences between Parsoid/PHP and Parsoid/JS up for grabs.

Debugged both parsoid JS and PHP and without, and with --useBatchAPI enabled on parsoidJS, the class="new" does appear, but the redlinks code will not get called without that command line flag enabled. The parsoid PHP calls the redlink code without any command line flags required.
Unable to reproduce the error that occurred in the server environment, possibly missing --useBatchAPI?

Oct 24 2019, 6:27 PM · Parsoid-PHP

Oct 18 2019

Sbailey added a comment to T235709: Too many diffs on this page.

The JS Poem extension was also failing to properly handle the following (enhanced slightly WT below) and the PHP Poem was dramatically failing to produce viable HTML from:

Oct 18 2019, 11:56 PM · Parsoid-PHP

Oct 16 2019

Sbailey added a comment to T235231: Parsoid/JS video tag has a "seek" parameter in the URL that Parsoid/PHP video tag output doesn't.

Researched and attempted to reproduce using command line parse.php and in that mode, does not fail to match ParsoidJS in command line mode. The core parser also produces the seek correctly, but when ParsoidPHP is used in production mode, fails with local installation of mediawiki or on server installations.
I need to get my local mediawiki install back in running state after upgrading OSX to Catalina to continue.

Oct 16 2019, 9:35 PM · Parsoid-PHP