Page MenuHomePhabricator

Sbailey (Sbailey)
User

Projects (7)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Oct 4 2017, 8:49 PM (322 w, 3 d)
Availability
Available
LDAP User
Sbailey
MediaWiki User
SBailey (WMF) [ Global Accounts ]

Recent Activity

Mon, Dec 4

Sbailey moved T341369: Linter "missing end tag in heading" error is not listed on Special:LintErrors from In Progress to Code Review on the Content-Transform-Team-WIP board.
Mon, Dec 4, 5:30 PM · Patch-For-Review, Community-consensus-needed, Maintenance-Worktype, Content-Transform-Team-WIP, patch-welcome, MediaWiki-extensions-Linter
Sbailey moved T341369: Linter "missing end tag in heading" error is not listed on Special:LintErrors from Backlog to In Progress on the Content-Transform-Team-WIP board.
Mon, Dec 4, 5:30 PM · Patch-For-Review, Community-consensus-needed, Maintenance-Worktype, Content-Transform-Team-WIP, patch-welcome, MediaWiki-extensions-Linter

Mon, Nov 27

Sbailey moved T170874: Provide additional Linter statistics about template-generated issues from In Progress to Backlog on the Content-Transform-Team-WIP board.
Mon, Nov 27, 4:20 PM · Maintenance-Worktype, Content-Transform-Team-WIP, MediaWiki-extensions-Linter
Sbailey closed T231161: Add in/not in content namespace to Special:Linterrors, a subtask of T173178: Add "content namespaces" option to namespace dropdowns in special pages, as Resolved.
Mon, Nov 27, 4:16 PM · MediaWiki-Special-pages
Sbailey closed T231161: Add in/not in content namespace to Special:Linterrors as Resolved.
Mon, Nov 27, 4:15 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Maintenance-Worktype, Content-Transform-Team-WIP, MediaWiki-extensions-Linter

Wed, Nov 22

Sbailey closed T350599: UX for easy per-page opt-in/opt-out to Parsoid Read Views as Resolved.
Wed, Nov 22, 7:16 PM · Parsoid, Content-Transform-Team-WIP, Parsoid-Read-Views, MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), MediaWiki-extensions-ParserMigration

Nov 8 2023

Sbailey claimed T350599: UX for easy per-page opt-in/opt-out to Parsoid Read Views.
Nov 8 2023, 12:49 AM · Parsoid, Content-Transform-Team-WIP, Parsoid-Read-Views, MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), MediaWiki-extensions-ParserMigration

Nov 7 2023

Sbailey added a comment to T231161: Add in/not in content namespace to Special:Linterrors.

Jonesey95, thanks for pointing out that the action=info page parameter name for namespace was not updated to the new parameter name. I missed that :-(
It should be fixed in the next train deployment.

Nov 7 2023, 6:26 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Maintenance-Worktype, Content-Transform-Team-WIP, MediaWiki-extensions-Linter

Nov 3 2023

Sbailey added a comment to T231161: Add in/not in content namespace to Special:Linterrors.

Jonesey95,
I am glad this new feature is being used and working properly. And thanks for looking into getting dependent tools and gadgets adapted to the new parameter format.

Nov 3 2023, 4:22 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Maintenance-Worktype, Content-Transform-Team-WIP, MediaWiki-extensions-Linter
Sbailey added a comment to T231161: Add in/not in content namespace to Special:Linterrors.

Jonesey95 and colleagues,
I am sorry this change has altered the URL parameter definitions for namespaces. I had no choice as the multiple namespace widget used in the Linter search forms I needed to use has its own URL parameter style.
The format is now: for Main (Article), Talk and User Talk, for example uses the parameter keyword

Nov 3 2023, 3:56 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Maintenance-Worktype, Content-Transform-Team-WIP, MediaWiki-extensions-Linter

Oct 30 2023

Sbailey added a comment to T231161: Add in/not in content namespace to Special:Linterrors.

The multiple namespace selection feature is on the train and will be live on various wikis this week. I hope it better serves the needs of searching for lint errors and does not introduce any bugs. This is the last significant feature patch I will be working on for the Linter extension for a while beyond maintenance work and bug fixes as I transition to working on PCS and related caching subsystems.

Oct 30 2023, 5:36 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Maintenance-Worktype, Content-Transform-Team-WIP, MediaWiki-extensions-Linter

Oct 20 2023

Sbailey closed T349328: Removed Linter Extension string "linter-namespace-invert-error" from all i18n translations as Resolved.
Oct 20 2023, 3:01 PM · MediaWiki-extensions-Linter

Oct 19 2023

Sbailey added a comment to T349328: Removed Linter Extension string "linter-namespace-invert-error" from all i18n translations.

Ah I did not know that, Isabelle requested I remove the translated strings as a cleanup process but if it will be done automatically, all the better.
Thanks

Oct 19 2023, 8:34 PM · MediaWiki-extensions-Linter
Sbailey created T349328: Removed Linter Extension string "linter-namespace-invert-error" from all i18n translations.
Oct 19 2023, 5:00 PM · MediaWiki-extensions-Linter

Oct 17 2023

Sbailey updated the task description for T231161: Add in/not in content namespace to Special:Linterrors.
Oct 17 2023, 8:43 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Maintenance-Worktype, Content-Transform-Team-WIP, MediaWiki-extensions-Linter
Sbailey added a comment to T231161: Add in/not in content namespace to Special:Linterrors.

After going down a rabbit hole attempting to create namespace multiselection using checkboxes, based on how Search and RecentPage had coded it (as custom JS/CSS) only to hit an impass on formatting the checkboxes in a reasonable way as part of a larger HTMLForm, I switched to a new namespace multiselect capability recently added to mediawiki OOUI HTMLForm used by Special:Block. Bartosz pointed me at it (much WikiLove to Batrosz) and this new HTMLForm element works gloriously. The patch is now in review and will probably launch in Beta soon, then everywhere the following week.

Oct 17 2023, 8:40 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Maintenance-Worktype, Content-Transform-Team-WIP, MediaWiki-extensions-Linter

Oct 13 2023

Sbailey updated the task description for T333179: (Re)deploy ParserMigration extension to production.
Oct 13 2023, 7:38 PM · MW-1.42-notes (1.42.0-wmf.1; 2023-10-17), Parsoid-Read-Views (Phase 1 - DiscussionTools support), Wikimedia-extension-review-queue, Wikimedia-Extension-setup, MediaWiki-extensions-ParserMigration, Content-Transform-Team-WIP, Parsoid

Oct 6 2023

Sbailey updated the task description for T333179: (Re)deploy ParserMigration extension to production.
Oct 6 2023, 11:16 PM · MW-1.42-notes (1.42.0-wmf.1; 2023-10-17), Parsoid-Read-Views (Phase 1 - DiscussionTools support), Wikimedia-extension-review-queue, Wikimedia-Extension-setup, MediaWiki-extensions-ParserMigration, Content-Transform-Team-WIP, Parsoid

Oct 5 2023

Sbailey placed T335962: Update ContactPage for IP masking up for grabs.
Oct 5 2023, 4:44 PM · Maintenance-Worktype, Stewards-and-global-tools, Content-Transform-Team-WIP, Temporary accounts

Aug 22 2023

Sbailey added a comment to T231161: Add in/not in content namespace to Special:Linterrors.

Nearing completion of this task, final debugging and updating unit tests, creating new tests that exercise selecting multiple namespaces. The final bit of work will be to get the namespace checkboxes layout to look like other search pages that provide the same functionality.

Aug 22 2023, 9:17 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Maintenance-Worktype, Content-Transform-Team-WIP, MediaWiki-extensions-Linter

Aug 21 2023

Sbailey closed T245478: Add option to exclude errors from templates as Resolved.

The Special:LinterErrors page provides a with and without templates query filter providing this capability.

Aug 21 2023, 10:26 PM · Patch-For-Review, User-DannyS712, MediaWiki-extensions-Linter

Aug 2 2023

Sbailey added a comment to T333179: (Re)deploy ParserMigration extension to production.

I am following the previous phab/gerrit path used to release parser migration back in 2017:
https://phabricator.wikimedia.org/T141586
https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/344276

Aug 2 2023, 6:42 PM · MW-1.42-notes (1.42.0-wmf.1; 2023-10-17), Parsoid-Read-Views (Phase 1 - DiscussionTools support), Wikimedia-extension-review-queue, Wikimedia-Extension-setup, MediaWiki-extensions-ParserMigration, Content-Transform-Team-WIP, Parsoid
Sbailey added projects to T343292: Deprecate and then remove Linter config variables used to control new linter table field access: Content-Transform-Team-WIP, Maintenance-Worktype.
Aug 2 2023, 5:06 PM · Maintenance-Worktype, Content-Transform-Team-WIP, MediaWiki-extensions-Linter

Aug 1 2023

Sbailey updated the task description for T343292: Deprecate and then remove Linter config variables used to control new linter table field access.
Aug 1 2023, 11:54 PM · Maintenance-Worktype, Content-Transform-Team-WIP, MediaWiki-extensions-Linter
Sbailey claimed T343292: Deprecate and then remove Linter config variables used to control new linter table field access.
Aug 1 2023, 11:53 PM · Maintenance-Worktype, Content-Transform-Team-WIP, MediaWiki-extensions-Linter
Sbailey created T343292: Deprecate and then remove Linter config variables used to control new linter table field access.
Aug 1 2023, 11:53 PM · Maintenance-Worktype, Content-Transform-Team-WIP, MediaWiki-extensions-Linter
Sbailey renamed T331883: Cleanup linter code usage of params field during recordLintJob from Cleanup linter code usage of config variables and disabled old code and use of params field to Cleanup linter code usage of params field during recordLintJob.
Aug 1 2023, 11:50 PM · Maintenance-Worktype, Content-Transform-Team-WIP, MediaWiki-extensions-Linter
Sbailey updated the task description for T331883: Cleanup linter code usage of params field during recordLintJob.
Aug 1 2023, 11:48 PM · Maintenance-Worktype, Content-Transform-Team-WIP, MediaWiki-extensions-Linter

Jun 26 2023

Sbailey claimed T333179: (Re)deploy ParserMigration extension to production.
Jun 26 2023, 3:11 PM · MW-1.42-notes (1.42.0-wmf.1; 2023-10-17), Parsoid-Read-Views (Phase 1 - DiscussionTools support), Wikimedia-extension-review-queue, Wikimedia-Extension-setup, MediaWiki-extensions-ParserMigration, Content-Transform-Team-WIP, Parsoid

Jun 20 2023

Sbailey added a project to T170874: Provide additional Linter statistics about template-generated issues: Maintenance-Worktype.
Jun 20 2023, 2:31 PM · Maintenance-Worktype, Content-Transform-Team-WIP, MediaWiki-extensions-Linter
Sbailey added a project to T231161: Add in/not in content namespace to Special:Linterrors: Maintenance-Worktype.
Jun 20 2023, 2:31 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Maintenance-Worktype, Content-Transform-Team-WIP, MediaWiki-extensions-Linter
Sbailey added a project to T331883: Cleanup linter code usage of params field during recordLintJob: Maintenance-Worktype.
Jun 20 2023, 2:30 PM · Maintenance-Worktype, Content-Transform-Team-WIP, MediaWiki-extensions-Linter
Sbailey added a project to T165538: Need a mechanism / process to purge invalid / stale entries from the Linter database: Maintenance-Worktype.
Jun 20 2023, 2:30 PM · Maintenance-Worktype, Content-Transform-Team-WIP, MediaWiki-extensions-Linter

Jun 14 2023

Sbailey added a comment to T231161: Add in/not in content namespace to Special:Linterrors.

Another 'filter' that I think might be useful is specific to a Wikisource use case:-

And that is the ability to filter by the quality levels used by Extension:Proofread page for it's content model.

This means that I can focus attention on edits to page already "validated" or proofread and thus which have a greater chance of being transcluded elsewhere.

The current interface for Special LintErrors doesn't have a page quality filter, which means I am currently using a pywikibot script on PAWS to filter it down manually. This is not ideal...

Jun 14 2023, 5:59 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Maintenance-Worktype, Content-Transform-Team-WIP, MediaWiki-extensions-Linter

Jun 12 2023

Sbailey moved T231161: Add in/not in content namespace to Special:Linterrors from Backlog to In Progress on the Content-Transform-Team-WIP board.
Jun 12 2023, 3:30 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Maintenance-Worktype, Content-Transform-Team-WIP, MediaWiki-extensions-Linter
Sbailey added a project to T231161: Add in/not in content namespace to Special:Linterrors: Content-Transform-Team-WIP.
Jun 12 2023, 3:29 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Maintenance-Worktype, Content-Transform-Team-WIP, MediaWiki-extensions-Linter
Sbailey changed the status of T231161: Add in/not in content namespace to Special:Linterrors from Open to In Progress.
Jun 12 2023, 3:27 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Maintenance-Worktype, Content-Transform-Team-WIP, MediaWiki-extensions-Linter
Sbailey changed the status of T231161: Add in/not in content namespace to Special:Linterrors, a subtask of T173178: Add "content namespaces" option to namespace dropdowns in special pages, from Open to In Progress.
Jun 12 2023, 3:27 PM · MediaWiki-Special-pages

Jun 8 2023

Sbailey moved T338204: Some page previews for locations only show coordinates and no useful text on cards from Code Review to To Verify on the Content-Transform-Team-WIP board.
Jun 8 2023, 2:22 PM · Web-Team-Backlog, Maintenance-Worktype, Page Content Service, Content-Transform-Team-WIP, Page-Previews
Sbailey removed a project from T338204: Some page previews for locations only show coordinates and no useful text on cards: Patch-For-Review.
Jun 8 2023, 2:20 PM · Web-Team-Backlog, Maintenance-Worktype, Page Content Service, Content-Transform-Team-WIP, Page-Previews

Jun 2 2023

Sbailey added a comment to T335962: Update ContactPage for IP masking.

Thanks Arlo, also had to create a recipient account and fix the recipientUser string to match and then things worked.

Jun 2 2023, 5:03 PM · Maintenance-Worktype, Stewards-and-global-tools, Content-Transform-Team-WIP, Temporary accounts

Jun 1 2023

Sbailey added a comment to T335962: Update ContactPage for IP masking.

I can apply this change, but without commenting out lines 132-135 in SpecialContact.php like this, I cannot ever reach line 164, so unless I am missing something, this code is currently unreachable, or I cannot create a test environment condition with a logged out browser to reach it as a temporary user, which also maybe a configuration I have not set correctly in my local wiki instance:

Jun 1 2023, 10:09 PM · Maintenance-Worktype, Stewards-and-global-tools, Content-Transform-Team-WIP, Temporary accounts
Sbailey added a comment to T335962: Update ContactPage for IP masking.

If I understand this correctly, the code as is appropriately reports the IP address in a contact page email and is/maybe needed to aid in an IP block appeal exemption, and as such removing the IP here is not correct nor appropriate as part of the ongoing IPMasking issue. Let me know if I should close this ticket, or let others comment/review.

Jun 1 2023, 8:24 PM · Maintenance-Worktype, Stewards-and-global-tools, Content-Transform-Team-WIP, Temporary accounts
Xaosflux awarded T335962: Update ContactPage for IP masking a Like token.
Jun 1 2023, 8:05 PM · Maintenance-Worktype, Stewards-and-global-tools, Content-Transform-Team-WIP, Temporary accounts

May 31 2023

Sbailey moved T337275: Filter out large-table lint records from core rest API to fix LintHint being overwhelmed with spurious large-tables lint records from Backlog to Deployed on the MediaWiki-extensions-Linter board.
May 31 2023, 5:58 PM · MW-1.41-notes (1.41.0-wmf.11; 2023-05-30), MediaWiki-extensions-Linter
Sbailey claimed T335962: Update ContactPage for IP masking.
May 31 2023, 5:00 PM · Maintenance-Worktype, Stewards-and-global-tools, Content-Transform-Team-WIP, Temporary accounts

May 26 2023

Sbailey added a comment to T337275: Filter out large-table lint records from core rest API to fix LintHint being overwhelmed with spurious large-tables lint records.

I think we should ship the large-tables lint suppressing code for the Parsoid rest API and then back it out once the replacement large-tables lint code is in production. This will help LintHint be usable again, later next week.

May 26 2023, 4:06 PM · MW-1.41-notes (1.41.0-wmf.11; 2023-05-30), MediaWiki-extensions-Linter
Sbailey renamed T337275: Filter out large-table lint records from core rest API to fix LintHint being overwhelmed with spurious large-tables lint records from Filter out large-table lint records from core rest API to fix LintHint being overwhelmed with spurious large table lint records to Filter out large-table lint records from core rest API to fix LintHint being overwhelmed with spurious large-tables lint records.
May 26 2023, 4:05 PM · MW-1.41-notes (1.41.0-wmf.11; 2023-05-30), MediaWiki-extensions-Linter

May 25 2023

Sbailey added a comment to T337275: Filter out large-table lint records from core rest API to fix LintHint being overwhelmed with spurious large-tables lint records.

Hmm, nested tables create false positives, test coverage was inadequate.
Maybe we just drop a return at the start of the current large-tables lint code in Parsoid until this lint code gets rewritten?

May 25 2023, 11:07 PM · MW-1.41-notes (1.41.0-wmf.11; 2023-05-30), MediaWiki-extensions-Linter
Sbailey added a comment to T337275: Filter out large-table lint records from core rest API to fix LintHint being overwhelmed with spurious large-tables lint records.

For now, filtering in ParsoidHandler should help LintHint avoid being swamped with large-tables lints.
Next step I think is to implement inside Parsoid, a "internal" versus "exposed" or something like that flag that large-tables can use to hide these not WT errors, but useful diagnostic or research lints behind.

May 25 2023, 6:29 PM · MW-1.41-notes (1.41.0-wmf.11; 2023-05-30), MediaWiki-extensions-Linter
Jdlrobson awarded T337275: Filter out large-table lint records from core rest API to fix LintHint being overwhelmed with spurious large-tables lint records a Love token.
May 25 2023, 4:55 AM · MW-1.41-notes (1.41.0-wmf.11; 2023-05-30), MediaWiki-extensions-Linter

May 23 2023

Sbailey updated the task description for T337275: Filter out large-table lint records from core rest API to fix LintHint being overwhelmed with spurious large-tables lint records.
May 23 2023, 2:55 PM · MW-1.41-notes (1.41.0-wmf.11; 2023-05-30), MediaWiki-extensions-Linter
Sbailey updated subscribers of T337275: Filter out large-table lint records from core rest API to fix LintHint being overwhelmed with spurious large-tables lint records.
May 23 2023, 2:53 PM · MW-1.41-notes (1.41.0-wmf.11; 2023-05-30), MediaWiki-extensions-Linter
Sbailey updated subscribers of T337275: Filter out large-table lint records from core rest API to fix LintHint being overwhelmed with spurious large-tables lint records.
May 23 2023, 2:41 PM · MW-1.41-notes (1.41.0-wmf.11; 2023-05-30), MediaWiki-extensions-Linter
Sbailey created T337275: Filter out large-table lint records from core rest API to fix LintHint being overwhelmed with spurious large-tables lint records.
May 23 2023, 1:01 AM · MW-1.41-notes (1.41.0-wmf.11; 2023-05-30), MediaWiki-extensions-Linter

May 16 2023

Sbailey added a comment to T334528: Create linting rule for large tables.

Got it, excellent, your on it :-)
Will add myself as a reviewer if not already included.
Thanks

May 16 2023, 5:21 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Patch-For-Review, Parsoid, Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2), Desktop Improvements (Vector 2022), MobileFrontend (Tracking), MinervaNeue (Tracking), Design, Technical-Debt
Sbailey added a comment to T334528: Create linting rule for large tables.

Large-tables lint still requires a follow on patch to avoid a serious performance problem when tables greater than 1000 rows are encountered, looking at the number of rows and if under some threshold, checking them all, and over that threshold, looking at the first few rows and header row.

May 16 2023, 5:08 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Patch-For-Review, Parsoid, Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2), Desktop Improvements (Vector 2022), MobileFrontend (Tracking), MinervaNeue (Tracking), Design, Technical-Debt

May 15 2023

Sbailey added a comment to T308398: Unclosed tags in parser content causes Vector 2022 skin cause display issues (strikethrough and italic tags) and should be flagged by linter.
May 15 2023, 9:28 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Patch-For-Review, Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3), Parsoid, Desktop Improvements (Vector 2022)
Sbailey added a comment to T308398: Unclosed tags in parser content causes Vector 2022 skin cause display issues (strikethrough and italic tags) and should be flagged by linter.

I believe it is riding this weeks train, it was in beta as of last thursday
to allow QA to test. Once group 2 deploys we should start seeing entries.
Shannon

May 15 2023, 9:28 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Patch-For-Review, Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3), Parsoid, Desktop Improvements (Vector 2022)
Sbailey added a comment to T308398: Unclosed tags in parser content causes Vector 2022 skin cause display issues (strikethrough and italic tags) and should be flagged by linter.

I am researching and also cannot duplicate his false positives using:
https://en.wikipedia.beta.wmflabs.org/wiki/Special:LintErrors/missing-end-tag-in-heading

May 15 2023, 7:54 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Patch-For-Review, Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 3), Parsoid, Desktop Improvements (Vector 2022)

Apr 20 2023

Sbailey added a comment to T334528: Create linting rule for large tables.

Hacked up a bit of test code in php to aid in the process of adapting the javascript snippet to be a linter rule in Parsoid using Parsoids DOM utils. Hoping Parsoid team members with more expertise in html pattern possibilities can comment on the snippet and this codes deficiencies or edge cases where it would fail to detect tables with more than 5 columns based on the html that can exist and be generated by Parsoid. This code can be run standalone :-)

Apr 20 2023, 8:50 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), Patch-For-Review, Parsoid, Web-Team-Backlog (Web Team FY2022-23 Q4 Sprint 2), Desktop Improvements (Vector 2022), MobileFrontend (Tracking), MinervaNeue (Tracking), Design, Technical-Debt

Apr 13 2023

Sbailey claimed T334527: Allow registration of hidden lint rules.

I will look at this worthy request. It is easy to suppress a new category from being displayed in the Special:LintError page displaying all categories, but linter errors of the new category may still display using other search features. I will consult with folks further about how accessing these hidden lint rule "errors" should be handled, if they should be searchable using the search filter form, or only using a quarry database direct SQL query.

Apr 13 2023, 6:19 PM · MW-1.41-notes (1.41.0-wmf.10; 2023-05-23), MediaWiki-extensions-Linter

Apr 3 2023

Sbailey closed T312434: Migrate usage of Database::select to SelectQueryBuilder in Linter as Resolved.
Apr 3 2023, 3:11 PM · MW-1.41-notes (1.41.0-wmf.2; 2023-03-27), MediaWiki-extensions-Linter, Technical-Debt
Sbailey closed T312434: Migrate usage of Database::select to SelectQueryBuilder in Linter, a subtask of T311866: Migrate Database::select usages to SelectQueryBuilder, as Resolved.
Apr 3 2023, 3:11 PM · MW-1.41-notes (1.41.0-wmf.25; 2023-09-05), MW-1.40-notes (1.40.0-wmf.26; 2023-03-06), MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), Patch-For-Review, Data-Persistence (work done), Platform Engineering
Sbailey edited projects for T274382: Make File syntax processing match the specification and documentation, added: MediaWiki-extensions-Linter, Content-Transform-Team; removed Outreach-Programs-Projects.
Apr 3 2023, 2:46 PM · Parsoid, MediaWiki-extensions-Linter
Sbailey reopened T274382: Make File syntax processing match the specification and documentation as "Open".

Not sure why me or Arlo were not pinged to act as a mentor, a year ago, I am just seeing this for the first time. While it may not be suitable as a task for the Outreach program, the issue itself looks like it should be triaged at a minimum and might be something I look into, placing it on my backlog.

Apr 3 2023, 2:45 PM · Parsoid, MediaWiki-extensions-Linter

Mar 20 2023

Sbailey moved T170874: Provide additional Linter statistics about template-generated issues from Backlog to In Progress on the Content-Transform-Team-WIP board.
Mar 20 2023, 3:20 PM · Maintenance-Worktype, Content-Transform-Team-WIP, MediaWiki-extensions-Linter
Sbailey added a project to T170874: Provide additional Linter statistics about template-generated issues: Content-Transform-Team-WIP.
Mar 20 2023, 3:20 PM · Maintenance-Worktype, Content-Transform-Team-WIP, MediaWiki-extensions-Linter
Sbailey moved T312434: Migrate usage of Database::select to SelectQueryBuilder in Linter from Backlog to Code Review on the Content-Transform-Team-WIP board.
Mar 20 2023, 3:17 PM · MW-1.41-notes (1.41.0-wmf.2; 2023-03-27), MediaWiki-extensions-Linter, Technical-Debt

Mar 13 2023

Sbailey added a project to T165538: Need a mechanism / process to purge invalid / stale entries from the Linter database: Content-Transform-Team-WIP.
Mar 13 2023, 3:21 PM · Maintenance-Worktype, Content-Transform-Team-WIP, MediaWiki-extensions-Linter
Sbailey added a project to T312434: Migrate usage of Database::select to SelectQueryBuilder in Linter: Content-Transform-Team-WIP.
Mar 13 2023, 3:19 PM · MW-1.41-notes (1.41.0-wmf.2; 2023-03-27), MediaWiki-extensions-Linter, Technical-Debt
Sbailey created T331883: Cleanup linter code usage of params field during recordLintJob.
Mar 13 2023, 3:18 PM · Maintenance-Worktype, Content-Transform-Team-WIP, MediaWiki-extensions-Linter
Sbailey closed T175177: Linter UI: Provide option to filter linter errors by second column (ex: obsolete tag, missing end tag, stripped tag, etc) as Resolved.
Mar 13 2023, 3:07 PM · MW-1.40-notes (1.40.0-wmf.25; 2023-02-27), Content-Transform-Team-WIP, MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), MW-1.38-notes (1.38.0-wmf.21; 2022-02-07), Patch-For-Review, MediaWiki-extensions-Linter

Mar 10 2023

Sbailey moved T260782: Additional sort/filter options for Special:LintErrors ( Filter structural vs Cosmetic missing tags; sort by page views; filter by Template called) from Linter-UI to Backlog on the MediaWiki-extensions-Linter board.
Mar 10 2023, 9:39 PM · MediaWiki-extensions-Linter
Sbailey moved T260782: Additional sort/filter options for Special:LintErrors ( Filter structural vs Cosmetic missing tags; sort by page views; filter by Template called) from Backlog to Linter-UI on the MediaWiki-extensions-Linter board.
Mar 10 2023, 9:37 PM · MediaWiki-extensions-Linter

Mar 9 2023

Sbailey added a comment to T231161: Add in/not in content namespace to Special:Linterrors.

Research so far:
Looking at what it will take to allow arbitrary namespace selection instead of single namespace with invert checkbox that selects all but the selected namespace.
appears to take a fair bit of code such as in SearchFormWidget.php and would require additional query adjustments.
Estimate this as a medium to hard (take a couple weeks) to get working and polished, and if javascript needs updating, additional time.
Wondering how important this capability is to the community.

Mar 9 2023, 11:14 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Maintenance-Worktype, Content-Transform-Team-WIP, MediaWiki-extensions-Linter
Sbailey moved T175177: Linter UI: Provide option to filter linter errors by second column (ex: obsolete tag, missing end tag, stripped tag, etc) from To Deploy to To Verify on the Content-Transform-Team-WIP board.
Mar 9 2023, 3:11 PM · MW-1.40-notes (1.40.0-wmf.25; 2023-02-27), Content-Transform-Team-WIP, MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), MW-1.38-notes (1.38.0-wmf.21; 2022-02-07), Patch-For-Review, MediaWiki-extensions-Linter

Mar 8 2023

Sbailey moved T245478: Add option to exclude errors from templates from Linter-UI to Deployed on the MediaWiki-extensions-Linter board.
Mar 8 2023, 10:24 PM · Patch-For-Review, User-DannyS712, MediaWiki-extensions-Linter
Sbailey moved T175177: Linter UI: Provide option to filter linter errors by second column (ex: obsolete tag, missing end tag, stripped tag, etc) from Linter-UI to Deployed on the MediaWiki-extensions-Linter board.
Mar 8 2023, 10:24 PM · MW-1.40-notes (1.40.0-wmf.25; 2023-02-27), Content-Transform-Team-WIP, MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), MW-1.38-notes (1.38.0-wmf.21; 2022-02-07), Patch-For-Review, MediaWiki-extensions-Linter

Mar 7 2023

Sbailey moved T312434: Migrate usage of Database::select to SelectQueryBuilder in Linter from Backlog to Linter-UI on the MediaWiki-extensions-Linter board.
Mar 7 2023, 8:16 PM · MW-1.41-notes (1.41.0-wmf.2; 2023-03-27), MediaWiki-extensions-Linter, Technical-Debt

Mar 6 2023

Sbailey claimed T312434: Migrate usage of Database::select to SelectQueryBuilder in Linter.
Mar 6 2023, 10:02 PM · MW-1.41-notes (1.41.0-wmf.2; 2023-03-27), MediaWiki-extensions-Linter, Technical-Debt
Sbailey added a comment to T312434: Migrate usage of Database::select to SelectQueryBuilder in Linter.

Ah I see, will look at fixing all of these. Seems like there could be minor risk of breaking something so will test carefully.

Mar 6 2023, 10:02 PM · MW-1.41-notes (1.41.0-wmf.2; 2023-03-27), MediaWiki-extensions-Linter, Technical-Debt
Sbailey added a comment to T312434: Migrate usage of Database::select to SelectQueryBuilder in Linter.

This change appears to have been completed.
Cannot find references to Database::select(

Mar 6 2023, 8:57 PM · MW-1.41-notes (1.41.0-wmf.2; 2023-03-27), MediaWiki-extensions-Linter, Technical-Debt
Sbailey claimed T165538: Need a mechanism / process to purge invalid / stale entries from the Linter database.

Part of this should be resolved by T165538 - gerrit 761070 when content model changes.

Mar 6 2023, 8:46 PM · Maintenance-Worktype, Content-Transform-Team-WIP, MediaWiki-extensions-Linter
Sbailey claimed T171788: On wikis without changeprop enabled, lint errors don't update after page edits.

Once RESTBase has be replaced, this issue should be resolved.
Need to verify this is resolved after that takes place.

Mar 6 2023, 8:36 PM · Parsoid (Tracking), Platform Team Legacy (Designing), Services (designing), wikitech.wikimedia.org, MediaWiki-extensions-Linter
Sbailey claimed T170874: Provide additional Linter statistics about template-generated issues.

Now that there is a linter_template text field in the database, adding features like this is now feasible.
Evaluating feature list value and prioritizing.

Mar 6 2023, 6:58 PM · Maintenance-Worktype, Content-Transform-Team-WIP, MediaWiki-extensions-Linter

Mar 2 2023

Sbailey added a comment to T231161: Add in/not in content namespace to Special:Linterrors.

Hmm, I see.

Mar 2 2023, 10:14 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Maintenance-Worktype, Content-Transform-Team-WIP, MediaWiki-extensions-Linter
Sbailey claimed T151282: Linter: Improve sorting.

As the Linter UI can select a single page by Title or Title Prefix, from the search form found under the category list in the main Special:LinterErrors page, my hope is that this provides an adequate report focussing on just one pages errors. Using it, I can navigate from the reports error links to the wiki page, fix the highlighted error, save and then return to the report and select the next error. While not as convenient as LintHint which inspires me, hopefully it is adequate for others who don't use LintHint.

Mar 2 2023, 8:35 PM · MediaWiki-extensions-Linter
Sbailey changed the status of T245478: Add option to exclude errors from templates from Stalled to In Progress.

Three new columns have been added to the Linter table, are being written in all production wikis and the linter_params data was migrated in old records to be the same as newly written records using maintenance scripts.

Mar 2 2023, 8:20 PM · Patch-For-Review, User-DannyS712, MediaWiki-extensions-Linter
Sbailey claimed T231161: Add in/not in content namespace to Special:Linterrors.

Question: does the current namespace selection and invert selection check box adequately cover this feature request sufficiently. It does allow the exclusion of talk namespace while including all others.

Mar 2 2023, 7:57 PM · MW-1.42-notes (1.42.0-wmf.5; 2023-11-14), Maintenance-Worktype, Content-Transform-Team-WIP, MediaWiki-extensions-Linter

Feb 27 2023

Sbailey closed T329342: Enable maintenance Linter data migration scripts for namespace and tag and template as Resolved.
Feb 27 2023, 4:18 PM · MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), MediaWiki-extensions-Linter
Sbailey closed T291513: Review schema changes for T175177 as Resolved.
Feb 27 2023, 4:16 PM · Data-Persistence (work done), MediaWiki-extensions-Linter
Sbailey closed T299612: Add namespace column and index to table as Resolved.

Field added, maintenance migrate run and results verified in Beta and production.

Feb 27 2023, 4:15 PM · MW-1.40-notes (1.40.0-wmf.25; 2023-02-27), Content-Transform-Team-WIP, MediaWiki-Maintenance-system, MediaWiki-extensions-Linter, MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), MW-1.38-notes (1.38.0-wmf.20; 2022-01-31), Patch-For-Review, Documentation

Feb 23 2023

Sbailey added a comment to T329766: Run the maintenance script linter extension migrateTagTemplate.php on all wikis.

Each linter_cat category defines what linter_params content is relevant and many categories do not have tag or template data. I did some quick checks using Quarry and all looks good for categories that should and should not have content in those fields. Some of the checks are listed below:

Feb 23 2023, 8:45 PM · MediaWiki-extensions-Linter, Wikimedia-maintenance-script-run

Feb 16 2023

Sbailey added a comment to T329764: Run the maintenance script linter extension migrateNamespace.php on all wikis.

Ah sorry, the logger interface was recommended. I wish I had known about its quirks and limitations. Live and learn. Next time I will just output to console.

Feb 16 2023, 6:24 PM · MediaWiki-extensions-Linter, Wikimedia-maintenance-script-run
Sbailey added a comment to T329764: Run the maintenance script linter extension migrateNamespace.php on all wikis.

There is logging in both scripts:

		$logger = LoggerFactory::getInstance( 'MigrateNamespaceChannel' );

. . .

			$logger->info( 'Migrated ' . $updated . " page IDs\n" );
Feb 16 2023, 3:20 PM · MediaWiki-extensions-Linter, Wikimedia-maintenance-script-run

Feb 15 2023

Sbailey created T329766: Run the maintenance script linter extension migrateTagTemplate.php on all wikis.
Feb 15 2023, 5:03 PM · MediaWiki-extensions-Linter, Wikimedia-maintenance-script-run
Sbailey created T329764: Run the maintenance script linter extension migrateNamespace.php on all wikis.
Feb 15 2023, 4:59 PM · MediaWiki-extensions-Linter, Wikimedia-maintenance-script-run

Feb 14 2023

Sbailey updated the task description for T329342: Enable maintenance Linter data migration scripts for namespace and tag and template.
Feb 14 2023, 4:27 PM · MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), MediaWiki-extensions-Linter

Feb 10 2023

Sbailey created T329342: Enable maintenance Linter data migration scripts for namespace and tag and template.
Feb 10 2023, 1:48 AM · MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), MediaWiki-extensions-Linter