Page MenuHomePhabricator

Sbailey (Sbailey)
User

Projects (7)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 4 2017, 8:49 PM (284 w, 6 d)
Availability
Available
LDAP User
Sbailey
MediaWiki User
SBailey (WMF) [ Global Accounts ]

Recent Activity

Mon, Mar 20

Sbailey moved T170874: Provide additional Linter statistics about template-generated issues from Backlog to In Progress on the Content-Transform-Team-WIP board.
Mon, Mar 20, 3:20 PM · Content-Transform-Team-WIP, MediaWiki-extensions-Linter
Sbailey added a project to T170874: Provide additional Linter statistics about template-generated issues: Content-Transform-Team-WIP.
Mon, Mar 20, 3:20 PM · Content-Transform-Team-WIP, MediaWiki-extensions-Linter
Sbailey moved T312434: Migrate usage of Database::select to SelectQueryBuilder in Linter from Backlog to Code Review on the Content-Transform-Team-WIP board.
Mon, Mar 20, 3:17 PM · Content-Transform-Team-WIP, Patch-For-Review, MediaWiki-extensions-Linter, Technical-Debt

Mon, Mar 13

Sbailey added a project to T165538: Need a mechanism / process to purge invalid / stale entries from the Linter database: Content-Transform-Team-WIP.
Mon, Mar 13, 3:21 PM · Content-Transform-Team-WIP, MediaWiki-extensions-Linter
Sbailey added a project to T312434: Migrate usage of Database::select to SelectQueryBuilder in Linter: Content-Transform-Team-WIP.
Mon, Mar 13, 3:19 PM · Content-Transform-Team-WIP, Patch-For-Review, MediaWiki-extensions-Linter, Technical-Debt
Sbailey created T331883: Cleanup linter code usage of config variables and disabled old code and use of params field.
Mon, Mar 13, 3:18 PM · Content-Transform-Team-WIP, MediaWiki-extensions-Linter
Sbailey closed T175177: Linter UI: Provide option to filter linter errors by second column (ex: obsolete tag, missing end tag, stripped tag, etc) as Resolved.
Mon, Mar 13, 3:07 PM · MW-1.40-notes (1.40.0-wmf.25; 2023-02-27), Content-Transform-Team-WIP, MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), MW-1.38-notes (1.38.0-wmf.21; 2022-02-07), Patch-For-Review, MediaWiki-extensions-Linter

Fri, Mar 10

Sbailey moved T260782: Additional sort/filter options for Special:LintErrors ( Filter structural vs Cosmetic missing tags; sort by page views; filter by Template called) from Linter-UI to Backlog on the MediaWiki-extensions-Linter board.
Fri, Mar 10, 9:39 PM · MediaWiki-extensions-Linter
Sbailey moved T260782: Additional sort/filter options for Special:LintErrors ( Filter structural vs Cosmetic missing tags; sort by page views; filter by Template called) from Backlog to Linter-UI on the MediaWiki-extensions-Linter board.
Fri, Mar 10, 9:37 PM · MediaWiki-extensions-Linter

Thu, Mar 9

Sbailey added a comment to T231161: Add in/not in content namespace to Special:Linterrors.

Research so far:
Looking at what it will take to allow arbitrary namespace selection instead of single namespace with invert checkbox that selects all but the selected namespace.
appears to take a fair bit of code such as in SearchFormWidget.php and would require additional query adjustments.
Estimate this as a medium to hard (take a couple weeks) to get working and polished, and if javascript needs updating, additional time.
Wondering how important this capability is to the community.

Thu, Mar 9, 11:14 PM · MediaWiki-extensions-Linter
Sbailey moved T175177: Linter UI: Provide option to filter linter errors by second column (ex: obsolete tag, missing end tag, stripped tag, etc) from To Deploy to To Verify on the Content-Transform-Team-WIP board.
Thu, Mar 9, 3:11 PM · MW-1.40-notes (1.40.0-wmf.25; 2023-02-27), Content-Transform-Team-WIP, MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), MW-1.38-notes (1.38.0-wmf.21; 2022-02-07), Patch-For-Review, MediaWiki-extensions-Linter

Wed, Mar 8

Sbailey moved T245478: Add option to exclude errors from templates from Linter-UI to Deployed on the MediaWiki-extensions-Linter board.
Wed, Mar 8, 10:24 PM · Patch-For-Review, MediaWiki-extensions-Linter, User-DannyS712
Sbailey moved T175177: Linter UI: Provide option to filter linter errors by second column (ex: obsolete tag, missing end tag, stripped tag, etc) from Linter-UI to Deployed on the MediaWiki-extensions-Linter board.
Wed, Mar 8, 10:24 PM · MW-1.40-notes (1.40.0-wmf.25; 2023-02-27), Content-Transform-Team-WIP, MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), MW-1.38-notes (1.38.0-wmf.21; 2022-02-07), Patch-For-Review, MediaWiki-extensions-Linter

Tue, Mar 7

Sbailey moved T312434: Migrate usage of Database::select to SelectQueryBuilder in Linter from Backlog to Linter-UI on the MediaWiki-extensions-Linter board.
Tue, Mar 7, 8:16 PM · Content-Transform-Team-WIP, Patch-For-Review, MediaWiki-extensions-Linter, Technical-Debt

Mon, Mar 6

Sbailey claimed T312434: Migrate usage of Database::select to SelectQueryBuilder in Linter.
Mon, Mar 6, 10:02 PM · Content-Transform-Team-WIP, Patch-For-Review, MediaWiki-extensions-Linter, Technical-Debt
Sbailey added a comment to T312434: Migrate usage of Database::select to SelectQueryBuilder in Linter.

Ah I see, will look at fixing all of these. Seems like there could be minor risk of breaking something so will test carefully.

Mon, Mar 6, 10:02 PM · Content-Transform-Team-WIP, Patch-For-Review, MediaWiki-extensions-Linter, Technical-Debt
Sbailey added a comment to T312434: Migrate usage of Database::select to SelectQueryBuilder in Linter.

This change appears to have been completed.
Cannot find references to Database::select(

Mon, Mar 6, 8:57 PM · Content-Transform-Team-WIP, Patch-For-Review, MediaWiki-extensions-Linter, Technical-Debt
Sbailey claimed T165538: Need a mechanism / process to purge invalid / stale entries from the Linter database.

Part of this should be resolved by T165538 - gerrit 761070 when content model changes.

Mon, Mar 6, 8:46 PM · Content-Transform-Team-WIP, MediaWiki-extensions-Linter
Sbailey claimed T171788: On wikis without changeprop enabled, lint errors don't update after page edits.

Once RESTBase has be replaced, this issue should be resolved.
Need to verify this is resolved after that takes place.

Mon, Mar 6, 8:36 PM · Parsoid (Tracking), Platform Team Legacy (Designing), Services (designing), wikitech.wikimedia.org, MediaWiki-extensions-Linter
Sbailey claimed T170874: Provide additional Linter statistics about template-generated issues.

Now that there is a linter_template text field in the database, adding features like this is now feasible.
Evaluating feature list value and prioritizing.

Mon, Mar 6, 6:58 PM · Content-Transform-Team-WIP, MediaWiki-extensions-Linter

Thu, Mar 2

Sbailey added a comment to T231161: Add in/not in content namespace to Special:Linterrors.

Hmm, I see.

Thu, Mar 2, 10:14 PM · MediaWiki-extensions-Linter
Sbailey claimed T151282: Linter: Improve sorting.

As the Linter UI can select a single page by Title or Title Prefix, from the search form found under the category list in the main Special:LinterErrors page, my hope is that this provides an adequate report focussing on just one pages errors. Using it, I can navigate from the reports error links to the wiki page, fix the highlighted error, save and then return to the report and select the next error. While not as convenient as LintHint which inspires me, hopefully it is adequate for others who don't use LintHint.

Thu, Mar 2, 8:35 PM · MediaWiki-extensions-Linter
Sbailey changed the status of T245478: Add option to exclude errors from templates from Stalled to In Progress.

Three new columns have been added to the Linter table, are being written in all production wikis and the linter_params data was migrated in old records to be the same as newly written records using maintenance scripts.

Thu, Mar 2, 8:20 PM · Patch-For-Review, MediaWiki-extensions-Linter, User-DannyS712
Sbailey claimed T231161: Add in/not in content namespace to Special:Linterrors.

Question: does the current namespace selection and invert selection check box adequately cover this feature request sufficiently. It does allow the exclusion of talk namespace while including all others.

Thu, Mar 2, 7:57 PM · MediaWiki-extensions-Linter

Mon, Feb 27

Sbailey closed T329342: Enable maintenance Linter data migration scripts for namespace and tag and template as Resolved.
Mon, Feb 27, 4:18 PM · MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), MediaWiki-extensions-Linter
Sbailey closed T291513: Review schema changes for T175177 as Resolved.
Mon, Feb 27, 4:16 PM · Data-Persistence (work done), MediaWiki-extensions-Linter
Sbailey closed T299612: Add namespace column and index to table as Resolved.

Field added, maintenance migrate run and results verified in Beta and production.

Mon, Feb 27, 4:15 PM · MW-1.40-notes (1.40.0-wmf.25; 2023-02-27), Content-Transform-Team-WIP, MediaWiki-Maintenance-system, MediaWiki-extensions-Linter, MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), MW-1.38-notes (1.38.0-wmf.20; 2022-01-31), Patch-For-Review, Documentation

Thu, Feb 23

Sbailey added a comment to T329766: Run the maintenance script linter extension migrateTagTemplate.php on all wikis.

Each linter_cat category defines what linter_params content is relevant and many categories do not have tag or template data. I did some quick checks using Quarry and all looks good for categories that should and should not have content in those fields. Some of the checks are listed below:

Thu, Feb 23, 8:45 PM · MediaWiki-extensions-Linter, Wikimedia-maintenance-script-run

Feb 16 2023

Sbailey added a comment to T329764: Run the maintenance script linter extension migrateNamespace.php on all wikis.

Ah sorry, the logger interface was recommended. I wish I had known about its quirks and limitations. Live and learn. Next time I will just output to console.

Feb 16 2023, 6:24 PM · MediaWiki-extensions-Linter, Wikimedia-maintenance-script-run
Sbailey added a comment to T329764: Run the maintenance script linter extension migrateNamespace.php on all wikis.

There is logging in both scripts:

		$logger = LoggerFactory::getInstance( 'MigrateNamespaceChannel' );

. . .

			$logger->info( 'Migrated ' . $updated . " page IDs\n" );
Feb 16 2023, 3:20 PM · MediaWiki-extensions-Linter, Wikimedia-maintenance-script-run

Feb 15 2023

Sbailey created T329766: Run the maintenance script linter extension migrateTagTemplate.php on all wikis.
Feb 15 2023, 5:03 PM · MediaWiki-extensions-Linter, Wikimedia-maintenance-script-run
Sbailey created T329764: Run the maintenance script linter extension migrateNamespace.php on all wikis.
Feb 15 2023, 4:59 PM · MediaWiki-extensions-Linter, Wikimedia-maintenance-script-run

Feb 14 2023

Sbailey updated the task description for T329342: Enable maintenance Linter data migration scripts for namespace and tag and template.
Feb 14 2023, 4:27 PM · MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), MediaWiki-extensions-Linter

Feb 10 2023

Sbailey created T329342: Enable maintenance Linter data migration scripts for namespace and tag and template.
Feb 10 2023, 1:48 AM · MW-1.40-notes (1.40.0-wmf.22; 2023-02-06), MediaWiki-extensions-Linter

Feb 9 2023

Sbailey closed T329113: Fix database migrate tag and template error due to excessive string length for linter tag or template strings as Resolved.
Feb 9 2023, 6:41 PM · MW-1.40-notes (1.40.0-wmf.23; 2023-02-13), MediaWiki-extensions-Linter
Sbailey closed T328979: Fix write database update error due to excessive string length for linter tag or template strings as Resolved.
Feb 9 2023, 6:40 PM · MW-1.40-notes (1.40.0-wmf.23; 2023-02-13), MediaWiki-extensions-Linter

Feb 7 2023

Sbailey updated subscribers of T328979: Fix write database update error due to excessive string length for linter tag or template strings.
Feb 7 2023, 8:51 PM · MW-1.40-notes (1.40.0-wmf.23; 2023-02-13), MediaWiki-extensions-Linter
Sbailey added a project to T329113: Fix database migrate tag and template error due to excessive string length for linter tag or template strings: MediaWiki-extensions-Linter.
Feb 7 2023, 8:51 PM · MW-1.40-notes (1.40.0-wmf.23; 2023-02-13), MediaWiki-extensions-Linter
Sbailey claimed T329113: Fix database migrate tag and template error due to excessive string length for linter tag or template strings.
Feb 7 2023, 8:50 PM · MW-1.40-notes (1.40.0-wmf.23; 2023-02-13), MediaWiki-extensions-Linter
Sbailey created T329113: Fix database migrate tag and template error due to excessive string length for linter tag or template strings.
Feb 7 2023, 8:43 PM · MW-1.40-notes (1.40.0-wmf.23; 2023-02-13), MediaWiki-extensions-Linter

Feb 6 2023

Sbailey added a comment to T328979: Fix write database update error due to excessive string length for linter tag or template strings.

Also created a unit test to verify the tag and template field string truncation code in the linter RecordLintJob / Database code.

Feb 6 2023, 10:56 PM · MW-1.40-notes (1.40.0-wmf.23; 2023-02-13), MediaWiki-extensions-Linter
Sbailey created T328979: Fix write database update error due to excessive string length for linter tag or template strings.
Feb 6 2023, 10:54 PM · MW-1.40-notes (1.40.0-wmf.23; 2023-02-13), MediaWiki-extensions-Linter

Jan 31 2023

Sbailey added a comment to T327806: Fix linter table linter_params definition to not be nullable.

Ah this is great, no more drift on linter table. Thanks Amir :-)

Jan 31 2023, 3:54 PM · MW-1.40-notes (1.40.0-wmf.21; 2023-01-30), MediaWiki-extensions-Linter

Jan 25 2023

Sbailey changed the status of T327806: Fix linter table linter_params definition to not be nullable from Open to In Progress.

Created https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Linter/+/883649
to fix the definition of linter_params to not be nullable.

Jan 25 2023, 8:18 PM · MW-1.40-notes (1.40.0-wmf.21; 2023-01-30), MediaWiki-extensions-Linter

Jan 24 2023

Sbailey created T327806: Fix linter table linter_params definition to not be nullable.
Jan 24 2023, 5:53 PM · MW-1.40-notes (1.40.0-wmf.21; 2023-01-30), MediaWiki-extensions-Linter

Jan 12 2023

Sbailey added a member for MediaWiki-extensions-Linter: Sbailey.
Jan 12 2023, 3:27 PM

Dec 12 2022

Sbailey moved T299612: Add namespace column and index to table from Code Review to To Deploy on the Content-Transform-Team-WIP board.
Dec 12 2022, 4:11 PM · MW-1.40-notes (1.40.0-wmf.25; 2023-02-27), Content-Transform-Team-WIP, MediaWiki-Maintenance-system, MediaWiki-extensions-Linter, MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), MW-1.38-notes (1.38.0-wmf.20; 2022-01-31), Patch-For-Review, Documentation
Sbailey moved T175177: Linter UI: Provide option to filter linter errors by second column (ex: obsolete tag, missing end tag, stripped tag, etc) from In Progress to Code Review on the Content-Transform-Team-WIP board.
Dec 12 2022, 4:07 PM · MW-1.40-notes (1.40.0-wmf.25; 2023-02-27), Content-Transform-Team-WIP, MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), MW-1.38-notes (1.38.0-wmf.21; 2022-02-07), Patch-For-Review, MediaWiki-extensions-Linter

Dec 8 2022

Sbailey added a comment to T246403: Lint error counts on "Page information" page do not update, even with null edit.

If you just edit a page with the wikitext editor, and then view it with the normal page read view, that doesn't require parsoid to reparse the page, and thus until parsoid parses it, the linter errors will not be updated. One way I trick the page into being reparsed, instead of just being in a job queue that is delayed, is by switching between wikitext and VE and back, which forces a reparse for VE to display the page. At least on my local machine this works, and I suspect it also works on production.

Dec 8 2022, 11:39 PM · MW-1.40-notes (1.40.0-wmf.17; 2023-01-02), Content-Transform-Team-WIP, Parsoid, MediaWiki-extensions-Linter

Nov 28 2022

Sbailey moved T175177: Linter UI: Provide option to filter linter errors by second column (ex: obsolete tag, missing end tag, stripped tag, etc) from Backlog to In Progress on the Content-Transform-Team-WIP board.
Nov 28 2022, 5:59 PM · MW-1.40-notes (1.40.0-wmf.25; 2023-02-27), Content-Transform-Team-WIP, MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), MW-1.38-notes (1.38.0-wmf.21; 2022-02-07), Patch-For-Review, MediaWiki-extensions-Linter
Sbailey added a project to T175177: Linter UI: Provide option to filter linter errors by second column (ex: obsolete tag, missing end tag, stripped tag, etc): Content-Transform-Team-WIP.
Nov 28 2022, 5:58 PM · MW-1.40-notes (1.40.0-wmf.25; 2023-02-27), Content-Transform-Team-WIP, MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), MW-1.38-notes (1.38.0-wmf.21; 2022-02-07), Patch-For-Review, MediaWiki-extensions-Linter

Sep 16 2022

Sbailey updated the task description for T175177: Linter UI: Provide option to filter linter errors by second column (ex: obsolete tag, missing end tag, stripped tag, etc).
Sep 16 2022, 4:34 PM · MW-1.40-notes (1.40.0-wmf.25; 2023-02-27), Content-Transform-Team-WIP, MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), MW-1.38-notes (1.38.0-wmf.21; 2022-02-07), Patch-For-Review, MediaWiki-extensions-Linter

Aug 26 2022

Sbailey updated the task description for T175177: Linter UI: Provide option to filter linter errors by second column (ex: obsolete tag, missing end tag, stripped tag, etc).
Aug 26 2022, 8:14 PM · MW-1.40-notes (1.40.0-wmf.25; 2023-02-27), Content-Transform-Team-WIP, MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), MW-1.38-notes (1.38.0-wmf.21; 2022-02-07), Patch-For-Review, MediaWiki-extensions-Linter

Aug 2 2022

Sbailey updated the task description for T175177: Linter UI: Provide option to filter linter errors by second column (ex: obsolete tag, missing end tag, stripped tag, etc).
Aug 2 2022, 5:24 PM · MW-1.40-notes (1.40.0-wmf.25; 2023-02-27), Content-Transform-Team-WIP, MW-1.39-notes (1.39.0-wmf.26; 2022-08-22), MW-1.38-notes (1.38.0-wmf.21; 2022-02-07), Patch-For-Review, MediaWiki-extensions-Linter

Jul 29 2022

Sbailey moved T311286: Not always possible to sort table by headings on Special:LintErrors from Backlog to Linter-UI on the MediaWiki-extensions-Linter board.

My research finds no evidence that the Linter error reports provide table headers for each column/field that are clickable to cause the report to be sorted on that column. Mehta (Kunal) was the last engineer to touch code that controls OOUI's sort feature which was disabled in the linter pager table code as reported by git log blame:
Mehta has function isFieldSortable() returning false since 2016, and the default sort is set to linter_id also since 2016

Jul 29 2022, 3:52 PM · MediaWiki-extensions-Linter

Jul 28 2022

Sbailey claimed T311286: Not always possible to sort table by headings on Special:LintErrors.

Looking into why the ability to sort based on clicking on table headings is not working.

Jul 28 2022, 9:18 PM · MediaWiki-extensions-Linter

Jun 21 2022

Sbailey closed T177547: Add search support for linter errors as Resolved.

Implemented in:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Linter/+/769772

Jun 21 2022, 10:01 PM · Discovery-Search, Discovery-ARCHIVED, MediaWiki-extensions-Linter
Sbailey closed T185685: Linter extension should allow search results to be limited by a prefix: or titlepart . as Resolved.

Implemented in:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Linter/+/769772

Jun 21 2022, 10:00 PM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), MW-1.38-notes (1.38.0-wmf.26; 2022-03-14), MediaWiki-extensions-Linter
Sbailey closed T298343: Similar pages on it.wv and it.wp or en:wv do not have the same lint errors as Resolved.

Arlo added 'proofread-page' as an additional lintable content model in:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Linter/+/766195

Jun 21 2022, 9:50 PM · MW-1.38-notes (1.38.0-wmf.24; 2022-02-28), MediaWiki-extensions-Linter
Sbailey closed T151362: Linter: Display lint errors for a single page as Resolved.

Search for a specific page implemented in:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Linter/+/769772
Ability to display all lint errors in a single page provided by LintHint.

Jun 21 2022, 9:43 PM · MW-1.38-notes (1.38.0-wmf.17; 2022-01-10), MediaWiki-extensions-Linter

Apr 12 2022

Sbailey added a comment to T151362: Linter: Display lint errors for a single page.

I researched what it would take for a "stock" wikimedia install to provide a subset of the features of LintHint (all lint errors on a single page highlighted, possibly with mouse roll over category display in a popup bubble. The default editor in OOUI would need significant enhancements outside the scope of the project to provide a display of all lints for a single page like LintHint can already do. I looked into the VE wikitext editor and the alternative syntax highlighting editor available as a Beta feature when VE is installed. My goals recently are better search narrowing functionality and not to replace LintHint, or to provide all lint errors on a single page as highlighted regions. All lints for a single page is what LintHint provides with a very attractive UI, as a list of all errors in one pane as clickable links that jump to a highlighted text region. My goals have been to offer better stock search capabilities and the next patch in this group is a search box from the special lint page bottom that allows the editor to specify a title prefix and get all pages with any category lint error that matches the partial title prefix. This allows editors that have created a directory tree structure for all their pages in the title, can search for only those pages. For editors that want a more advanced all lints on a single page, LintHint is not too hard to enable for wikis with VE enabled.

Apr 12 2022, 6:50 PM · MW-1.38-notes (1.38.0-wmf.17; 2022-01-10), MediaWiki-extensions-Linter

Mar 4 2022

Sbailey claimed T185685: Linter extension should allow search results to be limited by a prefix: or titlepart ..

It looks like at least searching and reporting by namespace, by category, by a title prefix is possible (database performance impacts are what gate what is safe to implement, not whether a feature technically can be implemented). Search by prefix, by namespace, for all categories also maybe possible, and be added to the report type provided for all lints for a single page. Would be good to get feedback on whether that is also a useful search/report type. But for now I will focus on prefix, namespace and category as search criteria report.

Mar 4 2022, 2:59 PM · MW-1.39-notes (1.39.0-wmf.17; 2022-06-20), MW-1.38-notes (1.38.0-wmf.26; 2022-03-14), MediaWiki-extensions-Linter

Mar 3 2022

Sbailey added a comment to T151362: Linter: Display lint errors for a single page.

I added a brief description of the new feature "Show all linter errors for a specific page" in the help page for linter. Due to this page being translated, the guidance is to keep changes brief, but hopefully I have covered its use, caveat of syntax highlighting interfering with its highlighting, and how to work from bottom up to avoid changing character offsets.
If you feel I need to add something more, let me know.
Again thanks for your care and comments.

Mar 3 2022, 8:28 PM · MW-1.38-notes (1.38.0-wmf.17; 2022-01-10), MediaWiki-extensions-Linter

Mar 2 2022

Sbailey claimed T245492: Slow query: IndexPager::buildQueryInfo (MediaWiki\Linter\LintErrorsPager).

The new namespace column may allow the query optimizer to improve this performance significantly.

Mar 2 2022, 5:54 PM · DBA, mariadb-optimizer-bug, MediaWiki-extensions-Linter, Performance Issue
Sbailey added a comment to T151362: Linter: Display lint errors for a single page.

Jonesey95 and Izno,
Thanks for your care and comments. The new all lints for a single page is located at the bottom of the special lints page and takes a page titles such as "User:Delta40" and returns all lints for that page in a list which allows you to use the edit button to take you to the highlighted area of the page wikitext source. To edit a bunch of errors on a single page, I suggest editing the last error first so that any insertion or deletion of characters happens below where other errors are still present, before Parsoid regenerates the linter error list (due to caching and timeouts, etc.). This feature was added so we have a native implementation that is similar to LintHint, but requires no special efforts on the editors part to setup and use LintHint. LintHint can also add more features that we arn't able to add for various reasons.
I'll look at where in the doc I should add some info about this new feature.

Mar 2 2022, 3:45 PM · MW-1.38-notes (1.38.0-wmf.17; 2022-01-10), MediaWiki-extensions-Linter

Mar 1 2022

Sbailey placed T207032: Lint away 'pxpx' up for grabs.
Mar 1 2022, 8:12 PM · Content-Transform-Team-WIP, Parsoid
Sbailey added a comment to T151362: Linter: Display lint errors for a single page.

Is the newish "Show all linter errors for a specific page" feature helping and providing most of what this ticket was requesting?
Other selection features are in the works (waiting on new fields being added to the linter table) such as namespace and template and tag allowing further narrowing of search results.

Mar 1 2022, 8:11 PM · MW-1.38-notes (1.38.0-wmf.17; 2022-01-10), MediaWiki-extensions-Linter
Sbailey added a comment to T165538: Need a mechanism / process to purge invalid / stale entries from the Linter database.

Two tasks address some of these stale linter data issues:
Delete lint error records when content model changes from wikitext
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Linter/+/761070
and
Delete lint errors when blank page saved... (the title of this ticket implies content model change also needed but only requirement is saving a blank page regardless of content model.
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Linter/+/766872

Mar 1 2022, 7:21 PM · Content-Transform-Team-WIP, MediaWiki-extensions-Linter
Sbailey placed T280193: ContentHandler::getChangeType is limited to a single type per edit, ignoring content model changes up for grabs.
Mar 1 2022, 3:32 PM · MW-1.38-notes (1.38.0-wmf.24; 2022-02-28), Patch-For-Review, MediaWiki-Page-editing, MediaWiki-ContentHandler, User-DannyS712

Feb 28 2022

Sbailey claimed T280193: ContentHandler::getChangeType is limited to a single type per edit, ignoring content model changes.

Lint errors are now being deleted during save of a blank page while the content model is being changed.
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Linter/+/766872

Feb 28 2022, 10:53 PM · MW-1.38-notes (1.38.0-wmf.24; 2022-02-28), Patch-For-Review, MediaWiki-Page-editing, MediaWiki-ContentHandler, User-DannyS712

Feb 7 2022

Sbailey placed T233252: Need to write more tests for LinkHandlerUtils.php figureHandler to add coverage up for grabs.
Feb 7 2022, 7:25 PM · Parsoid
Sbailey claimed T298343: Similar pages on it.wv and it.wp or en:wv do not have the same lint errors.
Feb 7 2022, 7:16 PM · MW-1.38-notes (1.38.0-wmf.24; 2022-02-28), MediaWiki-extensions-Linter

Feb 4 2022

Sbailey created T300992: Add linter_template and linter_tag columns to the Linter table.
Feb 4 2022, 5:30 PM · User-Ladsgroup, DBA, Schema-change-in-production, MediaWiki-extensions-Linter

Jan 28 2022

Sbailey added a project to T300402: Add namespace column to Linter table: Schema-change-in-production.
Jan 28 2022, 8:48 PM · MediaWiki-extensions-Linter, DBA, Schema-change-in-production
Sbailey created T300402: Add namespace column to Linter table.
Jan 28 2022, 8:46 PM · MediaWiki-extensions-Linter, DBA, Schema-change-in-production

Jan 22 2022

Sbailey added a comment to T299612: Add namespace column and index to table.

So in the process of creating a set of patches that add a column for part 1, start populating the new column when new records are written in part 2, will do a full pass through existing records migrating data derived form data in another column to populate the new column completely in part 3, then add code to utilize the new column for search/reporting in part 4, then do a complete refactor of old and new code, removing old code and moving new code around as needed and removing config variable enablements, etc.

Jan 22 2022, 12:02 AM · MW-1.40-notes (1.40.0-wmf.25; 2023-02-27), Content-Transform-Team-WIP, MediaWiki-Maintenance-system, MediaWiki-extensions-Linter, MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), MW-1.38-notes (1.38.0-wmf.20; 2022-01-31), Patch-For-Review, Documentation

Jan 20 2022

Sbailey added a comment to T299612: Add namespace column and index to table.

It was unintentional, sorry about that,

Jan 20 2022, 4:07 PM · MW-1.40-notes (1.40.0-wmf.25; 2023-02-27), Content-Transform-Team-WIP, MediaWiki-Maintenance-system, MediaWiki-extensions-Linter, MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), MW-1.38-notes (1.38.0-wmf.20; 2022-01-31), Patch-For-Review, Documentation
Sbailey removed a project from T299612: Add namespace column and index to table: ContentTranslation.
Jan 20 2022, 4:06 PM · MW-1.40-notes (1.40.0-wmf.25; 2023-02-27), Content-Transform-Team-WIP, MediaWiki-Maintenance-system, MediaWiki-extensions-Linter, MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), MW-1.38-notes (1.38.0-wmf.20; 2022-01-31), Patch-For-Review, Documentation
Sbailey updated the task description for T299612: Add namespace column and index to table.
Jan 20 2022, 12:34 AM · MW-1.40-notes (1.40.0-wmf.25; 2023-02-27), Content-Transform-Team-WIP, MediaWiki-Maintenance-system, MediaWiki-extensions-Linter, MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), MW-1.38-notes (1.38.0-wmf.20; 2022-01-31), Patch-For-Review, Documentation

Jan 19 2022

Sbailey created T299612: Add namespace column and index to table.
Jan 19 2022, 11:11 PM · MW-1.40-notes (1.40.0-wmf.25; 2023-02-27), Content-Transform-Team-WIP, MediaWiki-Maintenance-system, MediaWiki-extensions-Linter, MW-1.39-notes (1.39.0-wmf.21; 2022-07-18), MW-1.38-notes (1.38.0-wmf.20; 2022-01-31), Patch-For-Review, Documentation

Jan 7 2022

Sbailey claimed T298782: Linter seems to be not cleaning up after page deletion.

I will look into this as I already have attempted to improve the error count results and this continues that effort in:
https://phabricator.wikimedia.org/T194872

Jan 7 2022, 5:44 PM · MediaWiki-extensions-Linter, Data-Persistence (work done)

Sep 30 2021

Sbailey claimed T151362: Linter: Display lint errors for a single page.
Sep 30 2021, 9:21 PM · MW-1.38-notes (1.38.0-wmf.17; 2022-01-10), MediaWiki-extensions-Linter

Sep 21 2021

Sbailey created T291513: Review schema changes for T175177.
Sep 21 2021, 6:55 PM · Data-Persistence (work done), MediaWiki-extensions-Linter

Aug 11 2021

Sbailey committed rELINTcc2e08546be6: Fix broken RecordLintJobTest (authored by Sbailey).
Fix broken RecordLintJobTest
Aug 11 2021, 11:12 PM

Jun 11 2021

Sbailey claimed T225337: Unbreak RecordLintJobTest.

I believe I have a fix for this and want this fix done prior to adding additional tests to RecordListJobTest.php
The issue appears to be that RecordLintJob.php run() checks the revision and then delays the job run which in a production environment is a good idea, but not for this test, so I removed the revision property. I also set the pageID to 0 instead of 1 as that seems to be a new default allowing the test to find the inserted lint error appropriately.

Jun 11 2021, 5:40 PM · MW-1.37-notes (1.37.0-wmf.19; 2021-08-16), Regression, MediaWiki-extensions-Linter

May 26 2021

Sbailey closed T162983: Parsoid linter shows rest of page as error when unbalanced brackets exists as Resolved.

The Linter error no longer is generated in this case, so the issue of error running to end of page is resolved.
A new phab ticket covering broken use of Wikilink with unclosed ]] might be worth creating as a low priority.

May 26 2021, 8:23 PM · Parsoid, Parsoid-Tokenizer, MediaWiki-extensions-Linter

May 25 2021

Sbailey claimed T162983: Parsoid linter shows rest of page as error when unbalanced brackets exists.
May 25 2021, 5:24 PM · Parsoid, Parsoid-Tokenizer, MediaWiki-extensions-Linter

Apr 30 2021

Sbailey claimed T170313: Linter count not updated on deleted page.

Exploring why Linter error counts are still incorrect after a page is deleted.

Apr 30 2021, 6:46 PM · MW-1.38-notes (1.38.0-wmf.17; 2022-01-10), MW-1.31-release-notes (WMF-deploy-2018-02-20 (1.31.0-wmf.22)), WMSE-Bug-Reporting-and-Translation-2017, MediaWiki-extensions-Linter

Apr 27 2021

Sbailey updated the task description for T194872: Linter : have correct counters for categories populated with only a few errors (or none).
Apr 27 2021, 7:41 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), MediaWiki-extensions-Linter
Sbailey updated the task description for T194872: Linter : have correct counters for categories populated with only a few errors (or none).
Apr 27 2021, 7:40 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), MediaWiki-extensions-Linter
Sbailey added a comment to T194872: Linter : have correct counters for categories populated with only a few errors (or none).

So gerrit patch 677673 modifies the code which generates estimated linter error counts for a category to produce an accurate count when the actual count in the database is less than (20) or whatever MAX_ACCURATE_COUNT is set to in Database.php in the Linter extension directory. While this change will help produce more accurate counts, other issues of when the object cache gets refreshed still apply as does errors that become stale when a page with errors is deleted, prior to a full refresh of the Linter errors from all active pages is performed. Still this should provide better counts in most circumstances.
I am not going to close this ticket as resolved, until a more complete solution is implemented that has fewer caveats.

Apr 27 2021, 7:38 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), MediaWiki-extensions-Linter
Sbailey committed rELINT201b47e01d38: Make Linter category counts more accurate when counts are low (authored by Sbailey).
Make Linter category counts more accurate when counts are low
Apr 27 2021, 6:00 PM

Mar 15 2021

Sbailey claimed T194872: Linter : have correct counters for categories populated with only a few errors (or none).
Mar 15 2021, 10:12 PM · MW-1.37-notes (1.37.0-wmf.4; 2021-05-04), MediaWiki-extensions-Linter

Mar 10 2021

Sbailey moved T165538: Need a mechanism / process to purge invalid / stale entries from the Linter database from Backlog to Linter-UI on the MediaWiki-extensions-Linter board.
Mar 10 2021, 10:09 PM · Content-Transform-Team-WIP, MediaWiki-extensions-Linter

Mar 5 2021

Sbailey moved T246403: Lint error counts on "Page information" page do not update, even with null edit from Backlog to Linter-UI on the MediaWiki-extensions-Linter board.
Mar 5 2021, 8:57 PM · MW-1.40-notes (1.40.0-wmf.17; 2023-01-02), Content-Transform-Team-WIP, Parsoid, MediaWiki-extensions-Linter
Sbailey moved T171788: On wikis without changeprop enabled, lint errors don't update after page edits from Backlog to Linter-UI on the MediaWiki-extensions-Linter board.
Mar 5 2021, 6:59 PM · Parsoid (Tracking), Platform Team Legacy (Designing), Services (designing), wikitech.wikimedia.org, MediaWiki-extensions-Linter

Feb 25 2021

Sbailey closed T248369: Add linting rule for detecting presence of image wikitext in extlinks as Resolved.
Feb 25 2021, 11:01 PM · MediaWiki-extensions-Linter, Parsoid

Feb 22 2021

Sbailey placed T275415: Content duplicated when editing when a block template is used in a wikilink up for grabs.
Feb 22 2021, 8:27 PM · DiscussionTools, Parsoid
Sbailey added a comment to T275415: Content duplicated when editing when a block template is used in a wikilink.

Subbu wrote in IRC:

Feb 22 2021, 8:26 PM · DiscussionTools, Parsoid
Sbailey claimed T275415: Content duplicated when editing when a block template is used in a wikilink.
Feb 22 2021, 5:55 PM · DiscussionTools, Parsoid