Page MenuHomePhabricator

Sbailey (Sbailey)
User

Projects (6)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 4 2017, 8:49 PM (110 w, 1 h)
Availability
Available
LDAP User
Sbailey
MediaWiki User
SBailey (WMF) [ Global Accounts ]

Recent Activity

Yesterday

Sbailey closed T236868: Invariant failed: Bad SourceRange length as Resolved.
Tue, Nov 12, 6:21 PM · Parsoid-PHP

Thu, Nov 7

Sbailey closed T236846: TemplateHandler.php: trim() expects parameter 1 to be string, boolean given as Resolved.

Fix for crash completed and fixes that produce desired behavior and correct wikitext and VE edit updates all implemented and tests written.

Thu, Nov 7, 11:52 PM · Parsoid-PHP

Wed, Nov 6

Sbailey claimed T237461: Parsoid/PHP LintLogger has gaps relative to Parsoid/JS.
Wed, Nov 6, 5:13 PM · Patch-For-Review, Parsoid-PHP

Tue, Nov 5

Sbailey claimed T236846: TemplateHandler.php: trim() expects parameter 1 to be string, boolean given.
Tue, Nov 5, 6:00 PM · Parsoid-PHP

Thu, Oct 31

Sbailey claimed T236868: Invariant failed: Bad SourceRange length.
Thu, Oct 31, 3:29 PM · Parsoid-PHP
Sbailey added a comment to T235231: Parsoid/JS video tag has a "seek" parameter in the URL that Parsoid/PHP video tag output doesn't.

Should be resolved by:
https://gerrit.wikimedia.org/r/547335

Thu, Oct 31, 2:59 PM · Parsoid-PHP

Thu, Oct 24

Sbailey placed T235777: Redlink differences between Parsoid/PHP and Parsoid/JS up for grabs.

Debugged both parsoid JS and PHP and without, and with --useBatchAPI enabled on parsoidJS, the class="new" does appear, but the redlinks code will not get called without that command line flag enabled. The parsoid PHP calls the redlink code without any command line flags required.
Unable to reproduce the error that occurred in the server environment, possibly missing --useBatchAPI?

Thu, Oct 24, 6:27 PM · Parsoid-PHP

Fri, Oct 18

Sbailey added a comment to T235709: Too many diffs on this page.

The JS Poem extension was also failing to properly handle the following (enhanced slightly WT below and the PHP Poem was dramatically failing to produce viable HTML from:

Fri, Oct 18, 11:56 PM · Parsoid-PHP

Wed, Oct 16

Sbailey added a comment to T235231: Parsoid/JS video tag has a "seek" parameter in the URL that Parsoid/PHP video tag output doesn't.

Researched and attempted to reproduce using command line parse.php and in that mode, does not fail to match ParsoidJS in command line mode. The core parser also produces the seek correctly, but when ParsoidPHP is used in production mode, fails with local installation of mediawiki or on server installations.
I need to get my local mediawiki install back in running state after upgrading OSX to Catalina to continue.

Wed, Oct 16, 9:35 PM · Parsoid-PHP

Tue, Oct 15

Sbailey closed T233738: Add a flag (--mock?) to the parse.php script to use the mock SiteConfig and DataAccess, a subtask of T228217: Ensure all the features of parse.js are covered by parse.php, as Resolved.
Tue, Oct 15, 10:54 PM · Patch-For-Review, Parsoid-PHP
Sbailey closed T233738: Add a flag (--mock?) to the parse.php script to use the mock SiteConfig and DataAccess as Resolved.

Added:
https://gerrit.wikimedia.org/r/#/c/mediawiki/services/parsoid/+/541343/

Tue, Oct 15, 10:54 PM · Parsoid-PHP
Sbailey closed T226437: Audit uses of empty() and isset() and eliminate unnecessary uses as Resolved.

Replaced empty() and isset() where safe.
https://gerrit.wikimedia.org/r/#/c/mediawiki/services/parsoid/+/543229/

Tue, Oct 15, 10:53 PM · Technical-Debt, Parsoid-PHP

Oct 9 2019

Sbailey closed T223194: Consider using instanceof checks for DOM Nodes instead of DOMUtils::is* + DOMUtils::assertElt combinations as Resolved.

After reviewing Parsoid/PHP on Oct, 9, it appears that all performance improvements possible were addressed by:
https://gerrit.wikimedia.org/r/533258

Oct 9 2019, 10:36 PM · Parsoid-PHP
Sbailey closed T223193: Consider using instanceof instead of TokenUtils::getTokenType as Resolved.
Oct 9 2019, 8:30 PM · Parsoid-PHP

Sep 18 2019

Sbailey created T233252: Need to write more tests for LinkHandlerUtils.php figureHandler to add coverage.
Sep 18 2019, 7:07 PM · Parsoid

Aug 1 2019

Sbailey claimed T229264: Logging out on web logs out iOS session.
Aug 1 2019, 8:21 PM · iOS-app-v6.5-Squid-On-A-Tandem-Bike, iOS-app-Bugs, Wikipedia-iOS-App-Backlog

Jul 30 2019

Sbailey closed T138784: add support Maldivian Wikipedia as Resolved.
Jul 30 2019, 6:14 PM · iOS-app-v6.4-Seamonkey-On-A-Hoverboard, I18n, iOS-app-feature-Multilingual, Wikipedia-iOS-App-Backlog

Jul 26 2019

Sbailey claimed T138784: add support Maldivian Wikipedia.
Jul 26 2019, 12:03 AM · iOS-app-v6.4-Seamonkey-On-A-Hoverboard, I18n, iOS-app-feature-Multilingual, Wikipedia-iOS-App-Backlog
Sbailey moved T138784: add support Maldivian Wikipedia from Ready for Development to Doing on the iOS-app-v6.4-Seamonkey-On-A-Hoverboard board.
Jul 26 2019, 12:03 AM · iOS-app-v6.4-Seamonkey-On-A-Hoverboard, I18n, iOS-app-feature-Multilingual, Wikipedia-iOS-App-Backlog

Jul 17 2019

Sbailey claimed T196679: [BUG] "Syncing will resume when internet available" appears at top of theme panel.
Jul 17 2019, 5:37 PM · iOS-app-v6.3.1 Lobster-On-An-ORV, iOS-app-Bugs, Wikipedia-iOS-App-Backlog
Sbailey moved T196679: [BUG] "Syncing will resume when internet available" appears at top of theme panel from Ready for Development to Doing on the iOS-app-v6.3.1 Lobster-On-An-ORV board.
Jul 17 2019, 5:36 PM · iOS-app-v6.3.1 Lobster-On-An-ORV, iOS-app-Bugs, Wikipedia-iOS-App-Backlog

Jul 16 2019

Sbailey moved T213465: Article footer is too tall from Doing to Ready for Development on the iOS-app-v6.3.1 Lobster-On-An-ORV board.
Jul 16 2019, 3:17 PM · iOS-app-Bugs, Wikipedia-iOS-App-Backlog
Sbailey placed T213465: Article footer is too tall up for grabs.
Jul 16 2019, 3:16 PM · iOS-app-Bugs, Wikipedia-iOS-App-Backlog

Jul 15 2019

Sbailey created T228115: querySelectorAll seems to be malfunctioning on "body > p:nth-child( 1 )" and ...( 2 ).
Jul 15 2019, 11:03 PM · Parsoid-PHP

Jul 10 2019

Sbailey moved T213465: Article footer is too tall from Ready for Development to Doing on the iOS-app-v6.3.1 Lobster-On-An-ORV board.
Jul 10 2019, 7:17 PM · iOS-app-Bugs, Wikipedia-iOS-App-Backlog
Sbailey claimed T213465: Article footer is too tall.
Jul 10 2019, 7:14 PM · iOS-app-Bugs, Wikipedia-iOS-App-Backlog

Nov 27 2018

Sbailey updated the task description for T209186: Create a "unit-testing" framework for DOM transformers.
Nov 27 2018, 9:39 PM · Patch-For-Review, Parsoid-PHP
Sbailey added a comment to T209186: Create a "unit-testing" framework for DOM transformers.

First phase of generating dom pre and post pass test files completed:
https://gerrit.wikimedia.org/r/#/c/mediawiki/services/parsoid/+/474775/

Nov 27 2018, 9:33 PM · Patch-For-Review, Parsoid-PHP

Nov 8 2018

Sbailey created T209118: Add time usage and call count to TokenTransformMangers add, remove and getTransform functions.
Nov 8 2018, 9:58 PM · Patch-For-Review, Parsoid

Aug 16 2018

Sbailey added a comment to T199246: Parsoid should expose content inside <includeonly> to editors instead of hiding it in the meta tag's data-parsoid attribute.

WIP
https://gerrit.wikimedia.org/r/#/c/mediawiki/services/parsoid/+/452837/

Aug 16 2018, 9:20 PM · Patch-For-Review, Parsoid

Jul 17 2018

Sbailey added a comment to T199718: Parsoid doesn't support {{!}} in links.

So on my development Parsoid (some configuration info is not the same as production), I cannot reproduce this bug:

Jul 17 2018, 6:48 PM · Parsoid

Jun 11 2018

Gerrit Code Review <gerrit@wikimedia.org> committed rELINTe881f5c079f0: Update patch set 1 (authored by Sbailey).
Update patch set 1
Jun 11 2018, 2:15 PM

May 22 2018

Sbailey claimed T194945: Infobox overlaps with text, prevents editing the latter..
May 22 2018, 3:09 PM · Parsoid, VisualEditor

Apr 19 2018

Restricted Application added a project to T191700: VE: Avoid piping links for formatting where possible: Product-Analytics.

The normalization code now checks for matching href and textContent, and also avoid normalizing WikiLinks that have color, style and class attributes.

Apr 19 2018, 12:02 AM · Patch-For-Review, Parsoid

Apr 4 2018

Sbailey added a comment to T189474: Image captions should ignore paragraph tags.

Adding a second patch to handle multiple paragraphs being collapsed in a figcaption.

Apr 4 2018, 8:10 PM · Parsoid-Edit-Support, Patch-For-Review

Mar 19 2018

Sbailey added a comment to T189474: Image captions should ignore paragraph tags.

The first submission of the patch just fixes the single case.

Mar 19 2018, 11:36 PM · Parsoid-Edit-Support, Patch-For-Review
Sbailey added a comment to T189474: Image captions should ignore paragraph tags.

Ed, Subbu and I have discussed that for multiple p tags in the caption, we will be replacing the new lines with a single space, merging the captions together. The hope is that the captions would be sentences and that joining them with a space will be a reasonable way to "fix" this situation.

Mar 19 2018, 11:36 PM · Parsoid-Edit-Support, Patch-For-Review

Feb 1 2018

Sbailey reopened T58756: Parsoid doesn't give external links class="external free|text" as "Open".

Re-opened until merged and deployed, my bad.

Feb 1 2018, 4:59 PM · Patch-For-Review, Parsoid
Sbailey reopened T58756: Parsoid doesn't give external links class="external free|text", a subtask of T67243: Flow: Obey the Exlinks gadget (open external links in new tab/window), as Open.
Feb 1 2018, 4:59 PM · Collaboration-Team-Triage, StructuredDiscussions
Sbailey reopened T58756: Parsoid doesn't give external links class="external free|text", a subtask of T96855: A15. Flow rendering doesn't render external links correctly, as Open.
Feb 1 2018, 4:59 PM · Patch-For-Review, Collaboration-Team-Triage, Collaboration-Team-Sprint-A-2015-05-06, StructuredDiscussions
Sbailey closed T58756: Parsoid doesn't give external links class="external free|text" as Resolved.

So for class = "external free", "external text" and "external autonumber", parsoid now generates the proper class attributes and matches the PHP parser output.
See gerrit:
https://gerrit.wikimedia.org/r/#/c/407053/

Feb 1 2018, 4:09 PM · Patch-For-Review, Parsoid
Sbailey closed T58756: Parsoid doesn't give external links class="external free|text", a subtask of T67243: Flow: Obey the Exlinks gadget (open external links in new tab/window), as Resolved.
Feb 1 2018, 4:09 PM · Collaboration-Team-Triage, StructuredDiscussions
Sbailey closed T58756: Parsoid doesn't give external links class="external free|text", a subtask of T96855: A15. Flow rendering doesn't render external links correctly, as Resolved.
Feb 1 2018, 4:09 PM · Patch-For-Review, Collaboration-Team-Triage, Collaboration-Team-Sprint-A-2015-05-06, StructuredDiscussions

Dec 18 2017

Sbailey added a comment to T71207: Parsoid: Interwiki links are halfway converted to external links, and completely broken.

I retried James example the current Parsoid and it seems to work properly. Is there another failing case I can look at?

Dec 18 2017, 11:56 PM · Parsoid-Edit-Support, Patch-For-Review, Parsoid-Serializer

Oct 5 2017

Sbailey added a comment to T177447: Add Sbailey to the #WMF-NDA group.

Hi,
Hi, thanks, I linked the accounts (I think).
Best,
Shannon

Oct 5 2017, 5:09 PM · WMF-NDA-Requests
Sbailey added a comment to T177447: Add Sbailey to the #WMF-NDA group.

Hi,
THanks I linked the accounts.
Shannon

Oct 5 2017, 5:08 PM · WMF-NDA-Requests

Oct 4 2017

Sbailey created T177447: Add Sbailey to the #WMF-NDA group.
Oct 4 2017, 10:56 PM · WMF-NDA-Requests
Sbailey added a watcher for WMF-NDA: Sbailey.
Oct 4 2017, 10:53 PM