Page MenuHomePhabricator
Create Task
Maniphest T308096

Enable OnThisDay Wikifeeds in zhwiki
Open, Needs TriagePublic
Actions

Details

SubjectRepoBranchLines +/-
Fix: Remove year page for zhwiki's OnThisDaymediawiki/services/wikifeedsmaster+10 -6
fix: Use the original title for wikis with language conversionmediawiki/services/wikifeedsmaster+9 -5
Enable OnThisDay Wikifeeds on zhwikimediawiki/services/wikifeedsmaster+139 -30
Customize query in gerrit

Related Objects

Event Timeline

StevenSun created this task.May 11 2022, 3:59 AM
Restricted Application added subscribers: Ericliu1912, Stang, Aklapper. · View Herald TranscriptMay 11 2022, 3:59 AM
gerritbot added a comment.May 11 2022, 7:28 AM

Change 790974 had a related patch set uploaded (by Steven Sun; author: Steven Sun):

[mediawiki/services/wikifeeds@master] Enable OnThisDay Wikifeeds on zhwiki

https://gerrit.wikimedia.org/r/790974

gerritbot added a project: Patch-For-Review.May 11 2022, 7:28 AM
Shizhao moved this task from Backlog to Site configuration on the Chinese-Sites board.May 12 2022, 7:11 AM
MSantos subscribed.May 30 2022, 1:12 PM
gerritbot added a comment.Dec 12 2022, 2:29 PM

Change 790974 merged by jenkins-bot:

[mediawiki/services/wikifeeds@master] Enable OnThisDay Wikifeeds on zhwiki

https://gerrit.wikimedia.org/r/790974

Maintenance_bot removed a project: Patch-For-Review.Dec 12 2022, 2:32 PM
StevenSun mentioned this in rWSWFe7bd304cecd2: Enable OnThisDay Wikifeeds on zhwiki.Dec 12 2022, 3:54 PM
Shizhao subscribed.EditedJan 13 2023, 7:50 AM

@StevenSun Shouldn't there be a link to the year?

photo_2023-01-13_15-48-46.jpg (1×576 px, 54 KB)

Also, some linked articles are not listed. For example:

2010年：法國文化部成立遺產和建築總局。

"遺產和建築總局" not listed.

Shizhao added a comment.Feb 6 2023, 3:40 AM
在T308096#8522607中，@Shizhao写道：

@StevenSun Shouldn't there be a link to the year?

photo_2023-01-13_15-48-46.jpg (1×576 px, 54 KB)

Also, some linked articles are not listed. For example:

2010年：法國文化部成立遺產和建築總局。

"遺產和建築總局" not listed.

This appears to be ignoring the language conversion tag?

Kethyga subscribed.Feb 6 2023, 4:22 AM
gerritbot added a comment.Apr 4 2023, 9:42 AM

Change 905588 had a related patch set uploaded (by Steven Sun; author: Steven Sun):

[mediawiki/services/wikifeeds@master] Fix: Remove year page for zhwiki's OnThisDay

https://gerrit.wikimedia.org/r/905588

gerritbot added a project: Patch-For-Review.Apr 4 2023, 9:42 AM
StevenSun added a comment.Apr 4 2023, 11:26 AM

As @Shizhao mentioned, this problem relates to language conversion: Wikifeeds send user request header's language to mediawiki's REST API (see https://phabricator.wikimedia.org/diffusion/WSWF/browse/master/lib/parsoid.js$25). REST API returns language-converted page title. However, some article do not have a redirect with this converted title.

gerritbot added a comment.Apr 5 2023, 4:57 AM

Change 905781 had a related patch set uploaded (by Steven Sun; author: Steven Sun):

[mediawiki/services/wikifeeds@master] Fix: Use original title for language conversion wikis

https://gerrit.wikimedia.org/r/905781

Func added a project: Content-Transform-Team.May 11 2023, 12:41 PM
Func subscribed.

Add the team tag for visibility.

Jgiannelos edited projects, added Content-Transform-Team-WIP; removed Content-Transform-Team.May 11 2023, 2:14 PM
Jgiannelos moved this task from Backlog to Code Review on the Content-Transform-Team-WIP board.
Jgiannelos moved this task from Code Review to To Deploy on the Content-Transform-Team-WIP board.May 26 2023, 8:03 AM
gerritbot added a comment.May 26 2023, 8:06 AM

Change 905781 merged by jenkins-bot:

[mediawiki/services/wikifeeds@master] fix: Use the original title for wikis with language conversion

https://gerrit.wikimedia.org/r/905781

Func mentioned this in rWSWF0939265f74b6: fix: Use the original title for wikis with language conversion.May 26 2023, 11:49 AM
Jgiannelos moved this task from To Deploy to To Verify on the Content-Transform-Team-WIP board.May 30 2023, 2:18 PM
Jgiannelos subscribed.Jun 5 2023, 3:10 PM

@StevenSun We deployed the change last week. Can you verify that production works as expected?

Shizhao added a comment.Jun 6 2023, 2:34 AM
在T308096#8753645中，@gerritbot写道：

Change 905588 had a related patch set uploaded (by Steven Sun; author: Steven Sun):

[mediawiki/services/wikifeeds@master] Fix: Remove year page for zhwiki's OnThisDay

https://gerrit.wikimedia.org/r/905588

This problem is still not fixed

MSantos moved this task from To Verify to Backlog on the Content-Transform-Team-WIP board.Jun 15 2023, 9:36 AM
MSantos added a project: Essential-Work.Jun 19 2023, 11:54 AM
StevenSun added a comment.Sep 21 2023, 11:30 AM

@Jgiannelos Hello, thanks for deploying! The patch you deployed works as expected. Could you please deploy another patch for this task as well？

Jgiannelos added a comment.Sep 21 2023, 11:32 AM

Hey @StevenSun which patch are you referring to?

StevenSun added a comment.Sep 21 2023, 11:34 AM

@Jgiannelos https://gerrit.wikimedia.org/r/c/905588

• Sbailey moved this task from Backlog to In Progress on the Wikifeeds board.Feb 21 2024, 5:06 PM
• Sbailey subscribed.Feb 21 2024, 5:13 PM
MSantos moved this task from Backlog to Code Review on the Content-Transform-Team-WIP board.Mar 4 2024, 3:56 PM
Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Oct 10 2024, 12:44 PM
Aklapper removed a subscriber: • Sbailey.
Aklapper removed StevenSun as the assignee of this task.Nov 19 2024, 5:19 PM

@StevenSun: Removing task assignee as this open task has been assigned for more than two years - See the email sent to task assignee on October 11th.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome! :)
If this task has been resolved in the meantime, or should not be worked on by anybody ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits