Page MenuHomePhabricator

Enable OnThisDay Wikifeeds in zhwiki
Open, Needs TriagePublic

Event Timeline

Change 790974 had a related patch set uploaded (by Steven Sun; author: Steven Sun):

[mediawiki/services/wikifeeds@master] Enable OnThisDay Wikifeeds on zhwiki

https://gerrit.wikimedia.org/r/790974

Change 790974 merged by jenkins-bot:

[mediawiki/services/wikifeeds@master] Enable OnThisDay Wikifeeds on zhwiki

https://gerrit.wikimedia.org/r/790974

@StevenSun Shouldn't there be a link to the year?

photo_2023-01-13_15-48-46.jpg (1×576 px, 54 KB)

Also, some linked articles are not listed. For example:

2010年:法國文化部成立遺產和建築總局。

"遺產和建築總局" not listed.

在T308096#8522607中,@Shizhao写道:

@StevenSun Shouldn't there be a link to the year?

photo_2023-01-13_15-48-46.jpg (1×576 px, 54 KB)

Also, some linked articles are not listed. For example:

2010年:法國文化部成立遺產和建築總局。

"遺產和建築總局" not listed.

This appears to be ignoring the language conversion tag?

Change 905588 had a related patch set uploaded (by Steven Sun; author: Steven Sun):

[mediawiki/services/wikifeeds@master] Fix: Remove year page for zhwiki's OnThisDay

https://gerrit.wikimedia.org/r/905588

As @Shizhao mentioned, this problem relates to language conversion: Wikifeeds send user request header's language to mediawiki's REST API (see https://phabricator.wikimedia.org/diffusion/WSWF/browse/master/lib/parsoid.js$25). REST API returns language-converted page title. However, some article do not have a redirect with this converted title.

Change 905781 had a related patch set uploaded (by Steven Sun; author: Steven Sun):

[mediawiki/services/wikifeeds@master] Fix: Use original title for language conversion wikis

https://gerrit.wikimedia.org/r/905781

Func subscribed.

Add the team tag for visibility.

Change 905781 merged by jenkins-bot:

[mediawiki/services/wikifeeds@master] fix: Use the original title for wikis with language conversion

https://gerrit.wikimedia.org/r/905781

@StevenSun We deployed the change last week. Can you verify that production works as expected?

在T308096#8753645中,@gerritbot写道:

Change 905588 had a related patch set uploaded (by Steven Sun; author: Steven Sun):

[mediawiki/services/wikifeeds@master] Fix: Remove year page for zhwiki's OnThisDay

https://gerrit.wikimedia.org/r/905588

This problem is still not fixed

@Jgiannelos Hello, thanks for deploying! The patch you deployed works as expected. Could you please deploy another patch for this task as well?