Page MenuHomePhabricator

(Re)deploy ParserMigration extension to production
Closed, ResolvedPublic

Description

The ParserMigration extension was deployed during 2017 (T141586) to compare legacy Tidy-based output with the Remex-based replacement, to aid in migration to the new tidy algorithm. It was undeployed in Dec 2018 after that migration was complete.

It was overhauled in 2023 to compare Parsoid output with the legacy wikitext parser output (T333177), as part of the Parsoid-Read-Views project, and the Content-Transform-Team would like to redeploy it to production.

The README and on-wiki Help:Extension:ParserMigration provide more information on the operation and purpose of this extension.

Testing ParserMigration
You can follow the instructions at Help:Extension:ParserMigration to enable the user preference and then view the side-by-side comparison output of (for example) the Main Page.

Special:ApiSandbox can also be used to verify that the action API component is working: action=parser-migration.

Needed for deployment of the ParserMigration extension

  • Security Review (T334962): this was done for the 2017 deployment (T141591#2609752) but requires an update; note that part of the previous review was Html5Depurate which became Remex and remained in production as part of core even after ParserMigration was undeployed; the new extension is lighter-weight than the original since the basic functionalities it is using are already part of core.
  • (Re)start branching ParserMigration (blocked on security review): https://gitlab.wikimedia.org/repos/releng/release/-/merge_requests/30
  • Design Review: this is intended primarily for internal use
  • Performance Review: part of the purpose of deploying this extension is to allow Content-Transform-Team to benchmark Parsoid rendering under realistic conditions for production read views
  • Deploy on beta sites
  • Deploy on test wikis
  • Deploy on all wikis

Related Objects

Event Timeline

cscott updated the task description. (Show Details)
cscott updated the task description. (Show Details)

Change 944978 had a related patch set uploaded (by Sbailey; author: Sbailey):

[operations/mediawiki-config@master] WIP re-enabling parser migration extension on labs

https://gerrit.wikimedia.org/r/944978

Change 944978 merged by jenkins-bot:

[operations/mediawiki-config@master] Re-enable Extension:ParserMigration on labs

https://gerrit.wikimedia.org/r/944978

Mentioned in SAL (#wikimedia-operations) [2023-10-03T20:11:49Z] <jdrewniak@deploy2002> Started scap: Backport for [[gerrit:944978|Re-enable Extension:ParserMigration on labs (T333179)]]

Mentioned in SAL (#wikimedia-operations) [2023-10-03T20:34:06Z] <jdrewniak@deploy2002> jdrewniak and sbailey: Backport for [[gerrit:944978|Re-enable Extension:ParserMigration on labs (T333179)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2023-10-03T20:50:42Z] <jdrewniak@deploy2002> Finished scap: Backport for [[gerrit:944978|Re-enable Extension:ParserMigration on labs (T333179)]] (duration: 38m 52s)

Change 965542 had a related patch set uploaded (by Sbailey; author: Sbailey):

[operations/mediawiki-config@master] Set UseParserMigration true in wmf-config

https://gerrit.wikimedia.org/r/965542

Change 965542 merged by jenkins-bot:

[operations/mediawiki-config@master] Set UseParserMigration true in wmf-config

https://gerrit.wikimedia.org/r/965542

Mentioned in SAL (#wikimedia-operations) [2023-10-12T21:12:02Z] <thcipriani@deploy2002> Started scap: Backport for [[gerrit:965542|Set UseParserMigration true in wmf-config (T333179)]]

Mentioned in SAL (#wikimedia-operations) [2023-10-12T21:13:20Z] <thcipriani@deploy2002> sbailey and thcipriani: Backport for [[gerrit:965542|Set UseParserMigration true in wmf-config (T333179)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2023-10-12T21:27:22Z] <thcipriani@deploy2002> Finished scap: Backport for [[gerrit:965542|Set UseParserMigration true in wmf-config (T333179)]] (duration: 15m 20s)

Is this task related to a strange new development that we are seeing at en.WP? When we click an "edit" link from https://en.wikipedia.org/wiki/Special:LintErrors/deletable-table-tag?namespace=0 we get "action=parsermigration-edit" at the end of the URL instead of "action=edit".

The resulting editing window shows two columns of rendering, often with poor rendering on the right side, including misapplied bolding and missing references. The edit window also fails to display the LintHint gadget that we load via .js, so we are unable to locate Linter errors in the code.

Thanks for flagging!

Ya, I am sure it is related to that. It is possible Linter extension may have been configured to work with ParserMigration from the Tidy -> Remex migration days. Renabling ParserMigration may have re-enabled that behavior now.

Someone will take a look and try to fix it by Monday.

Change 965777 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/extensions/Linter@master] Remove ParserMigration association

https://gerrit.wikimedia.org/r/965777

Change 965777 merged by jenkins-bot:

[mediawiki/extensions/Linter@master] Remove ParserMigration association

https://gerrit.wikimedia.org/r/965777