Experimentally enable Parsoid Read Views pages on query string
Closed, ResolvedPublic
Actions

Description

In this task we will experimentally enable parsoid read views if ?useparsoid=1 is present in the query string. This will allow us to do visualdiff and other compatibility testing using production article contents.

Impact on parser cache usage should be minimal, as long as commons and wikidata are excluded.

Eventually this support will be implemented as part of the ParserMigration extension (T333179) along with other migration-related features.

Details

Subject	Repo	Branch	Lines +/-
[ParsoidParser] Move parsoid skinning module from Article	mediawiki/core	master	+3 -4
Support useparsoid query option	mediawiki/extensions/FlaggedRevs	master	+51 -8
ParsoidParser: Record ParserOptions watcher on ParserOutput object	mediawiki/core	master	+45 -4
Add parsoid skinning module to article page when useparsoid=1	mediawiki/core	master	+4 -0
Turn on experimental Parsoid Read Views support, except on commons & wikidata	operations/mediawiki-config	master	+7 -0
Bump parsoid to 0.18.0-a6	mediawiki/vendor	master	+186 -73
Experimenally enable Parsoid Read Views with ?useparsoid=1 query string	mediawiki/services/parsoid	master	+39 -1

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open	Release	None	T84936 Release VisualEditor-MediaWiki as "1.0"
Open		None	T50429 [Epic] Support editing parts of a page in VisualEditor-MediaWiki
Open		None	T54365 Explore performance gains from progressive (JIT?) de-alienation in VisualEditor
Open		None	T174303 Copy-pasting linked ISBN numbers from view mode HTML into VisualEditor inserts wikitext links to Special:BookSources (it should turn them into magic links?)
Open	Feature	None	T54091 The read HTML should have hinting to allow full DOM copying (as opposed to just rich copying) from read mode into VE surfaces
Open		None	T55784 [EPIC] Use Parsoid HTML for all page views
Resolved		cscott	T335157 Experimentally enable Parsoid Read Views pages on query string
Resolved		ssastry	T334980 Run visual diff testing without RL and other hacks to compare Parsoid rendering against legacy parser rendering
Resolved		• Sbailey	T333179 (Re)deploy ParserMigration extension to production
Resolved		cscott	T333177 Update ParserMigration extension to support Parsoid/Legacy
Resolved		mmartorana	T334962 Security Review re: Redeployment of ParserMigration extension to production

Event Timeline

cscott created this task.Apr 20 2023, 5:13 PM

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptApr 20 2023, 5:13 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 910556 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[operations/mediawiki-config@master] Turn on experimental Parsoid Read Views support, except on commons & wikidata

https://gerrit.wikimedia.org/r/910556

Change 910044 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/services/parsoid@master] Experimenally enable Parsoid Read Views with ?useparsoid=1 query string

https://gerrit.wikimedia.org/r/910044

cscott updated the task description. (Show Details)Apr 20 2023, 5:16 PM

Change 910044 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Experimenally enable Parsoid Read Views with ?useparsoid=1 query string

https://gerrit.wikimedia.org/r/910044

Change 911253 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/vendor@master] Bump parsoid to 0.18.0-a6

https://gerrit.wikimedia.org/r/911253

Change 911253 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.18.0-a6

https://gerrit.wikimedia.org/r/911253

Arlolra added a project: Parsoid-Read-Views.Apr 24 2023, 3:51 PM

Jgiannelos edited projects, added Content-Transform-Team-WIP; removed Parsoid.Apr 27 2023, 2:17 PM

Restricted Application added a project: Parsoid. · View Herald TranscriptApr 27 2023, 2:17 PM

Jgiannelos assigned this task to cscott.Apr 27 2023, 2:17 PM

Jgiannelos moved this task from Backlog to To Deploy on the Content-Transform-Team-WIP board.

Jgiannelos removed a project: Parsoid.

Sophivorus subscribed.Apr 30 2023, 2:59 AM

Change 910556 merged by jenkins-bot:

[operations/mediawiki-config@master] Turn on experimental Parsoid Read Views support, except on commons & wikidata

https://gerrit.wikimedia.org/r/910556

Mentioned in SAL (#wikimedia-operations) [2023-05-03T13:53:57Z] <lucaswerkmeister-wmde@deploy1002> Started scap: Backport for [[gerrit:910556|Turn on experimental Parsoid Read Views support, except on commons & wikidata (T335157)]]

Mentioned in SAL (#wikimedia-operations) [2023-05-03T13:55:25Z] <lucaswerkmeister-wmde@deploy1002> lucaswerkmeister-wmde and cscott: Backport for [[gerrit:910556|Turn on experimental Parsoid Read Views support, except on commons & wikidata (T335157)]] synced to the testservers: mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-05-03T14:09:25Z] <lucaswerkmeister-wmde@deploy1002> Finished scap: Backport for [[gerrit:910556|Turn on experimental Parsoid Read Views support, except on commons & wikidata (T335157)]] (duration: 15m 27s)

MSantos moved this task from Uncategorized to Phase 1 - DiscussionTools support on the Parsoid-Read-Views board.May 4 2023, 2:27 PM

MSantos edited projects, added Parsoid-Read-Views (Phase 1 - DiscussionTools support); removed Parsoid-Read-Views.

Waiting for SRE help to actually make this capability accessing from the RT servers: T334980#8829371

cscott moved this task from Backlog to In Progress on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.May 9 2023, 2:01 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.9; 2023-05-15).May 15 2023, 8:01 PM

RhinosF1 subscribed.Jun 5 2023, 7:04 AM

ssastry triaged this task as High priority.Jun 7 2023, 6:22 AM

ssastry moved this task from To Deploy to To Verify on the Content-Transform-Team-WIP board.

Looks like this is live!

https://en.wikipedia.org/wiki/User:Cscott?useparsoid=1

Change 933617 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@master] Add parsoid skinning module to article page when useparsoid=1

https://gerrit.wikimedia.org/r/933617

Change 934035 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/extensions/FlaggedRevs@master] WIP: Support useparsoid query option

https://gerrit.wikimedia.org/r/934035

Test wiki created on Patch demo by SSastry (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/6c133be1d3/w

Test wiki created on Patch demo by SSastry (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/7576229393/w

Test wiki on Patch demo by SSastry (WMF) using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/7576229393/w/~~

Test wiki on Patch demo by SSastry (WMF) using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/6c133be1d3/w/~~

Change 933617 merged by jenkins-bot:

[mediawiki/core@master] Add parsoid skinning module to article page when useparsoid=1

https://gerrit.wikimedia.org/r/933617

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.16; 2023-07-04); removed MW-1.41-notes (1.41.0-wmf.9; 2023-05-15).Jun 29 2023, 11:00 PM

Change 935828 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/core@master] ParsoidParser: Record ParserOptions watcher on ParserOutput object

https://gerrit.wikimedia.org/r/935828

Change 935828 merged by jenkins-bot:

[mediawiki/core@master] ParsoidParser: Record ParserOptions watcher on ParserOutput object

https://gerrit.wikimedia.org/r/935828

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.18; 2023-07-18); removed MW-1.41-notes (1.41.0-wmf.16; 2023-07-04).Jul 13 2023, 10:00 PM

Change 934035 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Support useparsoid query option

https://gerrit.wikimedia.org/r/934035

MSantos closed subtask T334980: Run visual diff testing without RL and other hacks to compare Parsoid rendering against legacy parser rendering as Resolved.Sep 19 2023, 4:04 PM

Change 976283 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] [ParsoidParser] Move parsoid skinning module from Article

https://gerrit.wikimedia.org/r/976283

Change 976283 merged by jenkins-bot: