Maniphest T331887

Add ::isSameCodeAs() method to wikimedia/bcp47code
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	cscott
	Mar 13 2023, 3:44 PM

Tags

Referenced Files

None

Subscribers

Description

It's not super complicated, but BCP-47 codes are case-insensitive and MediaWiki tends to convert things from lower to title case when it formats internal codes as bcp-47. We should add an ::isSameCodeAs() method to Bcp47 to make folks more likely to get this right.

Details

	Subject	Repo	Branch	Lines +/-
	Implement Language::isSameCodeAs()	mediawiki/core	master	+56 -0
	Release wikimedia/bcp-47-code v2.0.0	mediawiki/libs/Bcp47Code	main	+2 -1
	Add Bcp47Code::isSameCodeAs()	mediawiki/libs/Bcp47Code	main	+59 -1

Customize query in gerrit

Related Objects

Mentioned In: rMLBC0d2204a8c3bb: Release wikimedia/bcp-47-code v2.0.0
rMLBC8b4b81310125: Add Bcp47Code::isSameCodeAs()

Event Timeline

cscott created this task.Mar 13 2023, 3:44 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 13 2023, 3:44 PM

Aklapper added a project: Bcp47Code.Mar 13 2023, 4:11 PM

Change 897949 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/libs/Bcp47Code@main] Add Bcp47Code::isSameCodeAs()

https://gerrit.wikimedia.org/r/897949

gerritbot added a project: Patch-For-Review.Mar 13 2023, 5:00 PM

Change 897949 merged by jenkins-bot:

[mediawiki/libs/Bcp47Code@main] Add Bcp47Code::isSameCodeAs()

https://gerrit.wikimedia.org/r/897949

Maintenance_bot removed a project: Patch-For-Review.May 20 2023, 1:10 PM

Jdforrester-WMF mentioned this in rMLBC8b4b81310125: Add Bcp47Code::isSameCodeAs().May 20 2023, 3:30 PM

Change 962070 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Implement Language::isSameCodeAs()

https://gerrit.wikimedia.org/r/962070

gerritbot added a project: Patch-For-Review.Sep 29 2023, 6:37 PM

Change 962072 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/libs/Bcp47Code@main] Release wikimedia/bcp-47-code v2.0.0

https://gerrit.wikimedia.org/r/962072

Change 962072 merged by jenkins-bot:

[mediawiki/libs/Bcp47Code@main] Release wikimedia/bcp-47-code v2.0.0

https://gerrit.wikimedia.org/r/962072

cscott mentioned this in rMLBC0d2204a8c3bb: Release wikimedia/bcp-47-code v2.0.0.Sep 30 2023, 12:24 AM

Change 962070 merged by jenkins-bot:

[mediawiki/core@master] Implement Language::isSameCodeAs()

https://gerrit.wikimedia.org/r/962070

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.30; 2023-10-10).Oct 4 2023, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 4 2023, 5:10 PM