Page MenuHomePhabricator

ParserIntegrationTest failures in Wikibase gate-and-submit php81 jobs: Failed asserting that two strings are equal
Closed, InvalidPublic

Description

Two consecutive gate-and-submit jobs for this Wikibase change have failed, exclusively in the php81 jobs:

Most of the test failures are from ParserIntegrationTest, and the remaining failures also look parser-related, e.g.:

12) Wikibase\Client\Tests\Integration\Hooks\DeletePageNoticeCreatorTest::testGetPageDeleteNoticeHtml with data set #0 ('<div class="plainlinks">Der L...</div>', MediaWiki\Title\Title Object (...), 'after page delete')
after page delete
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<div class="plainlinks">Der Link auf diese Seite sollte von <a rel="nofollow" class="external text" href="http://www.example.com/wiki/Special:EntityPage/Q4880">dem dazugehörigen TestWiki-Objekt</a> entfernt worden sein. Wir bitten dich zu prüfen, ob dies geschehen ist.</div>'
+'<div class="plainlinks">Der Link auf diese Seite sollte von <a rel="nofollow" class="external text" href="http://www.example.com/wiki/Special:EntityPage/Q4880">dem dazugehörigen ($*)-Objekt</a> entfernt worden sein. Wir bitten dich zu prüfen, ob dies geschehen ist.</div>'

17) ParserIntegrationTest::testParse with data set "bookReferencing.txt: Extended references can be reused" ('legacy')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'<p><sup id="cite_ref-a_1-0" class="reference"><a href="#cite_note-a-1">&#91;1&#93;</a></sup>\n
-<sup id="cite_ref-b_2-0" class="reference"><a href="#cite_note-b-2">&#91;1.1&#93;</a></sup>\n
-<sup id="cite_ref-b_2-1" class="reference"><a href="#cite_note-b-2">&#91;1.1&#93;</a></sup>\n
+'<p><sup id="cite_ref-a_1-0" class="reference"><a href="#cite_note-a-1">&#91;($*)&#93;</a></sup>\n
+<sup id="cite_ref-b_2-0" class="reference"><a href="#cite_note-b-2">&#91;($*).1&#93;</a></sup>\n
+<sup id="cite_ref-b_2-1" class="reference"><a href="#cite_note-b-2">&#91;($*).1&#93;</a></sup>\n
 </p>\n

Some strangeness around ($*), it seems.

Event Timeline

Change 899537 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] DNM: Empty change to test CI

https://gerrit.wikimedia.org/r/899537

Hmm, it doesn’t seem to happen in the check php build for the above change so far. Perhaps there’s some unexpected issue with the Gerrit change where the gate-and-submit errors happened?

Okay, both the test and php pipelines succeeded there now. Untagging shared build failure while it’s unclear that it really affects more than just the one change. Let’s wait for a proper gate-and-submit on another Wikibase change and see how that goes.

Okay, looks like it’s not a general problem after all. Must be something wrong with my change, though I have no idea what…

Change 899537 abandoned by Lucas Werkmeister (WMDE):

[mediawiki/extensions/Wikibase@master] DNM: Empty change to test CI

Reason:

https://gerrit.wikimedia.org/r/899537

Apparently these test failures are due to the test changes? When I revert them, check php passes again. o_O

I think we should reopen this task again (or create a new, more focused, one). Changes to Wikibase tests should not make core parser tests fail.