Page MenuHomePhabricator

Combobox: Button submits the form
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Put the CdxCombobox component inside a <form>
  • Press the combobox button to open the menu

What happens?:

The form submits

What should have happened instead?:

The menu should open. We just need to set the native button type to "button".

Software version (skip for WMF-hosted wikis like Wikipedia): Codex 0.7.0

Other information (browser name/version, screenshots, etc.):

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
AnneT triaged this task as High priority.Mar 15 2023, 12:49 PM
AnneT moved this task from Inbox to Up Next on the Design-System-Team board.

This is a simple fix for a pretty egregious bug; let's just fix it

Change 900734 had a related patch set uploaded (by Anne Tomasevich; author: Anne Tomasevich):

[design/codex@main] Buttons, docs: use `weight` prop and set appropriate `type`

https://gerrit.wikimedia.org/r/900734

Change 900734 merged by jenkins-bot:

[design/codex@main] Buttons, docs: use `weight` prop and set appropriate `type`

https://gerrit.wikimedia.org/r/900734

AnneT changed the task status from Open to In Progress.Mar 17 2023, 8:37 PM
AnneT claimed this task.

Change 903778 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] Update Codex from v0.7.0 to v0.8.0

https://gerrit.wikimedia.org/r/903778

Change 903778 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v0.7.0 to v0.8.0

https://gerrit.wikimedia.org/r/903778