We renamed the EntitySchema extension from WikibaseSchema to EntitySchema, and the namespace and concept from just Schema to EntitySchema, relatively shortly before launch (T221942); as a result, some of the classes and files still have names with “Schema” but should instead be “EntitySchema” – such as SchemaInserter, SchemaId, SchemaDiffer etc., but also resources/special.newSchema.js and tests/selenium/specs/editSchema.js in JS. We should rename them to make the terminology consistent and the code less confusing.
Acceptance Criteria:
- The classes and files listed below should reflect our agreed upon terminology of EntitySchema (instead of Schema)
PHP classes
- SchemaId
- SchemaCleaner
- SchemaEncoder
- SchemaInserter
- SchemaUpdateGuard
- SchemaUpdater
- MediaWikiRevisionSchemaInserter
- MediaWikiRevisionSchemaUpdater
- SchemaDiffer
- SchemaPatcher
- SchemaEditAction
- SchemaSubmitAction
- SchemaConverter
- FullArraySchemaData
- FullViewSchemaData
- PersistenceSchemaData
Namespaces / directories
- SchemaConverter
Files
- .phan/stubs/WikibaseSchema.php
- resources/viewSchema.less
- resources/special.newSchema.js
- resources/special.setSchemaLabelDescriptionAliases.edit.js
- tests/selenium/specs/editSchema.js
- cypress/e2e/viewSchema.cy.js
- cypress/support/pageObjects/ViewSchemaPage.js
Other
- maintenance/createPreexistingSchemas.php – is this even worth keeping at all? (Also, if we do keep it, also rename it to initial uppercase, cf. Wikibase ADR 12.)