Page MenuHomePhabricator

maybeUpdateImplementationRanking: Investigate why the check for "same first element" isn't succeeding
Closed, ResolvedPublic

Description

Description

When maybeUpdateImplementationRanking (in ApiPerformTest.php) runs on beta, and produces a new implementation-ordering with the same first element as the existing ordering, it should bail out with the following message, but most of the time it doesn't:

MediaWiki\Extension\WikiLambda\API\ApiPerformTest::maybeUpdateImplementationRanking Bailing: Same first element

To observe this: check the JSON for Z10020 to see that Z10033 is the first element; trigger the job as described in T332533; then, on logstash, look in the Editing Function to update Implementations order message to see that the new ordering also has Z10033 as the first element..

Desired behavior/Acceptance criteria

  • The job should bail as described above, and UpdateImplementationsJob should not be instantiated at all

Completion checklist

Event Timeline

Change 903851 had a related patch set uploaded (by David Martin; author: David Martin):

[mediawiki/extensions/WikiLambda@master] ApiPerformTest: Correct the expression for obtaining $previousFirst

https://gerrit.wikimedia.org/r/903851

Change 903851 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] ApiPerformTest: Correct the expression for obtaining $previousFirst

https://gerrit.wikimedia.org/r/903851

DMartin-WMF claimed this task.