Maniphest T332746

Return Z22 with Error if Call to Wiki Fails
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cmassaro
	Mar 21 2023, 10:44 PM

Tags

Referenced Files

None

Subscribers

Description

Description

Currently, if a wikilambda_fetch operation goes wrong, the orchestrator will surface an exception when it tries to access undefined.wikilambda_fetch. This is not good. The orchestrator should return a Z22 with an error in its metadata.

Also, the Z22 returned is a little odd, since it populates neither the result nor the error, which should never happen.

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

failed fetches return an error
bug will be filed to determine why a degenerate Z22 arises in this case

Completion checklist

Before closing this task, review one by one the checklist available here: https://www.mediawiki.org/wiki/Abstract_Wikipedia_team/Definition_of_Done#Back-end_Task/Bug_completion_checklist

Details

	Subject	Repo	Branch	Lines +/-
	Fix ApiPerformTest test: not found when passed a non existing implementation	mediawiki/extensions/WikiLambda	master	+1 -1
	Return error in Z22 when call to wikilambda_fetch fails to retrieve an object.	mediawiki/services/function-orchestrator	master	+60 -10

Customize query in gerrit

Related Objects

Mentioned In: rMSFO693ebc4f7c1f: Return error in Z22 when call to wikilambda_fetch fails to retrieve an object.

Event Timeline

cmassaro created this task.Mar 21 2023, 10:44 PM

cmassaro added a project: Abstract Wikipedia Fix-It tasks.

cmassaro updated the task description. (Show Details)Mar 22 2023, 2:41 PM

Jdforrester-WMF triaged this task as High priority.Mar 24 2023, 12:37 AM

Change 902789 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-orchestrator@master] Return error in Z22 when call to wikilambda_fetch fails to retrieve an object.

https://gerrit.wikimedia.org/r/902789

gerritbot added a project: Patch-For-Review.Mar 24 2023, 7:58 PM

cmassaro claimed this task.Mar 24 2023, 8:23 PM

Change 902789 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] Return error in Z22 when call to wikilambda_fetch fails to retrieve an object.

https://gerrit.wikimedia.org/r/902789

Jdforrester-WMF mentioned this in rMSFO693ebc4f7c1f: Return error in Z22 when call to wikilambda_fetch fails to retrieve an object..Mar 27 2023, 11:00 AM

Maintenance_bot removed a project: Patch-For-Review.Mar 27 2023, 11:10 AM

Change 903251 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Fix ApiPerformTest test: not found when passed a non existing implementation

https://gerrit.wikimedia.org/r/903251

gerritbot added a project: Patch-For-Review.Mar 27 2023, 1:36 PM

Change 903251 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Fix ApiPerformTest test: not found when passed a non existing implementation

https://gerrit.wikimedia.org/r/903251

Maintenance_bot removed a project: Patch-For-Review.Mar 27 2023, 2:11 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.2; 2023-03-27).Mar 27 2023, 3:00 PM

Jdforrester-WMF closed this task as Resolved.Mar 28 2023, 6:39 PM

Jdforrester-WMF edited projects, added Abstract Wikipedia team (Phase κ – Clean-up); removed Abstract Wikipedia team.